From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm: reset ELD if NULL edid is passed to drm_edid_to_eld
Date: Thu, 16 Feb 2017 17:36:58 +0200 [thread overview]
Message-ID: <20170216153658.GE31595@intel.com> (raw)
In-Reply-To: <52d10c0d908a51a9d71a06fc1a7ebb2d565b7689.1487241304.git.jani.nikula@intel.com>
On Thu, Feb 16, 2017 at 12:36:43PM +0200, Jani Nikula wrote:
> Make the function useful for resetting, not just setting, the ELD.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 24e7b282f16c..362036360724 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3430,6 +3430,9 @@ void drm_edid_to_eld(struct drm_connector *connector, struct edid *edid)
>
> memset(eld, 0, sizeof(connector->eld));
>
> + if (!edid)
> + return;
> +
> connector->latency_present[0] = false;
> connector->latency_present[1] = false;
> connector->video_latency[0] = 0;
/me thinks the check should be after all these.
Hmm. Actually the cea ext block check below should be safe wrt.
edid==NULL, so not sure we need this at all.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-16 15:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 10:36 [PATCH 0/3] drm: handle override/firmware edid at the lowest level Jani Nikula
2017-02-16 10:36 ` [PATCH 1/3] drm: move edid property update and add modes out of edid firmware loader Jani Nikula
2017-02-16 10:36 ` [PATCH 2/3] drm: reset ELD if NULL edid is passed to drm_edid_to_eld Jani Nikula
2017-02-16 15:36 ` Ville Syrjälä [this message]
2017-02-17 14:02 ` Jani Nikula
2017-02-17 14:06 ` Ville Syrjälä
[not found] ` <cover.1487240619.git.jani.nikula@intel.com>
2017-02-16 10:36 ` [PATCH 3/3] drm: handle override edid and firmware adid at drm_do_get_edid() Jani Nikula
2017-02-16 10:40 ` Jani Nikula
2017-02-16 10:36 ` [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level Jani Nikula
2017-02-16 15:41 ` Ville Syrjälä
2017-02-16 17:54 ` Jani Nikula
2017-02-16 18:18 ` Ville Syrjälä
2017-02-16 18:59 ` Jani Nikula
2017-02-16 19:14 ` Ville Syrjälä
2017-02-26 20:50 ` Daniel Vetter
2017-02-16 15:00 ` ✗ Fi.CI.BAT: failure for drm: handle override/firmware edid at the lowest level Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216153658.GE31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox