From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level Date: Thu, 16 Feb 2017 20:18:08 +0200 Message-ID: <20170216181808.GM31595@intel.com> References: <20170216154132.GF31595@intel.com> <87tw7udnt3.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87tw7udnt3.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMDc6NTQ6MDBQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAxNiBGZWIgMjAxNywgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBUaHUsIEZlYiAxNiwgMjAxNyBhdCAxMjoz Njo0NVBNICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+PiBIYW5kbGUgZGVidWdmcyBvdmVy cmlkZSBlZGlkIGFuZCBmaXJtd2FyZSBlZGlkIGF0IHRoZSBsb3cgbGV2ZWwgdG8KPiA+PiB0cmFu c3BhcmVudGx5IGFuZCBjb21wbGV0ZWx5IHJlcGxhY2UgdGhlIHJlYWwgZWRpZC4gUHJldmlvdXNs eSwgd2UKPiA+PiBwcmFjdGljYWxseSBvbmx5IHVzZWQgdGhlIG1vZGVzIGZyb20gdGhlIG92ZXJy aWRlIEVESUQsIGFuZCBub25lIG9mIHRoZQo+ID4+IG90aGVyIGRhdGEuIFRoaXMgYWxzbyBwcmV2 ZW50cyBhY3R1YWwgRURJRCByZWFkcyB3aGVuIHRoZSBFRElEIGlzIHRvIGJlCj4gPj4gb3ZlcnJp ZGRlbiwgYnV0IHJldGFpbnMgdGhlIEREQyBwcm9iZS4KPiA+Cj4gPiBIbW0uIElzbid0IHRoYXQg YSBiYWQgdGhpbmc/IElmIHNvbWVvbmUgaGFzIGJyb2tlbiBEREMgb24gdGhlaXIgY2FibGUgb3IK PiA+IHNvbWV0aGlnbiB0aGVuIHRoZSBvdmVycmlkZSBFRElEIHdvdWxkbid0IGJlIHJldHVybmVk IGJ5IGRybV9nZXRfZWRpZCgpLgo+IAo+IElzbid0IHRoaXMgaW4gbGluZSB3aXRoIGhvdyB0aGlz IGN1cnJlbnRseSB3b3Jrcz8KCk5vdCByZWFsbHkuIElmIGNvbm5lY3Rvci0+Zm9yY2UgaXMgdXNl ZCBhbmQgYW4gb3ZlcnJpZGUgRURJRCBpcwpwcm92aWRlZCwgdGhlbiBkcm1fZ2V0X2VkaWQoKSBs aWtlbHkgbmV2ZXIgZ2V0cyBjYWxsZWQsIGFuZCB0aGUgbW9kZXMKY29tZSBkaXJlY3RseSBmcm9t IHRoZSBvdmVyaWRlIEVESUQuIFdpdGggeW91ciBjaGFuZ2UgZm9yY2luZyB0aGUKY29ubmVjdG9y IHN0YXRlIHdvdWxkbid0IGJlY2F1c2Ugd2Ugc3RpbGwgd291bGRuJ3QgZ2V0IGFueSBtb2Rlcwpm cm9tIHRoZSBvdmVycmlkZSBFRElEIGR1ZSB0byB0aGUgRERDIGNoZWNrLgoKSSBndWVzcyBvbmUg d2F5IGFyb3VuZCB0aGlzIHdvdWxkIGJlIHRvIHNraXAgdGhlIEREQyBjaGVjayBpZiB0aGUKY29u bmVjdG9yIHN0YXRlIGhhcyBiZWVuIGZvcmNlZC4KCj4gCj4gQlIsCj4gSmFuaS4KPiAKPiAKPiA+ Cj4gPj4gCj4gPj4gRklYTUU6IHZhbGlkYXRlIG92ZXJyaWRlIGVkaWQsIGRlZHVwbGljYXRlIGZp cm13YXJlIGVkaWQgdmFsaWRhdGlvbi4KPiA+PiAKPiA+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5p a3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL2dwdS9k cm0vZHJtX2VkaWQuYyAgICAgICAgIHwgMTUgKysrKysrKysrKysrKysrCj4gPj4gIGRyaXZlcnMv Z3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMgfCAxOSArLS0tLS0tLS0tLS0tLS0tLS0tCj4gPj4g IDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4gPj4g Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9lZGlkLmMKPiA+PiBpbmRleCAzNjIwMzYzNjA3MjQuLjA1NGUyZDc0ZWFmYyAx MDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+ID4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gPj4gQEAgLTEzMDksNiArMTMwOSwxMCBAQCBzdGF0 aWMgdm9pZCBjb25uZWN0b3JfYmFkX2VkaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv ciwKPiA+PiAgICogbGV2ZWwsIGRyaXZlcnMgbXVzdCBtYWtlIGFsbCByZWFzb25hYmxlIGVmZm9y dHMgdG8gZXhwb3NlIGl0IGFzIGFuIEkyQwo+ID4+ICAgKiBhZGFwdGVyIGFuZCB1c2UgZHJtX2dl dF9lZGlkKCkgaW5zdGVhZCBvZiBhYnVzaW5nIHRoaXMgZnVuY3Rpb24uCj4gPj4gICAqCj4gPj4g KyAqIFRoZSBFRElEIG1heSBiZSBvdmVycmlkZGVuIHVzaW5nIGRlYnVnZnMgb3ZlcnJpZGVfZWRp ZCBvciBmaXJtYXJlIEVESUQKPiA+PiArICogKGRybV9sb2FkX2VkaWRfZmlybXdhcmUoKSksIGlu IHRoaXMgcHJpb3JpdHkgb3JkZXIuIEhhdmluZyBlaXRoZXIgb2YgdGhlbQo+ID4+ICsgKiBieXBh c3NlcyBhY3R1YWwgRURJRCByZWFkcy4KPiA+PiArICoKPiA+PiAgICogUmV0dXJuOiBQb2ludGVy IHRvIHZhbGlkIEVESUQgb3IgTlVMTCBpZiB3ZSBjb3VsZG4ndCBmaW5kIGFueS4KPiA+PiAgICov Cj4gPj4gIHN0cnVjdCBlZGlkICpkcm1fZG9fZ2V0X2VkaWQoc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvciwKPiA+PiBAQCAtMTMxOCw2ICsxMzIyLDE3IEBAIHN0cnVjdCBlZGlkICpkcm1f ZG9fZ2V0X2VkaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+PiAgewo+ID4+ ICAJaW50IGksIGogPSAwLCB2YWxpZF9leHRlbnNpb25zID0gMDsKPiA+PiAgCXU4ICplZGlkLCAq bmV3Owo+ID4+ICsJc3RydWN0IGVkaWQgKm92ZXJyaWRlID0gTlVMTDsKPiA+PiArCj4gPj4gKwlp ZiAoY29ubmVjdG9yLT5vdmVycmlkZV9lZGlkKQo+ID4+ICsJCW92ZXJyaWRlID0gZHJtX2VkaWRf ZHVwbGljYXRlKChjb25zdCBzdHJ1Y3QgZWRpZCAqKQo+ID4+ICsJCQkJCSAgICAgIGNvbm5lY3Rv ci0+ZWRpZF9ibG9iX3B0ci0+ZGF0YSk7Cj4gPj4gKwo+ID4+ICsJaWYgKCFvdmVycmlkZSkKPiA+ PiArCQlvdmVycmlkZSA9IGRybV9sb2FkX2VkaWRfZmlybXdhcmUoY29ubmVjdG9yKTsKPiA+PiAr Cj4gPj4gKwlpZiAoIUlTX0VSUl9PUl9OVUxMKG92ZXJyaWRlKSkKPiA+PiArCQlyZXR1cm4gb3Zl cnJpZGU7Cj4gPj4gIAo+ID4+ICAJaWYgKChlZGlkID0ga21hbGxvYyhFRElEX0xFTkdUSCwgR0ZQ X0tFUk5FTCkpID09IE5VTEwpCj4gPj4gIAkJcmV0dXJuIE5VTEw7Cj4gPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X3Byb2JlX2hlbHBlci5jCj4gPj4gaW5kZXggMzU4OTU3MTE4Y2E5Li44NzEzMjZjYmM0NjUgMTAw NjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+ID4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPiA+PiBAQCAtMTk5LDggKzE5 OSw2IEBAIGRybV9jb25uZWN0b3JfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IsIGJvb2wgZm9yY2UpCj4gPj4gICAqICAgIGRybV9tb2RlX3Byb2JlZF9hZGQoKS4gTmV3IG1v ZGVzIHN0YXJ0IHRoZWlyIGxpZmUgd2l0aCBzdGF0dXMgYXMgT0suCj4gPj4gICAqICAgIE1vZGVz IGFyZSBhZGRlZCBmcm9tIGEgc2luZ2xlIHNvdXJjZSB1c2luZyB0aGUgZm9sbG93aW5nIHByaW9y aXR5IG9yZGVyLgo+ID4+ICAgKgo+ID4+IC0gKiAgICAtIGRlYnVnZnMgJ292ZXJyaWRlX2VkaWQn ICh1c2VkIGZvciB0ZXN0aW5nIG9ubHkpCj4gPj4gLSAqICAgIC0gZmlybXdhcmUgRURJRCAoZHJt X2xvYWRfZWRpZF9maXJtd2FyZSgpKQo+ID4+ICAgKiAgICAtICZkcm1fY29ubmVjdG9yX2hlbHBl cl9mdW5jcy5nZXRfbW9kZXMgdmZ1bmMKPiA+PiAgICogICAgLSBpZiB0aGUgY29ubmVjdG9yIHN0 YXR1cyBpcyBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZCwgc3RhbmRhcmQKPiA+PiAgICogICAg ICBWRVNBIERNVCBtb2RlcyB1cCB0byAxMDI0eDc2OCBhcmUgYXV0b21hdGljYWxseSBhZGRlZAo+ ID4+IEBAIC0zMDUsMjIgKzMwMyw3IEBAIGludCBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25u ZWN0b3JfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+PiAgCQlnb3Rv IHBydW5lOwo+ID4+ICAJfQo+ID4+ICAKPiA+PiAtCWlmIChjb25uZWN0b3ItPm92ZXJyaWRlX2Vk aWQpIHsKPiA+PiAtCQlzdHJ1Y3QgZWRpZCAqZWRpZCA9IChzdHJ1Y3QgZWRpZCAqKSBjb25uZWN0 b3ItPmVkaWRfYmxvYl9wdHItPmRhdGE7Cj4gPj4gLQo+ID4+IC0JCWNvdW50ID0gZHJtX2FkZF9l ZGlkX21vZGVzKGNvbm5lY3RvciwgZWRpZCk7Cj4gPj4gLQkJZHJtX2VkaWRfdG9fZWxkKGNvbm5l Y3RvciwgZWRpZCk7Cj4gPj4gLQl9IGVsc2Ugewo+ID4+IC0JCXN0cnVjdCBlZGlkICplZGlkID0g ZHJtX2xvYWRfZWRpZF9maXJtd2FyZShjb25uZWN0b3IpOwo+ID4+IC0JCWlmICghSVNfRVJSX09S X05VTEwoZWRpZCkpIHsKPiA+PiAtCQkJZHJtX21vZGVfY29ubmVjdG9yX3VwZGF0ZV9lZGlkX3By b3BlcnR5KGNvbm5lY3RvciwgZWRpZCk7Cj4gPj4gLQkJCWNvdW50ID0gZHJtX2FkZF9lZGlkX21v ZGVzKGNvbm5lY3RvciwgZWRpZCk7Cj4gPj4gLQkJCWRybV9lZGlkX3RvX2VsZChjb25uZWN0b3Is IGVkaWQpOwo+ID4+IC0JCQlrZnJlZShlZGlkKTsKPiA+PiAtCQl9Cj4gPj4gLQkJaWYgKGNvdW50 ID09IDApCj4gPj4gLQkJCWNvdW50ID0gKCpjb25uZWN0b3JfZnVuY3MtPmdldF9tb2RlcykoY29u bmVjdG9yKTsKPiA+PiAtCX0KPiA+PiArCWNvdW50ID0gKCpjb25uZWN0b3JfZnVuY3MtPmdldF9t b2RlcykoY29ubmVjdG9yKTsKPiA+PiAgCj4gPj4gIAlpZiAoY291bnQgPT0gMCAmJiBjb25uZWN0 b3ItPnN0YXR1cyA9PSBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZCkKPiA+PiAgCQljb3VudCA9 IGRybV9hZGRfbW9kZXNfbm9lZGlkKGNvbm5lY3RvciwgMTAyNCwgNzY4KTsKPiA+PiAtLSAKPiA+ PiAyLjEuNAo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9s b2d5IENlbnRlcgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==