From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm: handle override edid and firmware EDID at drm_do_get_edid() level Date: Thu, 16 Feb 2017 21:14:45 +0200 Message-ID: <20170216191445.GO31595@intel.com> References: <20170216154132.GF31595@intel.com> <87tw7udnt3.fsf@intel.com> <20170216181808.GM31595@intel.com> <87lgt6dkse.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87lgt6dkse.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMTYsIDIwMTcgYXQgMDg6NTk6MTNQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAxNiBGZWIgMjAxNywgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBUaHUsIEZlYiAxNiwgMjAxNyBhdCAwNzo1 NDowMFBNICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+PiBPbiBUaHUsIDE2IEZlYiAyMDE3 LCBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToK PiA+PiA+IE9uIFRodSwgRmViIDE2LCAyMDE3IGF0IDEyOjM2OjQ1UE0gKzAyMDAsIEphbmkgTmlr dWxhIHdyb3RlOgo+ID4+ID4+IEhhbmRsZSBkZWJ1Z2ZzIG92ZXJyaWRlIGVkaWQgYW5kIGZpcm13 YXJlIGVkaWQgYXQgdGhlIGxvdyBsZXZlbCB0bwo+ID4+ID4+IHRyYW5zcGFyZW50bHkgYW5kIGNv bXBsZXRlbHkgcmVwbGFjZSB0aGUgcmVhbCBlZGlkLiBQcmV2aW91c2x5LCB3ZQo+ID4+ID4+IHBy YWN0aWNhbGx5IG9ubHkgdXNlZCB0aGUgbW9kZXMgZnJvbSB0aGUgb3ZlcnJpZGUgRURJRCwgYW5k IG5vbmUgb2YgdGhlCj4gPj4gPj4gb3RoZXIgZGF0YS4gVGhpcyBhbHNvIHByZXZlbnRzIGFjdHVh bCBFRElEIHJlYWRzIHdoZW4gdGhlIEVESUQgaXMgdG8gYmUKPiA+PiA+PiBvdmVycmlkZGVuLCBi dXQgcmV0YWlucyB0aGUgRERDIHByb2JlLgo+ID4+ID4KPiA+PiA+IEhtbS4gSXNuJ3QgdGhhdCBh IGJhZCB0aGluZz8gSWYgc29tZW9uZSBoYXMgYnJva2VuIEREQyBvbiB0aGVpciBjYWJsZSBvcgo+ ID4+ID4gc29tZXRoaWduIHRoZW4gdGhlIG92ZXJyaWRlIEVESUQgd291bGRuJ3QgYmUgcmV0dXJu ZWQgYnkgZHJtX2dldF9lZGlkKCkuCj4gPj4gCj4gPj4gSXNuJ3QgdGhpcyBpbiBsaW5lIHdpdGgg aG93IHRoaXMgY3VycmVudGx5IHdvcmtzPwo+ID4KPiA+IE5vdCByZWFsbHkuIElmIGNvbm5lY3Rv ci0+Zm9yY2UgaXMgdXNlZCBhbmQgYW4gb3ZlcnJpZGUgRURJRCBpcwo+ID4gcHJvdmlkZWQsIHRo ZW4gZHJtX2dldF9lZGlkKCkgbGlrZWx5IG5ldmVyIGdldHMgY2FsbGVkLCBhbmQgdGhlIG1vZGVz Cj4gPiBjb21lIGRpcmVjdGx5IGZyb20gdGhlIG92ZXJpZGUgRURJRC4gV2l0aCB5b3VyIGNoYW5n ZSBmb3JjaW5nIHRoZQo+ID4gY29ubmVjdG9yIHN0YXRlIHdvdWxkbid0IGJlY2F1c2Ugd2Ugc3Rp bGwgd291bGRuJ3QgZ2V0IGFueSBtb2Rlcwo+ID4gZnJvbSB0aGUgb3ZlcnJpZGUgRURJRCBkdWUg dG8gdGhlIEREQyBjaGVjay4KPiAKPiBSaWdodC4KPiAKPiA+IEkgZ3Vlc3Mgb25lIHdheSBhcm91 bmQgdGhpcyB3b3VsZCBiZSB0byBza2lwIHRoZSBEREMgY2hlY2sgaWYgdGhlCj4gPiBjb25uZWN0 b3Igc3RhdGUgaGFzIGJlZW4gZm9yY2VkLgo+IAo+IEkgZ3Vlc3MgSSdtIGFza2luZyBpZiB5b3Ug dGhpbmsgdGhlIHdob2xlIGFwcHJvYWNoIGhlcmUgaXMKPiB3b3JrYWJsZS4gV2hhdCB3ZSBjdXJy ZW50bHkgaGF2ZSBpcyBzbyBmbGFreS4KCkknbSAxMDAlIHdpdGggeW91IG9uIHRoYXQuIFNvIHll cywgSSBkbyBsaWtlIHRoZSBpZGVhLgoKSSB0aGluayB0aGUgbGFzdCB0aW1lIHRoZSBvdmVycmlk ZSBFRElEcyB3ZXJlIGRpc2N1c3NlZCBzb21lb25lIHdhcwpzdWdnZXN0aW5nIHRoYXQgdGhlIEVE SUQgb3ZlcnJpZGUgaXRzZWxmIHNob3VsZCBmb3JjZSB0aGUgY29ubmVjdG9yCnN0YXRlLiBJSVJD IERhbmllbCBkaWRuJ3QgYWdyZWUuIEkgZG9uJ3QgaGF2ZSBhIHBhcnRpY3VsYXJseSBzdHJvbmcK b3BpbmlvbiBlaXRoZXIgd2F5LCBidXQgSSBndWVzcyB0cnlpbmcgdG8gcHJlc2VydmUgdGhlIGN1 cnJlbnQKc2VtYW50aWNzIChpZS4gRURJRCBvdmVycmlkZSBhbmQgY29ubmVjdG9yIHN0YXR1cyBm b3JjaW5nIGFyZSBtb3N0bHkKc2VwYXJhdGUpIHdvdWxkIGJlIHRoZSB0aGluZyB0byBhaW0gZm9y LCBhdCBsZWFzdCBpbml0aWFsbHkuCgo+IAo+IEJSLAo+IEphbmkuCj4gCj4gPgo+ID4+IAo+ID4+ IEJSLAo+ID4+IEphbmkuCj4gPj4gCj4gPj4gCj4gPj4gPgo+ID4+ID4+IAo+ID4+ID4+IEZJWE1F OiB2YWxpZGF0ZSBvdmVycmlkZSBlZGlkLCBkZWR1cGxpY2F0ZSBmaXJtd2FyZSBlZGlkIHZhbGlk YXRpb24uCj4gPj4gPj4gCj4gPj4gPj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGludGVsLmNvbT4KPiA+PiA+PiAtLS0KPiA+PiA+PiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9lZGlkLmMgICAgICAgICB8IDE1ICsrKysrKysrKysrKysrKwo+ID4+ID4+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jIHwgMTkgKy0tLS0tLS0tLS0tLS0tLS0tLQo+ID4+ID4+ ICAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+ID4+ ID4+IAo+ID4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gPj4gPj4gaW5kZXggMzYyMDM2MzYwNzI0Li4wNTRl MmQ3NGVhZmMgMTAwNjQ0Cj4gPj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMK PiA+PiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+ID4+ID4+IEBAIC0xMzA5 LDYgKzEzMDksMTAgQEAgc3RhdGljIHZvaWQgY29ubmVjdG9yX2JhZF9lZGlkKHN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3IsCj4gPj4gPj4gICAqIGxldmVsLCBkcml2ZXJzIG11c3QgbWFr ZSBhbGwgcmVhc29uYWJsZSBlZmZvcnRzIHRvIGV4cG9zZSBpdCBhcyBhbiBJMkMKPiA+PiA+PiAg ICogYWRhcHRlciBhbmQgdXNlIGRybV9nZXRfZWRpZCgpIGluc3RlYWQgb2YgYWJ1c2luZyB0aGlz IGZ1bmN0aW9uLgo+ID4+ID4+ICAgKgo+ID4+ID4+ICsgKiBUaGUgRURJRCBtYXkgYmUgb3ZlcnJp ZGRlbiB1c2luZyBkZWJ1Z2ZzIG92ZXJyaWRlX2VkaWQgb3IgZmlybWFyZSBFRElECj4gPj4gPj4g KyAqIChkcm1fbG9hZF9lZGlkX2Zpcm13YXJlKCkpLCBpbiB0aGlzIHByaW9yaXR5IG9yZGVyLiBI YXZpbmcgZWl0aGVyIG9mIHRoZW0KPiA+PiA+PiArICogYnlwYXNzZXMgYWN0dWFsIEVESUQgcmVh ZHMuCj4gPj4gPj4gKyAqCj4gPj4gPj4gICAqIFJldHVybjogUG9pbnRlciB0byB2YWxpZCBFRElE IG9yIE5VTEwgaWYgd2UgY291bGRuJ3QgZmluZCBhbnkuCj4gPj4gPj4gICAqLwo+ID4+ID4+ICBz dHJ1Y3QgZWRpZCAqZHJtX2RvX2dldF9lZGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IsCj4gPj4gPj4gQEAgLTEzMTgsNiArMTMyMiwxNyBAQCBzdHJ1Y3QgZWRpZCAqZHJtX2RvX2dl dF9lZGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gPj4gPj4gIHsKPiA+PiA+ PiAgCWludCBpLCBqID0gMCwgdmFsaWRfZXh0ZW5zaW9ucyA9IDA7Cj4gPj4gPj4gIAl1OCAqZWRp ZCwgKm5ldzsKPiA+PiA+PiArCXN0cnVjdCBlZGlkICpvdmVycmlkZSA9IE5VTEw7Cj4gPj4gPj4g Kwo+ID4+ID4+ICsJaWYgKGNvbm5lY3Rvci0+b3ZlcnJpZGVfZWRpZCkKPiA+PiA+PiArCQlvdmVy cmlkZSA9IGRybV9lZGlkX2R1cGxpY2F0ZSgoY29uc3Qgc3RydWN0IGVkaWQgKikKPiA+PiA+PiAr CQkJCQkgICAgICBjb25uZWN0b3ItPmVkaWRfYmxvYl9wdHItPmRhdGEpOwo+ID4+ID4+ICsKPiA+ PiA+PiArCWlmICghb3ZlcnJpZGUpCj4gPj4gPj4gKwkJb3ZlcnJpZGUgPSBkcm1fbG9hZF9lZGlk X2Zpcm13YXJlKGNvbm5lY3Rvcik7Cj4gPj4gPj4gKwo+ID4+ID4+ICsJaWYgKCFJU19FUlJfT1Jf TlVMTChvdmVycmlkZSkpCj4gPj4gPj4gKwkJcmV0dXJuIG92ZXJyaWRlOwo+ID4+ID4+ICAKPiA+ PiA+PiAgCWlmICgoZWRpZCA9IGttYWxsb2MoRURJRF9MRU5HVEgsIEdGUF9LRVJORUwpKSA9PSBO VUxMKQo+ID4+ID4+ICAJCXJldHVybiBOVUxMOwo+ID4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9o ZWxwZXIuYwo+ID4+ID4+IGluZGV4IDM1ODk1NzExOGNhOS4uODcxMzI2Y2JjNDY1IDEwMDY0NAo+ ID4+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPiA+PiA+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4gPj4gPj4gQEAgLTE5OSw4 ICsxOTksNiBAQCBkcm1fY29ubmVjdG9yX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29u bmVjdG9yLCBib29sIGZvcmNlKQo+ID4+ID4+ICAgKiAgICBkcm1fbW9kZV9wcm9iZWRfYWRkKCku IE5ldyBtb2RlcyBzdGFydCB0aGVpciBsaWZlIHdpdGggc3RhdHVzIGFzIE9LLgo+ID4+ID4+ICAg KiAgICBNb2RlcyBhcmUgYWRkZWQgZnJvbSBhIHNpbmdsZSBzb3VyY2UgdXNpbmcgdGhlIGZvbGxv d2luZyBwcmlvcml0eSBvcmRlci4KPiA+PiA+PiAgICoKPiA+PiA+PiAtICogICAgLSBkZWJ1Z2Zz ICdvdmVycmlkZV9lZGlkJyAodXNlZCBmb3IgdGVzdGluZyBvbmx5KQo+ID4+ID4+IC0gKiAgICAt IGZpcm13YXJlIEVESUQgKGRybV9sb2FkX2VkaWRfZmlybXdhcmUoKSkKPiA+PiA+PiAgICogICAg LSAmZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MuZ2V0X21vZGVzIHZmdW5jCj4gPj4gPj4gICAq ICAgIC0gaWYgdGhlIGNvbm5lY3RvciBzdGF0dXMgaXMgY29ubmVjdG9yX3N0YXR1c19jb25uZWN0 ZWQsIHN0YW5kYXJkCj4gPj4gPj4gICAqICAgICAgVkVTQSBETVQgbW9kZXMgdXAgdG8gMTAyNHg3 NjggYXJlIGF1dG9tYXRpY2FsbHkgYWRkZWQKPiA+PiA+PiBAQCAtMzA1LDIyICszMDMsNyBAQCBp bnQgZHJtX2hlbHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9yX21vZGVzKHN0cnVjdCBkcm1fY29u bmVjdG9yICpjb25uZWN0b3IsCj4gPj4gPj4gIAkJZ290byBwcnVuZTsKPiA+PiA+PiAgCX0KPiA+ PiA+PiAgCj4gPj4gPj4gLQlpZiAoY29ubmVjdG9yLT5vdmVycmlkZV9lZGlkKSB7Cj4gPj4gPj4g LQkJc3RydWN0IGVkaWQgKmVkaWQgPSAoc3RydWN0IGVkaWQgKikgY29ubmVjdG9yLT5lZGlkX2Js b2JfcHRyLT5kYXRhOwo+ID4+ID4+IC0KPiA+PiA+PiAtCQljb3VudCA9IGRybV9hZGRfZWRpZF9t b2Rlcyhjb25uZWN0b3IsIGVkaWQpOwo+ID4+ID4+IC0JCWRybV9lZGlkX3RvX2VsZChjb25uZWN0 b3IsIGVkaWQpOwo+ID4+ID4+IC0JfSBlbHNlIHsKPiA+PiA+PiAtCQlzdHJ1Y3QgZWRpZCAqZWRp ZCA9IGRybV9sb2FkX2VkaWRfZmlybXdhcmUoY29ubmVjdG9yKTsKPiA+PiA+PiAtCQlpZiAoIUlT X0VSUl9PUl9OVUxMKGVkaWQpKSB7Cj4gPj4gPj4gLQkJCWRybV9tb2RlX2Nvbm5lY3Rvcl91cGRh dGVfZWRpZF9wcm9wZXJ0eShjb25uZWN0b3IsIGVkaWQpOwo+ID4+ID4+IC0JCQljb3VudCA9IGRy bV9hZGRfZWRpZF9tb2Rlcyhjb25uZWN0b3IsIGVkaWQpOwo+ID4+ID4+IC0JCQlkcm1fZWRpZF90 b19lbGQoY29ubmVjdG9yLCBlZGlkKTsKPiA+PiA+PiAtCQkJa2ZyZWUoZWRpZCk7Cj4gPj4gPj4g LQkJfQo+ID4+ID4+IC0JCWlmIChjb3VudCA9PSAwKQo+ID4+ID4+IC0JCQljb3VudCA9ICgqY29u bmVjdG9yX2Z1bmNzLT5nZXRfbW9kZXMpKGNvbm5lY3Rvcik7Cj4gPj4gPj4gLQl9Cj4gPj4gPj4g Kwljb3VudCA9ICgqY29ubmVjdG9yX2Z1bmNzLT5nZXRfbW9kZXMpKGNvbm5lY3Rvcik7Cj4gPj4g Pj4gIAo+ID4+ID4+ICAJaWYgKGNvdW50ID09IDAgJiYgY29ubmVjdG9yLT5zdGF0dXMgPT0gY29u bmVjdG9yX3N0YXR1c19jb25uZWN0ZWQpCj4gPj4gPj4gIAkJY291bnQgPSBkcm1fYWRkX21vZGVz X25vZWRpZChjb25uZWN0b3IsIDEwMjQsIDc2OCk7Cj4gPj4gPj4gLS0gCj4gPj4gPj4gMi4xLjQK PiA+PiAKPiA+PiAtLSAKPiA+PiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5v bG9neSBDZW50ZXIKPiAKPiAtLSAKPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50ZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=