From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arkadiusz Hiler Subject: Re: [PATCH 8/8] drm/i915/uc: Simplify firwmare path handling Date: Tue, 21 Feb 2017 15:44:55 +0100 Message-ID: <20170221144455.GD23207@ahiler-desk.igk.intel.com> References: <20170217130557.6710-1-arkadiusz.hiler@intel.com> <20170217130557.6710-9-arkadiusz.hiler@intel.com> <20170217142916.GH10072@mwajdecz-MOBL1.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ABA16E671 for ; Tue, 21 Feb 2017 14:45:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170217142916.GH10072@mwajdecz-MOBL1.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMTcsIDIwMTcgYXQgMDM6Mjk6MTdQTSArMDEwMCwgTWljaGFsIFdhamRlY3pr byB3cm90ZToKPiBPbiBGcmksIEZlYiAxNywgMjAxNyBhdCAwMjowNTo1N1BNICswMTAwLCBBcmth ZGl1c3ogSGlsZXIgd3JvdGU6Cj4gCj4gVHlwbyBpbiBzdWJqZWN0IHMvZmlyd21hcmUvZmlybXdh cmUKPiAKPiAKPiA+IEN1cnJlbnRseSBmdy0+cGF0aCB2YWx1ZXMgY2FuIHJlcHJlc2VudCBvbmUg b2YgdGhyZWUgcG9zc2libGUgc3RhdGVzOgo+ID4gCj4gPiAgMSkgTlVMTCAtIGRldmljZSB3aXRo b3V0IHRoZSB1Qwo+ID4gIDIpICdcMCcgLSBkZXZpY2Ugd2l0aCB0aGUgdUMgYnV0IGhhdmUgbm8g ZmlybXdhcmUKPiA+ICAzKSBlbHNlIC0gZGV2aWNlIHdpdGggdGhlIHVDIGFuZCB3ZSBoYXZlIGZp cm13YXJlCj4gPiAKPiA+IFNlY29uZCBjYXNlIGlzIHVzZWQgb25seSB0byBXQVJOIGF0IGEgbGF0 ZXIgc3RhZ2UuCj4gPiAKPiA+IFdlIGNhbiBXQVJOIHJpZ2h0IGF3YXkgYW5kIG1lcmdlIGNhc2Vz IDEgYW5kIDIuCj4gPiAKPiA+IENvZGUgY2FuIGJlIGV2ZW4gZnVydGhlciBzaW1wbGlmaWVkIGFu ZCBjb21tb24gKEh1Qy9HdUMgbG9naWMpIGhhcHBlbmluZwo+ID4gcmlnaHQgYmVmb3JlIHRoZSBm ZXRjaCBjYW4gYmUgb2ZmbG9hZGVkIHRvIHRoZSBjb21tb24gZnVuY3Rpb24uCj4gPiAKPiA+IHYy OiBmZXdlciB0ZW1wb3JhcnkgdmFyaWFibGVzLCBtb3JlIHN0cmFpZ2h0Zm9yd2FyZCBmbG93IChN LiBXYWpkZWN6a28pCj4gPiAKPiA+IENjOiBBbnVzaGEgU3JpdmF0c2EgPGFudXNoYS5zcml2YXRz YUBpbnRlbC5jb20+Cj4gPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs LmNvbT4KPiA+IENjOiBNaWNoYWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNv bT4KPiA+IENjOiBNaWNoYWwgV2FqZGVjemtvIDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4K PiA+IFNpZ25lZC1vZmYtYnk6IEFya2FkaXVzeiBIaWxlciA8YXJrYWRpdXN6LmhpbGVyQGludGVs LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIu YyB8IDM5ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2h1Yy5jICAgICAgICB8IDIwICsrKysrLS0tLS0tLS0tLS0tCj4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgICAgICAgIHwgIDUgKysrLS0KPiA+ICAz IGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDQyIGRlbGV0aW9ucygtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gPiBpbmRleCA1NDlhMjU0 Li5hYWRlMTg1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3Vj X2xvYWRlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVy LmMKPiA+IEBAIC00MzMsMTIgKzQzMyw4IEBAIGludCBpbnRlbF9ndWNfaW5pdF9odyhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCQlpbnRlbF91Y19md19zdGF0dXNfcmVw cihndWNfZnctPmxvYWRfc3RhdHVzKSk7Cj4gPiAgCj4gPiAgCWlmIChmd19wYXRoID09IE5VTEwp IHsKPiA+IC0JCS8qIERldmljZSBpcyBrbm93biB0byBoYXZlIG5vIHVDb2RlIChlLmcuIG5vIEd1 QykgKi8KPiA+ICsJCS8qIFdlIGRvIG5vdCBoYXZlIHVDb2RlIGZvciB0aGUgZGV2aWNlICovCj4g PiAgCQlyZXR1cm4gLUVOWElPOwo+ID4gLQl9IGVsc2UgaWYgKCpmd19wYXRoID09ICdcMCcpIHsK PiA+IC0JCS8qIERldmljZSBoYXMgYSBHdUMgYnV0IHdlIGRvbid0IGtub3cgd2hhdCBmL3cgdG8g bG9hZD8gKi8KPiA+IC0JCVdBUk4oMSwgIk5vIEd1QyBmaXJtd2FyZSBrbm93biBmb3IgdGhpcyBw bGF0Zm9ybSFcbiIpOwo+ID4gLQkJcmV0dXJuIC1FTk9ERVY7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJ LyogRmV0Y2ggZmFpbGVkLCBvciBhbHJlYWR5IGZldGNoZWQgYnV0IGZhaWxlZCB0byBsb2FkPyAq Lwo+ID4gQEAgLTQ3NCw3ICs0NzAsNiBAQCBpbnQgaW50ZWxfZ3VjX2luaXRfaHcoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4g PiAtCj4gPiAgLyoqCj4gPiAgICogaW50ZWxfZ3VjX2ZldGNoX2Z3KCkgLSBkZXRlcm1pbmUgYW5k IGZldGNoIGZpcm13YXJlCj4gPiAgICogQGd1YzoJaW50ZWxfZ3VjIHN0cnVjdAo+ID4gQEAgLTQ4 NywzOSArNDgyLDMxIEBAIGludCBpbnRlbF9ndWNfaW5pdF9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gPiAgdm9pZCBpbnRlbF9ndWNfZmV0Y2hfZncoc3RydWN0IGludGVs X2d1YyAqZ3VjKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPiA+IC0JY29uc3QgY2hhciAqZndfcGF0aDsKPiA+ICAKPiA+ IC0JaWYgKCFIQVNfR1VDX1VDT0RFKGRldl9wcml2KSkgewo+ID4gLQkJZndfcGF0aCA9IE5VTEw7 Cj4gPiAtCX0gZWxzZSBpZiAoSVNfU0tZTEFLRShkZXZfcHJpdikpIHsKPiA+IC0JCWZ3X3BhdGgg PSBJOTE1X1NLTF9HVUNfVUNPREU7Cj4gPiArCWd1Yy0+ZncucGF0aCA9IE5VTEw7Cj4gPiArCWd1 Yy0+ZncuZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfTk9ORTsKPiA+ICsJZ3VjLT5m dy5sb2FkX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX05PTkU7Cj4gPiArCWd1Yy0+ZncuZncg PSBJTlRFTF9VQ19GV19UWVBFX0dVQzsKPiAKPiBNYXliZSBmb3IgYWJvdmUgY29kZSB3ZSBjYW4g YWRkIG5ldyBmdW5jdGlvbjoKPiAKPiAJdm9pZCBpbnRlbF91Y19md19pbml0X2Vhcmx5KHN0cnVj dCBpbnRlbF91Y19mdyAqZncsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbnVtIGlu dGVsX3VjX2Z3X3R5cGUgdHlwZSk7Cj4gCj4gYW5kIHVzZSBpdCBmb3IgYm90aCBndWMgYW5kIGh1 YzoKPiAJCj4gCWludGVsX3VjX2Z3X2luaXRfZWFybHkoJmd1Yy0+ZncsIElOVEVMX1VDX0ZXX1RZ UEVfR1VDKTsKPiAJaW50ZWxfdWNfZndfaW5pdF9lYXJseSgmaHVjLT5mdywgSU5URUxfVUNfRldf VFlQRV9IVUMpOwoKVGhhdCdzIHNvbWV0aGluZyBJIHdhbnQgdG8gZ2V0IHRvLCBidXQgdGhpcyBz ZXJyaWVzIGlzIGFscmVhZHkgZ2V0dGluZwpwcmV0dHkgc3dvbGxlbiBhbmQgdGhpcyB3b3VsZCBt ZWFuIHlldCBhbm90aGVyIHBhdGNoIGluIHRoZSBzZXJpZXMsIHlldAphbm90aGVyIHJvdW5kIG9m IHJldmlldwoKTGV0IHN0aWNrIG5vdCBvbmx5IHRvIGRpZ2VzdGlibGUgcGF0Y2hlcyBidXQgZGln ZXN0aWJsZSBzZXJpZXMgYXMgd2VsbC4KCj4gPiArCj4gPiArCWlmIChJU19TS1lMQUtFKGRldl9w cml2KSkgewo+ID4gKwkJZ3VjLT5mdy5wYXRoID0gSTkxNV9TS0xfR1VDX1VDT0RFOwo+ID4gIAkJ Z3VjLT5mdy5tYWpvcl92ZXJfd2FudGVkID0gU0tMX0ZXX01BSk9SOwo+ID4gIAkJZ3VjLT5mdy5t aW5vcl92ZXJfd2FudGVkID0gU0tMX0ZXX01JTk9SOwo+ID4gIAl9IGVsc2UgaWYgKElTX0JST1hU T04oZGV2X3ByaXYpKSB7Cj4gPiAtCQlmd19wYXRoID0gSTkxNV9CWFRfR1VDX1VDT0RFOwo+ID4g KwkJZ3VjLT5mdy5wYXRoID0gSTkxNV9CWFRfR1VDX1VDT0RFOwo+ID4gIAkJZ3VjLT5mdy5tYWpv cl92ZXJfd2FudGVkID0gQlhUX0ZXX01BSk9SOwo+ID4gIAkJZ3VjLT5mdy5taW5vcl92ZXJfd2Fu dGVkID0gQlhUX0ZXX01JTk9SOwo+ID4gIAl9IGVsc2UgaWYgKElTX0tBQllMQUtFKGRldl9wcml2 KSkgewo+ID4gLQkJZndfcGF0aCA9IEk5MTVfS0JMX0dVQ19VQ09ERTsKPiA+ICsJCWd1Yy0+Zncu cGF0aCA9IEk5MTVfS0JMX0dVQ19VQ09ERTsKPiA+ICAJCWd1Yy0+ZncubWFqb3JfdmVyX3dhbnRl ZCA9IEtCTF9GV19NQUpPUjsKPiA+ICAJCWd1Yy0+ZncubWlub3JfdmVyX3dhbnRlZCA9IEtCTF9G V19NSU5PUjsKPiA+ICAJfSBlbHNlIHsKPiA+IC0JCWZ3X3BhdGggPSAiIjsJLyogdW5rbm93biBk ZXZpY2UgKi8KPiA+ICsJCVdBUk4oMSwgIk5vIEd1QyBmaXJtd2FyZSBrbm93biBmb3IgcGxhdGZv cm0gd2l0aCBHdUMhXG4iKTsKPiAKPiBNYXliZSBzaW1wbGVyIERSTV9FUlJPUiB3aWxsIGJlIHN1 ZmZpY2llbnQ/IFdlIGRvbid0IG5lZWQgY2FsbHN0YWNrLgoKSSBqdXN0IHN0dWNrIHRvIHdoYXQg d2FzIGFscmVhZHkgdXNlZCwgYnV0IERSTV9FUlJPUiBzaG91bGQgYmUKc3VmZmljaWVudC4KCj4g PiArCQlpOTE1LmVuYWJsZV9ndWNfbG9hZGluZyA9IDA7Cj4gCj4gV2hhdCBhYm91dCBtYWtpbmcg dGhpcyBmaXJtd2FyZSBwYXRoIGd1ZXNzIHdvcmsgcGFydCBvZiB0aGUgZWFybHkgaW5pdCBvcgo+ IHNhbml0aXplIG9wdGlvbnMgZnVuY3Rpb24/IE5vdGUgdGhhdCBhY3R1YWwgZmV0Y2ggaXMgYWxy ZWFkeSBkb25lIGJ5IGluIAo+IGRpZmZlcmVudCBmdW5jdGlvbiwgc28gbW9zdGx5IHdlIGp1c3Qg bmVlZCB0byBwaWNrIG5pY2UgbmFtZSBmb3IgdGhlCj4gbmV3IGZ1bmN0aW9uLiBNYXliZQo+IAo+ IAlpbnQgaW50ZWxfZ3VjX2luaXRfZncoKSA/Cj4gCj4gTm90ZSB0aGF0IGNoYW5naW5nIGk5MTUu ZW5hYmxlX2d1YyBwYXJhbSBoZXJlIGhhcyBpbXBsaWNhdGlvbiBvbiBvdGhlcgo+IGFjdGlvbnMg KGxpa2UgSHVjIGxvYWRpbmcpIGFuZCB0aHVzIGZvcmNpbmcgcmVkdW5kYW50IGNoZWNrcyBlbHNl d2hlcmUKClNhbWUgcG9pbnQgYXMgd2l0aCBpbnRlbF91Y19md19pbml0X2Vhcmx5LiBPbiBteSBU T0RPIGZvciB2b2wuIDIuCgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3VjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gPiBpbmRleCAyYmI0 OWI3Li42ZjJkM2Y2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf dWMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ID4gQEAgLTI2 Nyw4ICsyNjcsOSBAQCBzdGF0aWMgdm9pZCB1Y19mZXRjaF9mdyhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gPiAgCXNpemVfdCBzaXplOwo+ID4gIAlpbnQgZXJyOwo+ID4gIAo+ ID4gLQlEUk1fREVCVUdfRFJJVkVSKCJiZWZvcmUgcmVxdWVzdGluZyBmaXJtd2FyZTogdUMgZncg ZmV0Y2ggc3RhdHVzICVzXG4iLAo+ID4gLQkJaW50ZWxfdWNfZndfc3RhdHVzX3JlcHIodWNfZnct PmZldGNoX3N0YXR1cykpOwo+ID4gKwl1Y19mdy0+ZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklS TVdBUkVfUEVORElORzsKPiA+ICsKPiA+ICsJRFJNX0RFQlVHX0RSSVZFUigidUMgZmlybXdhcmUg cGVuZGluZywgcGF0aCAlc1xuIiwgdWNfZnctPnBhdGgpOwo+IAo+IElmIHlvdSBhcmUgbm90IHBs YW5uaW5nIHRvIHJlbW92ZSAiaW50ZWxfdWNfZndfc3RhdHVzX3JlcHIoKSIgdGhlbiBwbGVhc2Ug aXQuCgpXaGF0PwoKLS0gCkNoZWVycywKQXJlawpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK