From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/i915/glk: Fix Geminilake scalers mode programming Date: Wed, 22 Feb 2017 16:53:40 +0200 Message-ID: <20170222145340.GH31595@intel.com> References: <20170222102909.18072-1-ander.conselvan.de.oliveira@intel.com> <20170222102909.18072-4-ander.conselvan.de.oliveira@intel.com> <20170222144118.GG31595@intel.com> <1487774650.8356.6.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE4E96E311 for ; Wed, 22 Feb 2017 14:53:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1487774650.8356.6.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan De Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBGZWIgMjIsIDIwMTcgYXQgMDQ6NDQ6MTBQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IERlIE9saXZlaXJhIHdyb3RlOgo+IE9uIFdlZCwgMjAxNy0wMi0yMiBhdCAxNjo0MSArMDIwMCwg VmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ID4gT24gV2VkLCBGZWIgMjIsIDIwMTcgYXQgMTI6Mjk6 MDlQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIHdyb3RlOgo+ID4gPiBHZW1p bmlsYWtlIHNjYWxlcnMgY2FuIGRvIDd4NyBmaWx0ZXJpbmcgZm9yIGFsbCBzdXBwb3J0ZWQgaW5w dXQgc2l6ZXMsCj4gPiA+IHNvIGl0IGRvZXNuJ3QgbmVlZCB0aGUgImhpZ2ggcXVhbGl0eSIgbW9k ZSBwcm9ncmFtbWluZywgd2hpY2ggd2FzCj4gPiA+IGFjdHVhbGx5IHJlbW92ZWQgZnJvbSB0aGF0 IHBsYXRmb3JtLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogQW5kZXIgQ29uc2VsdmFuIGRl IE9saXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPgo+ID4gPiAt LS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jICB8IDE0ICsrKysr KysrLS0tLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAg MiArLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDYgKysr LS0tCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9u cygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2F0b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMKPiA+ID4gaW5k ZXggYWE5MTYwZS4uZTY1ODE4ZSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfYXRvbWljLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXRvbWljLmMKPiA+ID4gQEAgLTEyMSw3ICsxMjEsNyBAQCBpbnRlbF9jcnRjX2Rlc3Ryb3lfc3Rh dGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gPiAgCj4gPiA+ICAvKioKPiA+ID4gICAqIGlu dGVsX2F0b21pY19zZXR1cF9zY2FsZXJzKCkgLSBzZXR1cCBzY2FsZXJzIGZvciBjcnRjIHBlciBz dGFnZWQgcmVxdWVzdHMKPiA+ID4gLSAqIEBkZXY6IERSTSBkZXZpY2UKPiA+ID4gKyAqIEBkZXZf cHJpdjogaTkxNSBkZXZpY2UKPiA+IAo+ID4gVGhpcyBjaGFuZ2UgbWFrZXMgdGhlIGRpZmYgcXVp dGUgbWVzc3kgZm9yIHdoYXQncyBlc3NlbnRpYWxseSBhCj4gPiBhZGRpdGlvbiBvZiB0d28gbGlu ZXMgb2YgY29kZS4KPiAKPiBUaGVyZSdzIG5vIGRldl9wcml2IGluIHRoYXQgZnVuY3Rpb24uIFdo aWxlIGFkZGluZyB0aGUgZGV2X3ByaXYsIGl0IGp1c3Qgc2VlbWVkCj4gbGlrZSBwdXJlIGxhemlu ZXNzIG5vdCB0byBjaGFuZ2UgdGhlIHBhcmFtZXRlci4gRGlkbid0IHNlZW0gbGlrZSBhIGJpZyBk ZWFsCj4gc2luY2UgaXQgaGFzIG9ubHkgb25lIGNhbGxlciwgYnV0IEknbGwgc3BsaXQgaWYgeW91 IGluc2lzdC4KCnRvX2k5MTUoZGV2KSBzdGlsbCB3b3Jrcywgc28gdGhlcmUncyBubyByZWFsIG5l ZWQgZm9yIGNoYW5naW5nIHRoZQpwYXJhbWV0ZXIgYXQgdGhpcyB0aW1lLiBJIHRoaW5rIHNuZWFr aW5nIGluIGNvc21ldGljIGNoYW5nZXMgc2hvdWxkIG9ubHkKYmUgZG9uZSBpZiBpdCdzIHJlYWxs eSBqdXN0IGEgZmV3IGxpbmVzLCB3aGVyZWFzIGluIHRoaXMgY2FzZSB0aGUKY29zbWV0aWMgY2hh bmdlIG1ha2VzIHVwIG1vc3Qgb2YgdGhlIHBhdGNoIGxlYWRpbmcgdG8gYSB2ZXJ5IGxvdwpzaWdu YWwgdG8gbm9pc2UgcmF0aW8uCgo+IAo+IEFuZGVyCj4gCj4gPiAKPiA+ID4gICAqIEBjcnRjOiBp bnRlbCBjcnRjCj4gPiA+ICAgKiBAY3J0Y19zdGF0ZTogaW5jb21pbmcgY3J0Y19zdGF0ZSB0byB2 YWxpZGF0ZSBhbmQgc2V0dXAgc2NhbGVycwo+ID4gPiAgICoKPiA+ID4gQEAgLTEzNiw5ICsxMzYs OSBAQCBpbnRlbF9jcnRjX2Rlc3Ryb3lfc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4g PiAgICogICAgICAgICAwIC0gc2NhbGVycyB3ZXJlIHNldHVwIHN1Y2Nlc2Z1bGx5Cj4gPiA+ICAg KiAgICAgICAgIGVycm9yIGNvZGUgLSBvdGhlcndpc2UKPiA+ID4gICAqLwo+ID4gPiAtaW50IGlu dGVsX2F0b21pY19zZXR1cF9zY2FsZXJzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiA+IC0J c3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gPiA+IC0Jc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4gPiA+ICtpbnQgaW50ZWxfYXRvbWljX3NldHVwX3NjYWxlcnMo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiArCQkJICAgICAgIHN0cnVj dCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ID4gPiArCQkJICAgICAgIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ID4gPiAgewo+ID4gPiAgCXN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lID0gTlVMTDsKPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUgKmludGVsX3BsYW5lOwo+ ID4gPiBAQCAtMTk5LDcgKzE5OSw3IEBAIGludCBpbnRlbF9hdG9taWNfc2V0dXBfc2NhbGVycyhz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gPiAgCQkJICovCj4gPiA+ICAJCQlpZiAoIXBsYW5l KSB7Cj4gPiA+ICAJCQkJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGU7Cj4gPiA+IC0JCQkJ cGxhbmUgPSBkcm1fcGxhbmVfZnJvbV9pbmRleChkZXYsIGkpOwo+ID4gPiArCQkJCXBsYW5lID0g ZHJtX3BsYW5lX2Zyb21faW5kZXgoJmRldl9wcml2LT5kcm0sIGkpOwo+ID4gPiAgCQkJCXN0YXRl ID0gZHJtX2F0b21pY19nZXRfcGxhbmVfc3RhdGUoZHJtX3N0YXRlLCBwbGFuZSk7Cj4gPiA+ICAJ CQkJaWYgKElTX0VSUihzdGF0ZSkpIHsKPiA+ID4gIAkJCQkJRFJNX0RFQlVHX0tNUygiRmFpbGVk IHRvIGFkZCBbUExBTkU6JWRdIHRvIGRybV9zdGF0ZVxuIiwKPiA+ID4gQEAgLTI0Nyw3ICsyNDcs OSBAQCBpbnQgaW50ZWxfYXRvbWljX3NldHVwX3NjYWxlcnMoc3RydWN0IGRybV9kZXZpY2UgKmRl diwKPiA+ID4gIAkJfQo+ID4gPiAgCj4gPiA+ICAJCS8qIHNldCBzY2FsZXIgbW9kZSAqLwo+ID4g PiAtCQlpZiAobnVtX3NjYWxlcnNfbmVlZCA9PSAxICYmIGludGVsX2NydGMtPnBpcGUgIT0gUElQ RV9DKSB7Cj4gPiA+ICsJCWlmIChJU19HRU1JTklMQUtFKGRldl9wcml2KSkgewo+ID4gPiArCQkJ c2NhbGVyX3N0YXRlLT5zY2FsZXJzWypzY2FsZXJfaWRdLm1vZGUgPSAwOwo+ID4gPiArCQl9IGVs c2UgaWYgKG51bV9zY2FsZXJzX25lZWQgPT0gMSAmJiBpbnRlbF9jcnRjLT5waXBlICE9IFBJUEVf Qykgewo+ID4gPiAgCQkJLyoKPiA+ID4gIAkJCSAqIHdoZW4gb25seSAxIHNjYWxlciBpcyBpbiB1 c2Ugb24gZWl0aGVyIHBpcGUgQSBvciBCLAo+ID4gPiAgCQkJICogc2NhbGVyIDAgb3BlcmF0ZXMg aW4gaGlnaCBxdWFsaXR5IChIUSkgbW9kZS4KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYwo+ID4gPiBpbmRleCAwMDBmYjMxLi42NWU3NmQxIDEwMDY0NAo+ID4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+IEBAIC0xMDk1OSw3ICsxMDk1OSw3IEBA IHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19hdG9taWNfY2hlY2soc3RydWN0IGRybV9jcnRjICpjcnRj LAo+ID4gPiAgCQkJcmV0ID0gc2tsX3VwZGF0ZV9zY2FsZXJfY3J0YyhwaXBlX2NvbmZpZyk7Cj4g PiA+ICAKPiA+ID4gIAkJaWYgKCFyZXQpCj4gPiA+IC0JCQlyZXQgPSBpbnRlbF9hdG9taWNfc2V0 dXBfc2NhbGVycyhkZXYsIGludGVsX2NydGMsCj4gPiA+ICsJCQlyZXQgPSBpbnRlbF9hdG9taWNf c2V0dXBfc2NhbGVycyhkZXZfcHJpdiwgaW50ZWxfY3J0YywKPiA+ID4gIAkJCQkJCQkgcGlwZV9j b25maWcpOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ ID4gPiBpbmRleCAwZWRjNDk5Li5kOWQ5NmQ2IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+ID4gPiBAQCAtMTkxMCw5ICsxOTEwLDkgQEAgaW50ZWxfYXRvbWljX2dldF9l eGlzdGluZ19wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gPiA+ ICAJcmV0dXJuIHRvX2ludGVsX3BsYW5lX3N0YXRlKHBsYW5lX3N0YXRlKTsKPiA+ID4gIH0KPiA+ ID4gIAo+ID4gPiAtaW50IGludGVsX2F0b21pY19zZXR1cF9zY2FsZXJzKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4gPiA+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gPiA+IC0J c3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ID4gPiAraW50IGludGVsX2F0 b21pY19zZXR1cF9zY2FsZXJzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ ID4gKwkJCSAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywKPiA+ID4gKwkJCSAg ICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gPiA+ICAKPiA+ID4g IC8qIGludGVsX2F0b21pY19wbGFuZS5jICovCj4gPiA+ICBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3Rh dGUgKmludGVsX2NyZWF0ZV9wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSk7Cj4g PiA+IC0tIAo+ID4gPiAyLjkuMwo+ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4g PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPiAKPiA+IAoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==