From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arkadiusz Hiler Subject: Re: [PATCH 8/8] drm/i915/uc: Simplify firmware path handling Date: Wed, 22 Feb 2017 16:52:11 +0100 Message-ID: <20170222155211.GC11729@ahiler-desk.igk.intel.com> References: <20170222124125.4437-1-arkadiusz.hiler@intel.com> <20170222124125.4437-9-arkadiusz.hiler@intel.com> <20170222125347.GS10557@nuc-i3427.alporthouse.com> <20170222153049.GB11729@ahiler-desk.igk.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5FF76E05C for ; Wed, 22 Feb 2017 15:52:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170222153049.GB11729@ahiler-desk.igk.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBGZWIgMjIsIDIwMTcgYXQgMDQ6MzA6NDlQTSArMDEwMCwgQXJrYWRpdXN6IEhpbGVy IHdyb3RlOgo+IE9uIFdlZCwgRmViIDIyLCAyMDE3IGF0IDEyOjUzOjQ3UE0gKzAwMDAsIENocmlz IFdpbHNvbiB3cm90ZToKPiA+IE9uIFdlZCwgRmViIDIyLCAyMDE3IGF0IDAxOjQxOjI1UE0gKzAx MDAsIEFya2FkaXVzeiBIaWxlciB3cm90ZToKPiA+ID4gQ3VycmVudGx5IGZ3LT5wYXRoIHZhbHVl cyBjYW4gcmVwcmVzZW50IG9uZSBvZiB0aHJlZSBwb3NzaWJsZSBzdGF0ZXM6Cj4gPiA+IAo+ID4g PiAgMSkgTlVMTCAtIGRldmljZSB3aXRob3V0IHRoZSB1Qwo+ID4gPiAgMikgJ1wwJyAtIGRldmlj ZSB3aXRoIHRoZSB1QyBidXQgaGF2ZSBubyBmaXJtd2FyZQo+ID4gPiAgMykgZWxzZSAtIGRldmlj ZSB3aXRoIHRoZSB1QyBhbmQgd2UgaGF2ZSBmaXJtd2FyZQo+ID4gPiAKPiA+ID4gU2Vjb25kIGNh c2UgaXMgdXNlZCBvbmx5IHRvIFdBUk4gYXQgYSBsYXRlciBzdGFnZS4KPiA+ID4gCj4gPiA+IFdl IGNhbiBXQVJOIHJpZ2h0IGF3YXkgYW5kIG1lcmdlIGNhc2VzIDEgYW5kIDIuCj4gPiA+IAo+ID4g PiBDb2RlIGNhbiBiZSBldmVuIGZ1cnRoZXIgc2ltcGxpZmllZCBhbmQgY29tbW9uIChIdUMvR3VD IGxvZ2ljKSBoYXBwZW5pbmcKPiA+ID4gcmlnaHQgYmVmb3JlIHRoZSBmZXRjaCBjYW4gYmUgb2Zm bG9hZGVkIHRvIHRoZSBjb21tb24gZnVuY3Rpb24uCj4gPiA+IAo+ID4gPiB2MjogZmV3ZXIgdGVt cG9yYXJ5IHZhcmlhYmxlcywgbW9yZSBzdHJhaWdodGZvcndhcmQgZmxvdyAoTS4gV2FqZGVjemtv KQo+ID4gPiB2MzogRFJNX0VSUk9SIGluc3RlYWQgb2YgV0FSTiAoTS4gV2FqZGVjemtvKQo+ID4g PiAKPiA+ID4gQ2M6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNhQGludGVsLmNvbT4K PiA+ID4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gPiA+ IENjOiBNaWNoYWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPiA+ID4g Q2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+ID4gPiBT aWduZWQtb2ZmLWJ5OiBBcmthZGl1c3ogSGlsZXIgPGFya2FkaXVzei5oaWxlckBpbnRlbC5jb20+ Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5j IHwgMzkgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9odWMuYyAgICAgICAgfCAyMCArKysrKy0tLS0tLS0tLS0tLQo+ID4g PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgICAgICAgIHwgIDUgKysrLS0KPiA+ ID4gIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNDIgZGVsZXRpb25zKC0pCj4g PiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xv YWRlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gPiA+IGlu ZGV4IDU0OWEyNTQuLjMzNmU5N2QgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9ndWNfbG9hZGVyLmMKPiA+ID4gQEAgLTQzMywxMiArNDMzLDggQEAgaW50IGludGVsX2d1 Y19pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ID4gIAkJaW50 ZWxfdWNfZndfc3RhdHVzX3JlcHIoZ3VjX2Z3LT5sb2FkX3N0YXR1cykpOwo+ID4gPiAgCj4gPiA+ ICAJaWYgKGZ3X3BhdGggPT0gTlVMTCkgewo+ID4gPiAtCQkvKiBEZXZpY2UgaXMga25vd24gdG8g aGF2ZSBubyB1Q29kZSAoZS5nLiBubyBHdUMpICovCj4gPiA+ICsJCS8qIFdlIGRvIG5vdCBoYXZl IHVDb2RlIGZvciB0aGUgZGV2aWNlICovCj4gPiA+ICAJCXJldHVybiAtRU5YSU87Cj4gPiA+IC0J fSBlbHNlIGlmICgqZndfcGF0aCA9PSAnXDAnKSB7Cj4gPiA+IC0JCS8qIERldmljZSBoYXMgYSBH dUMgYnV0IHdlIGRvbid0IGtub3cgd2hhdCBmL3cgdG8gbG9hZD8gKi8KPiA+ID4gLQkJV0FSTigx LCAiTm8gR3VDIGZpcm13YXJlIGtub3duIGZvciB0aGlzIHBsYXRmb3JtIVxuIik7Cj4gPiA+IC0J CXJldHVybiAtRU5PREVWOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAgCS8qIEZldGNoIGZhaWxl ZCwgb3IgYWxyZWFkeSBmZXRjaGVkIGJ1dCBmYWlsZWQgdG8gbG9hZD8gKi8KPiA+ID4gQEAgLTQ3 NCw3ICs0NzAsNiBAQCBpbnQgaW50ZWxfZ3VjX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ID4gPiAgCXJldHVybiAwOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+IC0K PiA+ID4gIC8qKgo+ID4gPiAgICogaW50ZWxfZ3VjX2ZldGNoX2Z3KCkgLSBkZXRlcm1pbmUgYW5k IGZldGNoIGZpcm13YXJlCj4gPiA+ICAgKiBAZ3VjOglpbnRlbF9ndWMgc3RydWN0Cj4gPiA+IEBA IC00ODcsMzkgKzQ4MiwzMSBAQCBpbnQgaW50ZWxfZ3VjX2luaXRfaHcoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiAgdm9pZCBpbnRlbF9ndWNfZmV0Y2hfZncoc3RydWN0 IGludGVsX2d1YyAqZ3VjKQo+ID4gPiAgewo+ID4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4gPiA+IC0JY29uc3QgY2hhciAqZndfcGF0 aDsKPiA+ID4gIAo+ID4gPiAtCWlmICghSEFTX0dVQ19VQ09ERShkZXZfcHJpdikpIHsKPiA+ID4g LQkJZndfcGF0aCA9IE5VTEw7Cj4gPiA+IC0JfSBlbHNlIGlmIChJU19TS1lMQUtFKGRldl9wcml2 KSkgewo+ID4gPiAtCQlmd19wYXRoID0gSTkxNV9TS0xfR1VDX1VDT0RFOwo+ID4gPiArCWd1Yy0+ ZncucGF0aCA9IE5VTEw7Cj4gPiA+ICsJZ3VjLT5mdy5mZXRjaF9zdGF0dXMgPSBJTlRFTF9VQ19G SVJNV0FSRV9OT05FOwo+ID4gPiArCWd1Yy0+ZncubG9hZF9zdGF0dXMgPSBJTlRFTF9VQ19GSVJN V0FSRV9OT05FOwo+ID4gPiArCWd1Yy0+ZncuZncgPSBJTlRFTF9VQ19GV19UWVBFX0dVQzsKPiA+ ID4gKwo+ID4gPiArCWlmIChJU19TS1lMQUtFKGRldl9wcml2KSkgewo+ID4gPiArCQlndWMtPmZ3 LnBhdGggPSBJOTE1X1NLTF9HVUNfVUNPREU7Cj4gPiA+ICAJCWd1Yy0+ZncubWFqb3JfdmVyX3dh bnRlZCA9IFNLTF9GV19NQUpPUjsKPiA+ID4gIAkJZ3VjLT5mdy5taW5vcl92ZXJfd2FudGVkID0g U0tMX0ZXX01JTk9SOwo+ID4gPiAgCX0gZWxzZSBpZiAoSVNfQlJPWFRPTihkZXZfcHJpdikpIHsK PiA+ID4gLQkJZndfcGF0aCA9IEk5MTVfQlhUX0dVQ19VQ09ERTsKPiA+ID4gKwkJZ3VjLT5mdy5w YXRoID0gSTkxNV9CWFRfR1VDX1VDT0RFOwo+ID4gPiAgCQlndWMtPmZ3Lm1ham9yX3Zlcl93YW50 ZWQgPSBCWFRfRldfTUFKT1I7Cj4gPiA+ICAJCWd1Yy0+ZncubWlub3JfdmVyX3dhbnRlZCA9IEJY VF9GV19NSU5PUjsKPiA+ID4gIAl9IGVsc2UgaWYgKElTX0tBQllMQUtFKGRldl9wcml2KSkgewo+ ID4gPiAtCQlmd19wYXRoID0gSTkxNV9LQkxfR1VDX1VDT0RFOwo+ID4gPiArCQlndWMtPmZ3LnBh dGggPSBJOTE1X0tCTF9HVUNfVUNPREU7Cj4gPiA+ICAJCWd1Yy0+ZncubWFqb3JfdmVyX3dhbnRl ZCA9IEtCTF9GV19NQUpPUjsKPiA+ID4gIAkJZ3VjLT5mdy5taW5vcl92ZXJfd2FudGVkID0gS0JM X0ZXX01JTk9SOwo+ID4gPiAgCX0gZWxzZSB7Cj4gPiA+IC0JCWZ3X3BhdGggPSAiIjsJLyogdW5r bm93biBkZXZpY2UgKi8KPiA+ID4gKwkJRFJNX0VSUk9SKCJObyBHdUMgZmlybXdhcmUga25vd24g Zm9yIHBsYXRmb3JtIHdpdGggR3VDIVxuIik7Cj4gPiA+ICsJCWk5MTUuZW5hYmxlX2d1Y19sb2Fk aW5nID0gMDsKPiA+ID4gKwkJcmV0dXJuOwo+ID4gCj4gPiBOb3cgcGxhbiBmb3IgaGF2aW5nIGZ3 X3BhdGggb3ZlcnJpZGVuIGJ5IGEgaTkxNV9wYXJhbS5ndWNfZmlybXdhcmUuCj4gPiAKPiA+IFBl cmhhcHMgc29tZXRoaW5nIGxpa2UKPiA+IAlpZiAoaTkxNV9wYXJhbS5ndWNfZmlybXdhcmUpIHsK PiA+IAkJZ3VjLT5mdy5wYXRoID0gaTkxNV9wYXJhbS5ndWNfZmlybXdhcmU7IC8qIG5lZWRzIDA0 MDAhICovCj4gPiAJCWd1Yy0+ZncubWFqb3JfdmVyX3dhbnRlZCA9IC0xOwo+ID4gCQlndWMtPmZ3 Lm1pbm9yX3Zlcl93YW50ZWQgPSAtMTsKPiA+IAl9IGVsc2UgaWYgKElTX1NLWUxBS0UuLi4uCj4g PiB3b3Jrcz8KPiAKPiBTb3JyeSwgSSBkbyBub3QgcXVpdGUgdW5kZXJzdGFuZCB0aGUgY29tbWVu dC4gQ2FuIHlvdSBlbGFib3JhdGU/CgpOZXZlcm1pbmQsIGdvdCBpdC4KCkxHVE0sIGJ1dCBmb3Ig aXQgdG8gZnVsbHkgd29yayB3ZSBuZWVkIHRvIG1ha2UgdWNfZmV0Y2hfZncgKG9yIGhvd2V2ZXIK aXQgd2lsbCBlbmQgdXAgYmVpbmcgbmFtZWQpIGF3YXJlIHRoYXQgLTEgaGF2ZSBzcGVjaWFsIG1l YW5pbmcuCgpOb3cgdGhlIHZlcnNpb24gY3Jvc3MtY2hlY2sgbG9va3MgbGlrZSB0aGF0OgoKaWYg KHVjX2Z3LT5tYWpvcl92ZXJfZm91bmQgIT0gdWNfZnctPm1ham9yX3Zlcl93YW50ZWQgfHwKICAg IHVjX2Z3LT5taW5vcl92ZXJfZm91bmQgPCB1Y19mdy0+bWlub3JfdmVyX3dhbnRlZCkgewoKCi0t IApDaGVlcnMsCkFyZWsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==