From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH 2/3] drm: Convert drm_framebuffer_remove to atomic, v4. Date: Thu, 23 Feb 2017 10:09:27 -0500 Message-ID: <20170223150927.GB17822@art_vandelay> References: <1487685102-31991-1-git-send-email-maarten.lankhorst@linux.intel.com> <1487685102-31991-3-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1487685102-31991-3-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMjEsIDIwMTcgYXQgMDI6NTE6NDFQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gSW5zdGVhZCBvZiB0cnlpbmcgdG8gZG8gZXZlcnl0aGluZyBpbiAxIGdvLCBq dXN0IGRvIGEgYmFzaWMgc2FmZQo+IGNvbnZlcnNpb24gZmlyc3QuIFdlJ3ZlIGJlZW4gYml0dGVu IGJ5IHRvbyBtYW55IHJlZ3Jlc3Npb25zIGluIHRoZQo+IHBhc3QuCj4gCj4gVGhpcyBwYXRjaCBv bmx5IGNvbnZlcnRzIGRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUgdG8gYXRvbWljLiBUaGUKPiByZWdy ZXNzaW9uIHNlbnNpdGl2ZSBwYXJ0IGlzIHNwbGl0IG91dCB0byBhIHNlcGFyYXRlIHBhdGNoLgo+ IAo+IHYyOgo+IC0gUmVtb3ZlIHBsYW5lLT5mYiBhc3NpZ25tZW50LCBkb25lIGJ5IGRybV9hdG9t aWNfY2xlYW5fb2xkX2ZiLgo+IC0gQWRkIFdBUk5fT04gd2hlbiBhdG9taWNfcmVtb3ZlX2ZiIGZh aWxzLgo+IC0gQWx3YXlzIGNhbGwgZHJtX2F0b21pY19zdGF0ZV9wdXQuCj4gdjM6Cj4gLSBVc2Ug ZHJtX2Rydl91c2VzX2F0b21pY19tb2Rlc2V0Cj4gLSBIYW5kbGUgdGhlIGNhc2Ugd2hlcmUgdGhl IGZpcnN0IHBsYW5lLWRpc2FibGUtb25seSBjb21taXQgZmFpbHMKPiAgIHdpdGggLUVJTlZBTC4g U29tZSBkcml2ZXJzIGRvIG5vdCBzdXBwb3J0IHRoaXMsIGZhbGwgYmFjayB0bwo+ICAgZGlzYWJs aW5nIGFsbCBjcnRjJ3MgaW4gdGhpcyBjYXNlLgo+IHY0Ogo+IC0gU29sdmUgdm13Z2Z4IGNvbXBh dGliaWxpdHkgaXNzdWUgaW4gdGhlaXIgZHJpdmVyLCB3YXMgZml4ZWQgaW4gdGhpcwo+ICAgcGF0 Y2ggYnkgdjMuCj4gLSBNb3ZlIG9ubHkgZGlzYWJsaW5nIHByaW1hcnkgdG8gYSBzZXBhcmF0ZSBw YXRjaC4KPiAKClJldmlld2VkLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4K Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGlu dXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jICAgICAg ICB8IDg4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9n cHUvZHJtL2RybV9jcnRjX2ludGVybmFsLmggfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f ZnJhbWVidWZmZXIuYyAgIHwgIDcgKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgOTYgaW5zZXJ0aW9u cygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IGFmZWM1MzgzMjE0NS4uMjg1ZTFjMjNl OGM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTIwNjEsNiArMjA2MSw5NCBAQCBzdGF0 aWMgdm9pZCBjb21wbGV0ZV9jcnRjX3NpZ25hbGluZyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICAJa2ZyZWUoZmVuY2Vfc3RhdGUpOwo+ICB9Cj4gIAo+ICtpbnQgZHJtX2F0b21pY19yZW1vdmVf ZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gK3sKPiArCXN0cnVjdCBkcm1fbW9kZXNl dF9hY3F1aXJlX2N0eCBjdHg7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZmItPmRldjsK PiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiArCXN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lOwo+ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm47Cj4gKwlzdHJ1Y3QgZHJtX2Nv bm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPiArCWludCBpLCByZXQgPSAwOwo+ICsJdW5zaWdu ZWQgcGxhbmVfbWFzazsKPiArCj4gKwlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2 KTsKPiArCWlmICghc3RhdGUpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICsJZHJtX21vZGVz ZXRfYWNxdWlyZV9pbml0KCZjdHgsIDApOwo+ICsJc3RhdGUtPmFjcXVpcmVfY3R4ID0gJmN0eDsK PiArCj4gK3JldHJ5Ogo+ICsJcGxhbmVfbWFzayA9IDA7Cj4gKwlyZXQgPSBkcm1fbW9kZXNldF9s b2NrX2FsbF9jdHgoZGV2LCAmY3R4KTsKPiArCWlmIChyZXQpCj4gKwkJZ290byB1bmxvY2s7Cj4g Kwo+ICsJZHJtX2Zvcl9lYWNoX3BsYW5lKHBsYW5lLCBkZXYpIHsKPiArCQlzdHJ1Y3QgZHJtX3Bs YW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4gKwkJaWYgKHBsYW5lLT5zdGF0ZS0+ZmIgIT0g ZmIpCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiArCQlwbGFuZV9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0 X3BsYW5lX3N0YXRlKHN0YXRlLCBwbGFuZSk7Cj4gKwkJaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkp IHsKPiArCQkJcmV0ID0gUFRSX0VSUihwbGFuZV9zdGF0ZSk7Cj4gKwkJCWdvdG8gdW5sb2NrOwo+ ICsJCX0KPiArCj4gKwkJaWYgKHBsYW5lX3N0YXRlLT5jcnRjLT5wcmltYXJ5ID09IHBsYW5lKSB7 Cj4gKwkJCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCj4gKwkJCWNydGNf c3RhdGUgPSBkcm1fYXRvbWljX2dldF9leGlzdGluZ19jcnRjX3N0YXRlKHN0YXRlLCBwbGFuZV9z dGF0ZS0+Y3J0Yyk7Cj4gKwo+ICsJCQlyZXQgPSBkcm1fYXRvbWljX2FkZF9hZmZlY3RlZF9jb25u ZWN0b3JzKHN0YXRlLCBwbGFuZV9zdGF0ZS0+Y3J0Yyk7Cj4gKwkJCWlmIChyZXQpCj4gKwkJCQln b3RvIHVubG9jazsKPiArCj4gKwkJCWNydGNfc3RhdGUtPmFjdGl2ZSA9IGZhbHNlOwo+ICsJCQly ZXQgPSBkcm1fYXRvbWljX3NldF9tb2RlX2Zvcl9jcnRjKGNydGNfc3RhdGUsIE5VTEwpOwo+ICsJ CQlpZiAocmV0KQo+ICsJCQkJZ290byB1bmxvY2s7Cj4gKwkJfQo+ICsKPiArCQlkcm1fYXRvbWlj X3NldF9mYl9mb3JfcGxhbmUocGxhbmVfc3RhdGUsIE5VTEwpOwo+ICsJCXJldCA9IGRybV9hdG9t aWNfc2V0X2NydGNfZm9yX3BsYW5lKHBsYW5lX3N0YXRlLCBOVUxMKTsKPiArCQlpZiAocmV0KQo+ ICsJCQlnb3RvIHVubG9jazsKPiArCj4gKwkJcGxhbmVfbWFzayB8PSBCSVQoZHJtX3BsYW5lX2lu ZGV4KHBsYW5lKSk7Cj4gKwo+ICsJCXBsYW5lLT5vbGRfZmIgPSBwbGFuZS0+ZmI7Cj4gKwl9Cj4g Kwo+ICsJZm9yX2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uLCBjb25uX3N0YXRl LCBpKSB7Cj4gKwkJcmV0ID0gZHJtX2F0b21pY19zZXRfY3J0Y19mb3JfY29ubmVjdG9yKGNvbm5f c3RhdGUsIE5VTEwpOwo+ICsKPiArCQlpZiAocmV0KQo+ICsJCQlnb3RvIHVubG9jazsKPiArCX0K PiArCj4gKwlpZiAocGxhbmVfbWFzaykKPiArCQlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0 ZSk7Cj4gKwo+ICt1bmxvY2s6Cj4gKwlpZiAocGxhbmVfbWFzaykKPiArCQlkcm1fYXRvbWljX2Ns ZWFuX29sZF9mYihkZXYsIHBsYW5lX21hc2ssIHJldCk7Cj4gKwo+ICsJaWYgKHJldCA9PSAtRURF QURMSykgewo+ICsJCWRybV9tb2Rlc2V0X2JhY2tvZmYoJmN0eCk7Cj4gKwkJZ290byByZXRyeTsK PiArCX0KPiArCj4gKwlkcm1fYXRvbWljX3N0YXRlX3B1dChzdGF0ZSk7Cj4gKwo+ICsJZHJtX21v ZGVzZXRfZHJvcF9sb2NrcygmY3R4KTsKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4 KTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICBpbnQgZHJtX21vZGVfYXRvbWljX2lv Y3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCSAgdm9pZCAqZGF0YSwgc3RydWN0IGRy bV9maWxlICpmaWxlX3ByaXYpCj4gIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9jcnRjX2ludGVybmFsLmggYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaW50ZXJuYWwuaAo+ IGluZGV4IDk1NWM1NjkwYmY2NC4uZTA2NzhmOGE1MWNmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9j cnRjX2ludGVybmFsLmgKPiBAQCAtMTgzLDYgKzE4Myw3IEBAIGludCBkcm1fYXRvbWljX2dldF9w cm9wZXJ0eShzdHJ1Y3QgZHJtX21vZGVfb2JqZWN0ICpvYmosCj4gIAkJCSAgICBzdHJ1Y3QgZHJt X3Byb3BlcnR5ICpwcm9wZXJ0eSwgdWludDY0X3QgKnZhbCk7Cj4gIGludCBkcm1fbW9kZV9hdG9t aWNfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJICB2b2lkICpkYXRhLCBzdHJ1 Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdik7Cj4gK2ludCBkcm1fYXRvbWljX3JlbW92ZV9mYihzdHJ1 Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYik7Cj4gIAo+ICAKPiAgLyogZHJtX3BsYW5lLmMgKi8KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4gaW5kZXggMjhhMDEwOGExYWI4Li5jMGU1OTNhN2Y5 YjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4gQEAgLTc3Myw2ICs3NzMsMTIg QEAgdm9pZCBkcm1fZnJhbWVidWZmZXJfcmVtb3ZlKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZi KQo+ICAJICogaW4gdGhpcyBtYW5uZXIuCj4gIAkgKi8KPiAgCWlmIChkcm1fZnJhbWVidWZmZXJf cmVhZF9yZWZjb3VudChmYikgPiAxKSB7Cj4gKwkJaWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9k ZXNldChkZXYpKSB7Cj4gKwkJCWludCByZXQgPSBkcm1fYXRvbWljX3JlbW92ZV9mYihmYik7Cj4g KwkJCVdBUk4ocmV0LCAiYXRvbWljIHJlbW92ZV9mYiBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsK PiArCQkJZ290byBvdXQ7Cj4gKwkJfQo+ICsKPiAgCQlkcm1fbW9kZXNldF9sb2NrX2FsbChkZXYp Owo+ICAJCS8qIHJlbW92ZSBmcm9tIGFueSBDUlRDICovCj4gIAkJZHJtX2Zvcl9lYWNoX2NydGMo Y3J0YywgZGV2KSB7Cj4gQEAgLTc5MCw2ICs3OTYsNyBAQCB2b2lkIGRybV9mcmFtZWJ1ZmZlcl9y ZW1vdmUoc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gIAkJZHJtX21vZGVzZXRfdW5sb2Nr X2FsbChkZXYpOwo+ICAJfQo+ICAKPiArb3V0Ogo+ICAJZHJtX2ZyYW1lYnVmZmVyX3VucmVmZXJl bmNlKGZiKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUpOwo+ IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8g Q2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==