Re: [PATCH 1/9] drm: Add mode_config .get_format_info() hook

Daniel Vetter
2017-01-05T08:48:10Z

On Wed, Jan 04, 2017 at 07:15:34PM -0800, Ben Widawsky wrote:
> On 17-01-04 20:42:24, Ville Syrjälä wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Allow drivers to return a custom drm_format_info structure for special
> > fb layouts. We'll use this for the compression control surface in i915.
> >
> > v2: Fix drm_get_format_info() kernel doc (Laurent)
> > Don't pass 'dev' to the new hook (Laurent)
> >
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Ok if I still merge this throught drm-misc? Looks like the next few
patches don't need this yet, and the CCS stuff probably needs a bit more
wrangling for all the pieces to be fully ready.

> > + *
> > + * RETURNS:
> > + *
> > + * The format information specific to the given fb metadata, or
> > + * NULL if none is found.
> > + */
> > + const struct drm_format_info *(*get_format_info)(const struct drm_mode_fb_cmd2 *mode_cmd);
> > +
> > + /**
> > * @output_poll_changed:
> > *
> > * Callback used by helpers to inform the driver of output configuration
>
> Looks like msm and omap could use this too, and then if you allowed mode_cmd
> to be NULL, you could potentially deprecate drm_format_info. Just a thought.

Hm, what do you mean here with deprecating drm_format_info and a NULL
mode_cmd? I don't follow at all ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org