From: Manasi Navare <manasi.d.navare@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"
Date: Thu, 2 Mar 2017 02:29:38 -0800 [thread overview]
Message-ID: <20170302102937.GA17406@intel.com> (raw)
In-Reply-To: <20170301172753.GG4740@nuc-i3427.alporthouse.com>
On Wed, Mar 01, 2017 at 05:27:53PM +0000, Chris Wilson wrote:
> On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote:
> > This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c.
> >
> > I assumed it's ok, but really should have double-checked - CI caught
> > tons of fail :(
>
> For the record, the failure comes from the error message in
> intel_dp_get_link_train_fallback_values() as take the fallback path. As
> userspace is informed, we don't need an *ERROR* at that point.
>
Should this be just a DEBUG_KMS instead of DRM_ERROR each time it fails
link training since we are sending uevent to userspace for it to retry?
That will make CI happy, but I think we still need to fix the real problem
of eDP link failures on Port A for SKL.
Regards
Manasi
> The really interesting question is why we are seeing link-training
> failures in CI at all, and whether igt should be checking and reporting
> link-status=BAD.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-02 10:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 17:17 [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure" Daniel Vetter
2017-03-01 17:27 ` Chris Wilson
2017-03-01 17:35 ` Jani Nikula
2017-03-01 17:39 ` Jani Nikula
2017-03-01 17:56 ` Ville Syrjälä
2017-03-01 18:18 ` Jani Nikula
2017-03-01 18:32 ` Ville Syrjälä
2017-03-02 10:07 ` Imre Deak
2017-03-02 10:33 ` Imre Deak
2017-03-02 7:51 ` Daniel Vetter
2017-03-02 10:29 ` Manasi Navare [this message]
2017-03-02 8:17 ` Daniel Vetter
2017-03-14 16:57 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302102937.GA17406@intel.com \
--to=manasi.d.navare@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox