Re: [PATCH] Revert "drm/i915: Implement Link Rate fallback on Link training failure"

Chris Wilson
2017-03-01T17:28:08Z

On Wed, Mar 01, 2017 at 06:17:49PM +0100, Daniel Vetter wrote:
> This reverts commit 233ce881dd91fb13eb6b09deefae33168e6ead4c.
>
> I assumed it's ok, but really should have double-checked - CI caught
> tons of fail :(

For the record, the failure comes from the error message in
intel_dp_get_link_train_fallback_values() as take the fallback path. As
userspace is informed, we don't need an *ERROR* at that point.

The really interesting question is why we are seeing link-training
failures in CI at all, and whether igt should be checking and reporting
link-status=BAD.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre