From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [regression] Re: 4.11-rc0, thinkpad x220: GPU hang Date: Mon, 6 Mar 2017 13:10:48 +0100 Message-ID: <20170306121047.GB15063@amd> References: <20170228143453.GA11914@amd> <20170228150222.GU10304@nuc-i3427.alporthouse.com> <20170305230150.GA15063@amd> <20170306111528.GR5997@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0804328173==" Return-path: In-Reply-To: <20170306111528.GR5997@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , kernel list , daniel.vetter@intel.com, jani.nikula@linux.intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0804328173== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bCsyhTFzCvuiizWE" Content-Disposition: inline --bCsyhTFzCvuiizWE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2017-03-06 11:15:28, Chris Wilson wrote: > On Mon, Mar 06, 2017 at 12:01:51AM +0100, Pavel Machek wrote: > > Hi! > >=20 > > > > mplayer stopped working after a while. Dmesg says: > > > >=20 > > > > [ 3000.266533] cdc_ether 2-1.2:1.0 usb0: register 'cdc_ether' at > >=20 > > Now I'm pretty sure it is a regression in v4.11-rc0. Any ideas what to > > try? Bisect will be slow and nasty :-(. >=20 > I came the conclusion that #99671 is the ring HEAD overtaking the TAIL, > and under the presumption that your bug matches (as the symptoms do): >=20 > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i9= 15/intel_ringbuffer.c > index 4ffa35faff49..62e31a7438ac 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -782,10 +782,10 @@ static void i9xx_submit_request(struct drm_i915_gem= _request *request) > { > struct drm_i915_private *dev_priv =3D request->i915; > =20 > - i915_gem_request_submit(request); > - > GEM_BUG_ON(!IS_ALIGNED(request->tail, 8)); > I915_WRITE_TAIL(request->engine, request->tail); > + > + i915_gem_request_submit(request); > } > =20 > static void i9xx_emit_breadcrumb(struct drm_i915_gem_request *req, u32 *= cs) I applied it as: diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915= /intel_ringbuffer.c index 91bc4ab..9c49c7a 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -1338,9 +1338,9 @@ static void i9xx_submit_request(struct drm_i915_gem_r= equest *request) { struct drm_i915_private *dev_priv =3D request->i915; =20 - i915_gem_request_submit(request); - I915_WRITE_TAIL(request->engine, request->tail); + + i915_gem_request_submit(request); } =20 static void i9xx_emit_breadcrumb(struct drm_i915_gem_request *req, Hmm. But your next mail suggest that it may not be smart to try to boot it? :-). Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --bCsyhTFzCvuiizWE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAli9UccACgkQMOfwapXb+vKbzACfX57vWHhIse6N9D2wHe7o8uAQ 9K4AoJpA4Nx05F4KnQECVnU/hziY+RYi =JP7i -----END PGP SIGNATURE----- --bCsyhTFzCvuiizWE-- --===============0804328173== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0804328173==--