From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Du, Changbin" Subject: Re: [RFC PATCH] drm/i915: make context status notifier head be per engine Date: Thu, 9 Mar 2017 16:44:14 +0800 Message-ID: <20170309084414.GA4316@intel.com> References: <20170302112305.9628-1-changbin.du@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1800859248==" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EAE06E013 for ; Thu, 9 Mar 2017 08:46:40 +0000 (UTC) In-Reply-To: <20170302112305.9628-1-changbin.du@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: changbin.du@intel.com Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1800859248== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable hi, is there any comments for this? I'd like hear chris and daniel's comments. :) Thanks, Changbin On Thu, Mar 02, 2017 at 07:23:05PM +0800, changbin.du@intel.com wrote: > From: Changbin Du >=20 > hi, Daniel, Chris and All, > As you know, GVTg introduced the context status notifier to schedule > the GVTg workload. At that time, the notifier is bound to GVTg context > only, so GVTg is not aware of host workloads. >=20 > Now we are going to improve GVTg's guest workload scheduler policy, > and add Guc emulation support for new Gen graphics. Both these two > features require acknowledgment for all contexts running on hardware. > (But will not alter host workload.) So here try to make some change. >=20 > The change is easy: > 1. Move the context status notifier head from i915_gem_context to > intel_engine_cs. Which means there is a notifier head per engine > instead of per context. Execlist driver still call notifier for > each context sched-in/out events of current engine. > 2. At GVTg side, it binds a notifier_block for each physical engine > at GVTg initialization period. Then GVTg can hear all context > status events. >=20 > In this RFC patch, GVTg do nothing for host context event, but later > will add a function there. But in any case, the notifier callback is > a noop if this is no active vGPU. >=20 > Since intel_gvt_init() is called at early initialization stage and > require the status notifier head has been initiated, I initiate it in > intel_engine_setup(). I am not sure if this is the right place, please > correct me if wrong. Thank you! Look forward to your feedback. :) >=20 > Signed-off-by: Changbin Du --DocE+STaALJfprDB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJYwRXeAAoJEAanuZwLnPNUqEQH/jXxqAIBE2CyXQLkIX/+zE0y McyKSczg+KrhVMAADC0KPWZkjKg2q0rAvgyaQriz4+nEXWAieaqAqw/2nSoqDqka 2oXrxgC+sfQSqXUtsZFFgCTZjLh+13djbheb2D4ysO4oBW3BUQou+571Z5ugFPsL 5UHvZquf8s4s89rs1zgajKhEzEN4B1qVSJdd1zbKXbTwNoAI0OfalWsPJQ0NNl0C CY7WyjYzDGOqdKFGjrKJ9y42cXW5Avv3vNmJ6JBlckNVqid0UsZXHkdP2xSK6Tpm wFYy+pcZ1SyeWha5KdWMrU3c8P6dpZXf+IY1vtqXtOCItg3MLGXJGJ6E6d+mK1I= =L1XX -----END PGP SIGNATURE----- --DocE+STaALJfprDB-- --===============1800859248== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1800859248==--