Re: [PATCH 09/24] drm: Extract drm_file.h

Daniel Vetter
2017-03-09T10:52:30Z

On Wed, Mar 08, 2017 at 12:05:50PM -0300, Gustavo Padovan wrote:
> 2017-03-08 Daniel Vetter <daniel.vetter@ffwll.ch>:
>
> > I'm torn on whether drm_minor really should be here or somewhere else.
> > Maybe with more clarity after untangling drmP.h more this is easier to
> > decide, for now I've put a FIXME comment right next to it. Right now
> > we need struct drm_minor for the inline drm_file type helpers, and so
> > it does kinda make sense to have them here.
> >
> > Next patch will kerneldoc-ify the entire pile.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/drm_file.c | 5 +-
> > include/drm/drmP.h | 127 +--------------------------------
> > include/drm/drm_file.h | 172 +++++++++++++++++++++++++++++++++++++++++++++
> > include/drm/drm_prime.h | 1 +
> > 4 files changed, 178 insertions(+), 127 deletions(-)
> > create mode 100644 include/drm/drm_file.h
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Merged up to this patch, thanks a lot to everyone for the reviews.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org