From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/i915: Convert intel_tv connector properties to atomic, v2. Date: Tue, 14 Mar 2017 20:36:25 +0200 Message-ID: <20170314183625.GQ31595@intel.com> References: <1489064777-5460-1-git-send-email-maarten.lankhorst@linux.intel.com> <1489064777-5460-2-git-send-email-maarten.lankhorst@linux.intel.com> <20170309173602.GU31595@intel.com> <20170313092905.GZ31595@intel.com> <20170313105531.GH31595@intel.com> <55c80a55-c155-afa8-f244-20d1c4775231@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42FB46E7B5 for ; Tue, 14 Mar 2017 18:36:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <55c80a55-c155-afa8-f244-20d1c4775231@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTMsIDIwMTcgYXQgMDU6MTA6MjhQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQXMgYSBwcm9vZiBvZiBjb25jZXB0LCBmaXJzdCB0cnkgdG8gY29udmVydCBp bnRlbF90diwgd2hpY2ggaXMgYSByYXJlbHkKPiB1c2VkIGNvbm5lY3Rvci4gSXQgaGFzIDUgcHJv cGVydGllcywgdHYgZm9ybWF0IGFuZCA0IG1hcmdpbnMuCj4gCj4gSSdtIGxlc3MgY2VydGFpbiBh Ym91dCB0aGUgc3RhdGUgYmVoYXZpb3IgaXRzZWxmLCBzaG91bGQgd2UgcGFzcyBhIHNpemUKPiBw YXJhbWV0ZXIgdG8gaW50ZWxfY29ubmVjdG9yX2FsbG9jIGluc3RlYWQsIHNvIGR1cGxpY2F0ZV9z dGF0ZQo+IGNhbiBiZSBkb25lIGdsb2JhbGx5IGlmIGl0IGNhbiBiZSBibGluZGx5IGNvcGllZD8K PiAKPiBDYW4gd2UgYWxzbyBoYXZlIGEgYXRvbWljX2NoZWNrIGZ1bmN0aW9uIGZvciBjb25uZWN0 b3JzLCBzbyB0aGUKPiBjcnRjX3N0YXRlLT5jb25uZWN0b3JzX2NoYW5nZWQgY2FuIGJlIHNldCB0 aGVyZT8gSXQgd291bGQgYmUgY2xlYW5lcgo+IGFuZCBtb3JlIGF0b21pYy1saWtlLgo+IAo+IFRv IG1hdGNoIHRoZSBsZWdhY3kgYmVoYXZpb3IsIGZvcm1hdCBjYW4gYmUgY2hhbmdlZCBieSBwcm9i aW5nIGp1c3QgbGlrZQo+IGluIGxlZ2FjeSBtb2RlLgo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4g LSBBZGQgaW50ZWxfZW5jb2Rlci0+c3dhcF9zdGF0ZSB0byBhbGxvdyB1cGRhdGluZyBjb25uZWN0 b3Igc3RhdGUuCj4gLSBBZGQgaW50ZWxfdHYtPmZvcm1hdCBmb3IgZGV0ZWN0X21vZGUgYW5kIG1v ZGVfdmFsaWQsIHVwZGF0ZWQgb24gYXRvbWljIGNvbW1pdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBN YWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAgMTUgKysKPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgICA0ICsKPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdHYuYyAgICAgIHwgMjU5ICsrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTc2IGluc2VydGlvbnMoKyksIDEwMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggYWMy NWM5YmM4YjgxLi4xOGI3ZTc1NDZlZTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCjxzbmlwPgo+ICsKPiArc3RhdGljIGludAo+ICtpbnRlbF90dl9hdG9taWNfZ2V0X3By b3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gKwkJCQkgICAgY29uc3Qg c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKnN0YXRlLAo+ICsJCQkJICAgIHN0cnVjdCBkcm1f cHJvcGVydHkgKnByb3BlcnR5LAo+ICsJCQkJICAgIHVpbnQ2NF90ICp2YWwpCj4gK3sKPiArCXN0 cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjb25uZWN0b3ItPmRldjsKPiArCXN0cnVjdCBpbnRlbF90 dl9jb25uZWN0b3Jfc3RhdGUgKnR2X3N0YXRlID0KPiArCQl0b19pbnRlbF90dl9jb25uZWN0b3Jf c3RhdGUoc3RhdGUpOwo+ICsKPiArCWlmIChwcm9wZXJ0eSA9PSBkZXYtPm1vZGVfY29uZmlnLnR2 X2xlZnRfbWFyZ2luX3Byb3BlcnR5KQo+ICsJCSp2YWwgPSB0dl9zdGF0ZS0+bWFyZ2luW1RWX01B UkdJTl9MRUZUXTsKPiArCWVsc2UgaWYgKHByb3BlcnR5ID09IGRldi0+bW9kZV9jb25maWcudHZf cmlnaHRfbWFyZ2luX3Byb3BlcnR5KQo+ICsJCSp2YWwgPSB0dl9zdGF0ZS0+bWFyZ2luW1RWX01B UkdJTl9SSUdIVF07Cj4gKwllbHNlIGlmIChwcm9wZXJ0eSA9PSBkZXYtPm1vZGVfY29uZmlnLnR2 X3RvcF9tYXJnaW5fcHJvcGVydHkpCj4gKwkJKnZhbCA9IHR2X3N0YXRlLT5tYXJnaW5bVFZfTUFS R0lOX1RPUF07Cj4gKwllbHNlIGlmIChwcm9wZXJ0eSA9PSBkZXYtPm1vZGVfY29uZmlnLnR2X2Jv dHRvbV9tYXJnaW5fcHJvcGVydHkpCj4gKwkJKnZhbCA9IHR2X3N0YXRlLT5tYXJnaW5bVFZfTUFS R0lOX0JPVFRPTV07Cj4gKwllbHNlIGlmIChwcm9wZXJ0eSA9PSBkZXYtPm1vZGVfY29uZmlnLnR2 X21vZGVfcHJvcGVydHkpIHsKPiArCQkqdmFsID0gdHZfc3RhdGUtPmZvcm1hdDsKCkFjdHVhbGx5 LCBhcmVuJ3QgYWxsIG9mIHRoZXNlIGhhbmRsZWQgYnkgZHJtX2F0b21pY19jb25uZWN0b3Jfc2V0 X3Byb3BlcnR5KCkKYWxyZWFkeT8KCkFuZCBzYW1lIGRlYWwgd2l0aCBkcm1fYXRvbWljX2Nvbm5l Y3Rvcl9nZXRfcHJvcGVydHkoKSBBRkFJQ1MuCgo+ICAJfSBlbHNlIHsKPiAtCQlyZXQgPSAtRUlO VkFMOwo+IC0JCWdvdG8gb3V0Owo+ICsJCURSTV9ERUJVR19BVE9NSUMoIlVua25vd24gYXRvbWlj IHByb3BlcnR5ICVzXG4iLCBwcm9wZXJ0eS0+bmFtZSk7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4g IAl9Cj4gIAo+IC0JaWYgKGNoYW5nZWQgJiYgY3J0YykKPiAtCQlpbnRlbF9jcnRjX3Jlc3RvcmVf bW9kZShjcnRjKTsKPiAtb3V0Ogo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVybiAwOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKgo+ICtpbnRlbF90dl9kdXBs aWNhdGVfc3RhdGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiArewo+ICsJc3Ry dWN0IGludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGU7Cj4gKwo+ICsJc3RhdGUgPSBrbWVt ZHVwKCZjb25uZWN0b3ItPnN0YXRlLCBzaXplb2YoKnN0YXRlKSwgR0ZQX0tFUk5FTCk7Cj4gKwlp ZiAoc3RhdGUpCj4gKwkJX19kcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZHVwbGljYXRlX3N0 YXRlKGNvbm5lY3RvciwgJnN0YXRlLT5iYXNlKTsKPiArCj4gKwlyZXR1cm4gJnN0YXRlLT5iYXNl Owo+ICB9Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3JfZnVuY3MgaW50 ZWxfdHZfY29ubmVjdG9yX2Z1bmNzID0gewo+IEBAIC0xNTIwLDExICsxNTcwLDEyIEBAIHN0YXRp YyBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9mdW5jcyBpbnRlbF90dl9jb25uZWN0b3JfZnVu Y3MgPSB7Cj4gIAkubGF0ZV9yZWdpc3RlciA9IGludGVsX2Nvbm5lY3Rvcl9yZWdpc3RlciwKPiAg CS5lYXJseV91bnJlZ2lzdGVyID0gaW50ZWxfY29ubmVjdG9yX3VucmVnaXN0ZXIsCj4gIAkuZGVz dHJveSA9IGludGVsX3R2X2Rlc3Ryb3ksCj4gLQkuc2V0X3Byb3BlcnR5ID0gaW50ZWxfdHZfc2V0 X3Byb3BlcnR5LAo+IC0JLmF0b21pY19nZXRfcHJvcGVydHkgPSBpbnRlbF9jb25uZWN0b3JfYXRv bWljX2dldF9wcm9wZXJ0eSwKPiArCS5zZXRfcHJvcGVydHkgPSBkcm1fYXRvbWljX2hlbHBlcl9j b25uZWN0b3Jfc2V0X3Byb3BlcnR5LAo+ICsJLmF0b21pY19zZXRfcHJvcGVydHkgPSBpbnRlbF90 dl9hdG9taWNfc2V0X3Byb3BlcnR5LAo+ICsJLmF0b21pY19nZXRfcHJvcGVydHkgPSBpbnRlbF90 dl9hdG9taWNfZ2V0X3Byb3BlcnR5LAo+ICAJLmZpbGxfbW9kZXMgPSBkcm1faGVscGVyX3Byb2Jl X3NpbmdsZV9jb25uZWN0b3JfbW9kZXMsCj4gIAkuYXRvbWljX2Rlc3Ryb3lfc3RhdGUgPSBkcm1f YXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZGVzdHJveV9zdGF0ZSwKPiAtCS5hdG9taWNfZHVwbGlj YXRlX3N0YXRlID0gZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2R1cGxpY2F0ZV9zdGF0ZSwK PiArCS5hdG9taWNfZHVwbGljYXRlX3N0YXRlID0gaW50ZWxfdHZfZHVwbGljYXRlX3N0YXRlLAo+ ICB9Owo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX2hlbHBlcl9mdW5j cyBpbnRlbF90dl9jb25uZWN0b3JfaGVscGVyX2Z1bmNzID0gewo+IEBAIC0xNTQ3LDYgKzE1OTgs NyBAQCBpbnRlbF90dl9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAg CXUzMiB0dl9kYWNfb24sIHR2X2RhY19vZmYsIHNhdmVfdHZfZGFjOwo+ICAJY29uc3QgY2hhciAq dHZfZm9ybWF0X25hbWVzW0FSUkFZX1NJWkUodHZfbW9kZXMpXTsKPiAgCWludCBpLCBpbml0aWFs X21vZGUgPSAwOwo+ICsJc3RydWN0IGludGVsX3R2X2Nvbm5lY3Rvcl9zdGF0ZSAqc3RhdGU7Cj4g IAo+ICAJaWYgKChJOTE1X1JFQUQoVFZfQ1RMKSAmIFRWX0ZVU0VfU1RBVEVfTUFTSykgPT0gVFZf RlVTRV9TVEFURV9ESVNBQkxFRCkKPiAgCQlyZXR1cm47Cj4gQEAgLTE1ODAsMTYgKzE2MzIsMTcg QEAgaW50ZWxfdHZfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJ cmV0dXJuOwo+ICAKPiAgCWludGVsX3R2ID0ga3phbGxvYyhzaXplb2YoKmludGVsX3R2KSwgR0ZQ X0tFUk5FTCk7Cj4gLQlpZiAoIWludGVsX3R2KSB7Cj4gLQkJcmV0dXJuOwo+IC0JfQo+IC0KPiAt CWludGVsX2Nvbm5lY3RvciA9IGludGVsX2Nvbm5lY3Rvcl9hbGxvYygpOwo+IC0JaWYgKCFpbnRl bF9jb25uZWN0b3IpIHsKPiArCWludGVsX2Nvbm5lY3RvciA9IGt6YWxsb2Moc2l6ZW9mKCppbnRl bF9jb25uZWN0b3IpLCBHRlBfS0VSTkVMKTsKPiArCXN0YXRlID0ga3phbGxvYyhzaXplb2YoKnN0 YXRlKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIWludGVsX3R2IHx8ICFpbnRlbF9jb25uZWN0b3Ig fHwgIXN0YXRlKSB7Cj4gKwkJa2ZyZWUoaW50ZWxfY29ubmVjdG9yKTsKPiArCQlrZnJlZShzdGF0 ZSk7Cj4gIAkJa2ZyZWUoaW50ZWxfdHYpOwo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gKwlfX2Ry bV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9yZXNldCgmaW50ZWxfY29ubmVjdG9yLT5iYXNlLCAm c3RhdGUtPmJhc2UpOwo+ICsKPiAgCWludGVsX2VuY29kZXIgPSAmaW50ZWxfdHYtPmJhc2U7Cj4g IAljb25uZWN0b3IgPSAmaW50ZWxfY29ubmVjdG9yLT5iYXNlOwo+ICAKPiBAQCAtMTYxNyw2ICsx NjcwLDcgQEAgaW50ZWxfdHZfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gIAlpbnRlbF9lbmNvZGVyLT5kaXNhYmxlID0gaW50ZWxfZGlzYWJsZV90djsKPiAgCWludGVs X2VuY29kZXItPmdldF9od19zdGF0ZSA9IGludGVsX3R2X2dldF9od19zdGF0ZTsKPiAgCWludGVs X2Nvbm5lY3Rvci0+Z2V0X2h3X3N0YXRlID0gaW50ZWxfY29ubmVjdG9yX2dldF9od19zdGF0ZTsK PiArCWludGVsX2Nvbm5lY3Rvci0+c3dhcF9zdGF0ZSA9IGludGVsX3R2X3N3YXBfc3RhdGU7Cj4g IAo+ICAJaW50ZWxfY29ubmVjdG9yX2F0dGFjaF9lbmNvZGVyKGludGVsX2Nvbm5lY3RvciwgaW50 ZWxfZW5jb2Rlcik7Cj4gIAo+IEBAIC0xNjI5LDEyICsxNjgzLDEzIEBAIGludGVsX3R2X2luaXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJaW50ZWxfdHYtPnR5cGUgPSBE Uk1fTU9ERV9DT05ORUNUT1JfVW5rbm93bjsKPiAgCj4gIAkvKiBCSU9TIG1hcmdpbiB2YWx1ZXMg Ki8KPiAtCWludGVsX3R2LT5tYXJnaW5bVFZfTUFSR0lOX0xFRlRdID0gNTQ7Cj4gLQlpbnRlbF90 di0+bWFyZ2luW1RWX01BUkdJTl9UT1BdID0gMzY7Cj4gLQlpbnRlbF90di0+bWFyZ2luW1RWX01B UkdJTl9SSUdIVF0gPSA0NjsKPiAtCWludGVsX3R2LT5tYXJnaW5bVFZfTUFSR0lOX0JPVFRPTV0g PSAzNzsKPiArCXN0YXRlLT5tYXJnaW5bVFZfTUFSR0lOX0xFRlRdID0gNTQ7Cj4gKwlzdGF0ZS0+ bWFyZ2luW1RWX01BUkdJTl9UT1BdID0gMzY7Cj4gKwlzdGF0ZS0+bWFyZ2luW1RWX01BUkdJTl9S SUdIVF0gPSA0NjsKPiArCXN0YXRlLT5tYXJnaW5bVFZfTUFSR0lOX0JPVFRPTV0gPSAzNzsKPiAg Cj4gLQlpbnRlbF90di0+dHZfZm9ybWF0ID0gdHZfbW9kZXNbaW5pdGlhbF9tb2RlXS5uYW1lOwo+ ICsJc3RhdGUtPmZvcm1hdCA9IGluaXRpYWxfbW9kZTsKPiArCWludGVsX3R2LT5mb3JtYXQgPSBp bml0aWFsX21vZGU7Cj4gIAo+ICAJZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfYWRkKGNvbm5lY3Rvciwg JmludGVsX3R2X2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MpOwo+ICAJY29ubmVjdG9yLT5pbnRlcmxh Y2VfYWxsb3dlZCA9IGZhbHNlOwo+IEBAIC0xNjQ4LDE3ICsxNzAzLDE3IEBAIGludGVsX3R2X2lu aXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCQkJICAgICAgdHZfZm9y bWF0X25hbWVzKTsKPiAgCj4gIAlkcm1fb2JqZWN0X2F0dGFjaF9wcm9wZXJ0eSgmY29ubmVjdG9y LT5iYXNlLCBkZXYtPm1vZGVfY29uZmlnLnR2X21vZGVfcHJvcGVydHksCj4gLQkJCQkgICBpbml0 aWFsX21vZGUpOwo+ICsJCQkJICAgc3RhdGUtPmZvcm1hdCk7Cj4gIAlkcm1fb2JqZWN0X2F0dGFj aF9wcm9wZXJ0eSgmY29ubmVjdG9yLT5iYXNlLAo+ICAJCQkJICAgZGV2LT5tb2RlX2NvbmZpZy50 dl9sZWZ0X21hcmdpbl9wcm9wZXJ0eSwKPiAtCQkJCSAgIGludGVsX3R2LT5tYXJnaW5bVFZfTUFS R0lOX0xFRlRdKTsKPiArCQkJCSAgIHN0YXRlLT5tYXJnaW5bVFZfTUFSR0lOX0xFRlRdKTsKPiAg CWRybV9vYmplY3RfYXR0YWNoX3Byb3BlcnR5KCZjb25uZWN0b3ItPmJhc2UsCj4gIAkJCQkgICBk ZXYtPm1vZGVfY29uZmlnLnR2X3RvcF9tYXJnaW5fcHJvcGVydHksCj4gLQkJCQkgICBpbnRlbF90 di0+bWFyZ2luW1RWX01BUkdJTl9UT1BdKTsKPiArCQkJCSAgIHN0YXRlLT5tYXJnaW5bVFZfTUFS R0lOX1RPUF0pOwo+ICAJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHkoJmNvbm5lY3Rvci0+YmFz ZSwKPiAgCQkJCSAgIGRldi0+bW9kZV9jb25maWcudHZfcmlnaHRfbWFyZ2luX3Byb3BlcnR5LAo+ IC0JCQkJICAgaW50ZWxfdHYtPm1hcmdpbltUVl9NQVJHSU5fUklHSFRdKTsKPiArCQkJCSAgIHN0 YXRlLT5tYXJnaW5bVFZfTUFSR0lOX1JJR0hUXSk7Cj4gIAlkcm1fb2JqZWN0X2F0dGFjaF9wcm9w ZXJ0eSgmY29ubmVjdG9yLT5iYXNlLAo+ICAJCQkJICAgZGV2LT5tb2RlX2NvbmZpZy50dl9ib3R0 b21fbWFyZ2luX3Byb3BlcnR5LAo+IC0JCQkJICAgaW50ZWxfdHYtPm1hcmdpbltUVl9NQVJHSU5f Qk9UVE9NXSk7Cj4gKwkJCQkgICBzdGF0ZS0+bWFyZ2luW1RWX01BUkdJTl9CT1RUT01dKTsKPiAg fQo+IC0tIAo+IDIuNy40Cj4gCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK