From: Chuanxiao Dong <chuanxiao.dong@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Subject: [PATCH] drm/i915/scheduler: add gvt notification for guc submission
Date: Mon, 20 Mar 2017 09:48:31 +0800 [thread overview]
Message-ID: <20170320014831.GA7667@intel.com> (raw)
GVT request needs a manual mmio load/restore. Before GuC submit
a request, send notification to gvt for mmio loading. And after
the GuC finished this GVT request, notify gvt again for mmio
restore. This follows the usage when using execlists submission.
Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
---
drivers/gpu/drm/i915/i915_guc_submission.c | 13 +++++++++++++
drivers/gpu/drm/i915/intel_lrc.c | 15 ---------------
drivers/gpu/drm/i915/intel_lrc.h | 14 ++++++++++++++
3 files changed, 27 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index a3636b3..328b11c 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -520,6 +520,12 @@ static void __i915_guc_submit(struct drm_i915_gem_request *rq)
unsigned long flags;
int b_ret;
+ /* Notify for the context status change schedule in
+ * Currently only GVT care this notification for manually
+ * context switch, like when using execlist mode submission
+ */
+ execlists_context_status_change(rq, INTEL_CONTEXT_SCHEDULE_IN);
+
/* WA to flush out the pending GMADR writes to ring buffer. */
if (i915_vma_is_map_and_fenceable(rq->ring->vma))
POSTING_READ_FW(GUC_STATUS);
@@ -623,6 +629,13 @@ static void i915_guc_irq_handler(unsigned long data)
rq = port[0].request;
while (rq && i915_gem_request_completed(rq)) {
trace_i915_gem_request_out(rq);
+ /* Notify for the context status change schedule
+ * out. Currently only GVT care this notification
+ * for manually context switch, like when using
+ * execlist mode submission
+ */
+ execlists_context_status_change(rq,
+ INTEL_CONTEXT_SCHEDULE_OUT);
i915_gem_request_put(rq);
port[0].request = port[1].request;
port[1].request = NULL;
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index becde55..4f5906b 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -295,21 +295,6 @@ uint64_t intel_lr_context_descriptor(struct i915_gem_context *ctx,
return ctx->engine[engine->id].lrc_desc;
}
-static inline void
-execlists_context_status_change(struct drm_i915_gem_request *rq,
- unsigned long status)
-{
- /*
- * Only used when GVT-g is enabled now. When GVT-g is disabled,
- * The compiler should eliminate this function as dead-code.
- */
- if (!IS_ENABLED(CONFIG_DRM_I915_GVT))
- return;
-
- atomic_notifier_call_chain(&rq->engine->context_status_notifier,
- status, rq);
-}
-
static void
execlists_update_context_pdps(struct i915_hw_ppgtt *ppgtt, u32 *reg_state)
{
diff --git a/drivers/gpu/drm/i915/intel_lrc.h b/drivers/gpu/drm/i915/intel_lrc.h
index e8015e7..d3aa108 100644
--- a/drivers/gpu/drm/i915/intel_lrc.h
+++ b/drivers/gpu/drm/i915/intel_lrc.h
@@ -87,5 +87,19 @@ uint64_t intel_lr_context_descriptor(struct i915_gem_context *ctx,
/* Execlists */
int intel_sanitize_enable_execlists(struct drm_i915_private *dev_priv,
int enable_execlists);
+static inline void
+execlists_context_status_change(struct drm_i915_gem_request *rq,
+ unsigned long status)
+{
+ /*
+ * Only used when GVT-g is enabled now. When GVT-g is disabled,
+ * The compiler should eliminate this function as dead-code.
+ */
+ if (!IS_ENABLED(CONFIG_DRM_I915_GVT))
+ return;
+
+ atomic_notifier_call_chain(&rq->engine->context_status_notifier,
+ status, rq);
+}
#endif /* _INTEL_LRC_H_ */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2017-03-20 1:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 1:48 Chuanxiao Dong [this message]
2017-03-20 2:46 ` [PATCH] drm/i915/scheduler: add gvt notification for guc submission Zheng, Xiao
2017-03-20 3:19 ` Dong, Chuanxiao
2017-03-21 1:38 ` Zheng, Xiao
2017-03-21 1:58 ` Dong, Chuanxiao
2017-03-21 2:38 ` [PATCH v2] " Chuanxiao Dong
2017-03-21 3:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-03-21 11:23 ` ✗ Fi.CI.BAT: failure " Patchwork
2017-03-22 6:34 ` [PATCH v3] " Chuanxiao Dong
2017-03-23 5:29 ` Dong, Chuanxiao
2017-03-23 7:58 ` Tian, Kevin
2017-03-23 9:37 ` Joonas Lahtinen
2017-03-23 9:42 ` Chris Wilson
2017-03-23 13:43 ` Dong, Chuanxiao
2017-03-23 13:43 ` Dong, Chuanxiao
2017-03-23 9:51 ` Tvrtko Ursulin
2017-03-23 13:51 ` Dong, Chuanxiao
2017-03-24 1:49 ` [PATCH v4] " Chuanxiao Dong
2017-03-27 2:35 ` Dong, Chuanxiao
2017-03-27 10:14 ` Joonas Lahtinen
2017-03-27 10:58 ` Dong, Chuanxiao
2017-03-27 11:43 ` Joonas Lahtinen
2017-03-27 13:32 ` [PATCH v5] " Chuanxiao Dong
2017-03-27 13:49 ` Chris Wilson
2017-03-27 14:22 ` Dong, Chuanxiao
2017-03-27 14:33 ` Chris Wilson
2017-03-27 14:39 ` Dong, Chuanxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320014831.GA7667@intel.com \
--to=chuanxiao.dong@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).