From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: simplify intel_ddi_pll_select() Date: Wed, 22 Mar 2017 15:21:04 +0200 Message-ID: <20170322132104.GC31595@intel.com> References: <1490133430-13999-1-git-send-email-paulo.r.zanoni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1B5E6E343 for ; Wed, 22 Mar 2017 13:21:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1490133430-13999-1-git-send-email-paulo.r.zanoni@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMjEsIDIwMTcgYXQgMDY6NTc6MTBQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IEJlY2F1c2Uge2hzdyxza2wsYnh0fV9kZGlfcGxsX3NlbGVjdCBhbGwgcHJldHR5IG11 Y2ggZG8gdGhlIHNhbWUgdGhpbmcKPiBpbiBzbGlnaHRseSBkaWZmZXJlbnQgd2F5cy4gUmVwbGFj ZSBldmVyeXRoaW5nIHdpdGggYSBzaW1wbGUgY29weSBvZgo+IHRoZSBmdW5jdGlvbiBhbmQgaW5s aW5lIGl0IGluc2lkZSBpbnRsZV9kZGlfcGxsX3NlbGVjdCgpLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyB8IDU4ICsrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNTEgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk aS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCBkODIxNGJhLi5i ZDZmZDBiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMTEyNyw0NyArMTEy Nyw2IEBAIHZvaWQgaW50ZWxfZGRpX2Nsb2NrX2dldChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5j b2RlciwKPiAgCQlieHRfZGRpX2Nsb2NrX2dldChlbmNvZGVyLCBwaXBlX2NvbmZpZyk7Cj4gIH0K PiAgCj4gLXN0YXRpYyBib29sCj4gLWhzd19kZGlfcGxsX3NlbGVjdChzdHJ1Y3QgaW50ZWxfY3J0 YyAqaW50ZWxfY3J0YywKPiAtCQkgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0 ZSwKPiAtCQkgICBzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAtewo+IC0Jc3RydWN0 IGludGVsX3NoYXJlZF9kcGxsICpwbGw7Cj4gLQo+IC0JcGxsID0gaW50ZWxfZ2V0X3NoYXJlZF9k cGxsKGludGVsX2NydGMsIGNydGNfc3RhdGUsCj4gLQkJCQkgICAgZW5jb2Rlcik7Cj4gLQlpZiAo IXBsbCkKPiAtCQlEUk1fREVCVUdfRFJJVkVSKCJmYWlsZWQgdG8gZmluZCBQTEwgZm9yIHBpcGUg JWNcbiIsCj4gLQkJCQkgcGlwZV9uYW1lKGludGVsX2NydGMtPnBpcGUpKTsKPiAtCj4gLQlyZXR1 cm4gcGxsOwo+IC19Cj4gLQo+IC1zdGF0aWMgYm9vbAo+IC1za2xfZGRpX3BsbF9zZWxlY3Qoc3Ry dWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gLQkJICAgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNydGNfc3RhdGUsCj4gLQkJICAgc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4g LXsKPiAtCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+IC0KPiAtCXBsbCA9IGludGVs X2dldF9zaGFyZWRfZHBsbChpbnRlbF9jcnRjLCBjcnRjX3N0YXRlLCBlbmNvZGVyKTsKPiAtCWlm IChwbGwgPT0gTlVMTCkgewo+IC0JCURSTV9ERUJVR19EUklWRVIoImZhaWxlZCB0byBmaW5kIFBM TCBmb3IgcGlwZSAlY1xuIiwKPiAtCQkJCSBwaXBlX25hbWUoaW50ZWxfY3J0Yy0+cGlwZSkpOwo+ IC0JCXJldHVybiBmYWxzZTsKPiAtCX0KPiAtCj4gLQlyZXR1cm4gdHJ1ZTsKPiAtfQo+IC0KPiAt c3RhdGljIGJvb2wKPiAtYnh0X2RkaV9wbGxfc2VsZWN0KHN0cnVjdCBpbnRlbF9jcnRjICppbnRl bF9jcnRjLAo+IC0JCSAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+IC0J CSAgIHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+IC17Cj4gLQlyZXR1cm4gISFpbnRl bF9nZXRfc2hhcmVkX2RwbGwoaW50ZWxfY3J0YywgY3J0Y19zdGF0ZSwgZW5jb2Rlcik7Cj4gLX0K PiAtCj4gIC8qCj4gICAqIFRyaWVzIHRvIGZpbmQgYSAqc2hhcmVkKiBQTEwgZm9yIHRoZSBDUlRD IGFuZCBzdG9yZSBpdCBpbgo+ICAgKiBpbnRlbF9jcnRjLT5kZGlfcGxsX3NlbC4KPiBAQCAtMTE3 OCwxOSArMTEzNywxNiBAQCBieHRfZGRpX3BsbF9zZWxlY3Qoc3RydWN0IGludGVsX2NydGMgKmlu dGVsX2NydGMsCj4gIGJvb2wgaW50ZWxfZGRpX3BsbF9zZWxlY3Qoc3RydWN0IGludGVsX2NydGMg KmludGVsX2NydGMsCj4gIAkJCSAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUp Cj4gIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoaW50 ZWxfY3J0Yy0+YmFzZS5kZXYpOwo+ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIgPQo+ ICAJCWludGVsX2RkaV9nZXRfY3J0Y19uZXdfZW5jb2RlcihjcnRjX3N0YXRlKTsKPiArCXN0cnVj dCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+ICAKPiAtCWlmIChJU19HRU45X0JDKGRldl9wcml2 KSkKPiAtCQlyZXR1cm4gc2tsX2RkaV9wbGxfc2VsZWN0KGludGVsX2NydGMsIGNydGNfc3RhdGUs Cj4gLQkJCQkJICBlbmNvZGVyKTsKPiAtCWVsc2UgaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKQo+ IC0JCXJldHVybiBieHRfZGRpX3BsbF9zZWxlY3QoaW50ZWxfY3J0YywgY3J0Y19zdGF0ZSwKPiAt CQkJCQkgIGVuY29kZXIpOwo+IC0JZWxzZQo+IC0JCXJldHVybiBoc3dfZGRpX3BsbF9zZWxlY3Qo aW50ZWxfY3J0YywgY3J0Y19zdGF0ZSwKPiAtCQkJCQkgIGVuY29kZXIpOwo+ICsJcGxsID0gaW50 ZWxfZ2V0X3NoYXJlZF9kcGxsKGludGVsX2NydGMsIGNydGNfc3RhdGUsIGVuY29kZXIpOwoKSSB3 b25kZXIgaWYgaW50ZWxfZGRpX3BsbF9zZWxlY3QoKSBoYXMgYW55IGdvb2QgcmVhc29uIHRvIGV2 ZW4gZXhpc3QKYW55bW9yZS4gSXQncyBqdXN0IGNhbGxpbmcgdGhpcyBvbmUgZnVuY3Rpb24sIHNv IG1heWJlIHdlIHNob3VsZCBqdXN0CmNhbGwgaXQgZGlyZWN0bHk/Cgo+ICsJaWYgKCFwbGwpCj4g KwkJRFJNX0RFQlVHX0RSSVZFUigiZmFpbGVkIHRvIGZpbmQgUExMIGZvciBwaXBlICVjXG4iLAo+ ICsJCQkJICBwaXBlX25hbWUoaW50ZWxfY3J0Yy0+cGlwZSkpOwo+ICsKPiArCXJldHVybiBwbGw7 CgpJIHdvdWxkIHByb2JhYmx5IHdyaXRlICdwbGwgIT0gTlVMTCcgZm9yIGEgYml0IG9mIGV4dHJh IGNsYXJpdHkuCgpFaXRoZXIgd2F5ClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAgfQo+ICAKPiAgdm9pZCBpbnRlbF9kZGlfc2V0 X3BpcGVfc2V0dGluZ3MoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUp Cj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=