From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: simplify intel_ddi_pll_select()
Date: Wed, 22 Mar 2017 19:50:09 +0200
Message-ID: <20170322175009.GH31595@intel.com>
References: <1490133430-13999-1-git-send-email-paulo.r.zanoni@intel.com>
 <20170322132104.GC31595@intel.com>
 <1490204401.25640.6.camel@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CCE5D6E95A
 for <intel-gfx@lists.freedesktop.org>; Wed, 22 Mar 2017 17:50:16 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1490204401.25640.6.camel@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBNYXIgMjIsIDIwMTcgYXQgMDI6NDA6MDFQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy
b3RlOgo+IEVtIFF1YSwgMjAxNy0wMy0yMiDDoHMgMTU6MjEgKzAyMDAsIFZpbGxlIFN5cmrDpGzD
pCBlc2NyZXZldToKPiA+IE9uIFR1ZSwgTWFyIDIxLCAyMDE3IGF0IDA2OjU3OjEwUE0gLTAzMDAs
IFBhdWxvIFphbm9uaSB3cm90ZToKPiA+ID4gCj4gPiA+IEJlY2F1c2Uge2hzdyxza2wsYnh0fV9k
ZGlfcGxsX3NlbGVjdCBhbGwgcHJldHR5IG11Y2ggZG8gdGhlIHNhbWUKPiA+ID4gdGhpbmcKPiA+
ID4gaW4gc2xpZ2h0bHkgZGlmZmVyZW50IHdheXMuIFJlcGxhY2UgZXZlcnl0aGluZyB3aXRoIGEg
c2ltcGxlIGNvcHkKPiA+ID4gb2YKPiA+ID4gdGhlIGZ1bmN0aW9uIGFuZCBpbmxpbmUgaXQgaW5z
aWRlIGludGxlX2RkaV9wbGxfc2VsZWN0KCkuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBQ
YXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+IMKg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCA1OCArKysrKy0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tCj4gPiA+IC0tLS0tLS0tLS0tLQo+ID4gPiDCoDEgZmlsZSBjaGFuZ2VkLCA3IGlu
c2VydGlvbnMoKyksIDUxIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZGRpLmMKPiA+ID4gaW5kZXggZDgyMTRiYS4uYmQ2ZmQwYiAxMDA2NDQKPiA+ID4g
LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ID4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ID4gQEAgLTExMjcsNDcgKzExMjcsNiBAQCB2
b2lkIGludGVsX2RkaV9jbG9ja19nZXQoc3RydWN0Cj4gPiA+IGludGVsX2VuY29kZXIgKmVuY29k
ZXIsCj4gPiA+IMKgCQlieHRfZGRpX2Nsb2NrX2dldChlbmNvZGVyLCBwaXBlX2NvbmZpZyk7Cj4g
PiA+IMKgfQo+ID4gPiDCoAo+ID4gPiAtc3RhdGljIGJvb2wKPiA+ID4gLWhzd19kZGlfcGxsX3Nl
bGVjdChzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywKPiA+ID4gLQkJwqDCoMKgc3RydWN0
IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPiA+IC0JCcKgwqDCoHN0cnVjdCBpbnRl
bF9lbmNvZGVyICplbmNvZGVyKQo+ID4gPiAtewo+ID4gPiAtCXN0cnVjdCBpbnRlbF9zaGFyZWRf
ZHBsbCAqcGxsOwo+ID4gPiAtCj4gPiA+IC0JcGxsID0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsKGlu
dGVsX2NydGMsIGNydGNfc3RhdGUsCj4gPiA+IC0JCQkJwqDCoMKgwqBlbmNvZGVyKTsKPiA+ID4g
LQlpZiAoIXBsbCkKPiA+ID4gLQkJRFJNX0RFQlVHX0RSSVZFUigiZmFpbGVkIHRvIGZpbmQgUExM
IGZvciBwaXBlCj4gPiA+ICVjXG4iLAo+ID4gPiAtCQkJCcKgcGlwZV9uYW1lKGludGVsX2NydGMt
PnBpcGUpKTsKPiA+ID4gLQo+ID4gPiAtCXJldHVybiBwbGw7Cj4gPiA+IC19Cj4gPiA+IC0KPiA+
ID4gLXN0YXRpYyBib29sCj4gPiA+IC1za2xfZGRpX3BsbF9zZWxlY3Qoc3RydWN0IGludGVsX2Ny
dGMgKmludGVsX2NydGMsCj4gPiA+IC0JCcKgwqDCoHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpj
cnRjX3N0YXRlLAo+ID4gPiAtCQnCoMKgwqBzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikK
PiA+ID4gLXsKPiA+ID4gLQlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbDsKPiA+ID4gLQo+
ID4gPiAtCXBsbCA9IGludGVsX2dldF9zaGFyZWRfZHBsbChpbnRlbF9jcnRjLCBjcnRjX3N0YXRl
LAo+ID4gPiBlbmNvZGVyKTsKPiA+ID4gLQlpZiAocGxsID09IE5VTEwpIHsKPiA+ID4gLQkJRFJN
X0RFQlVHX0RSSVZFUigiZmFpbGVkIHRvIGZpbmQgUExMIGZvciBwaXBlCj4gPiA+ICVjXG4iLAo+
ID4gPiAtCQkJCcKgcGlwZV9uYW1lKGludGVsX2NydGMtPnBpcGUpKTsKPiA+ID4gLQkJcmV0dXJu
IGZhbHNlOwo+ID4gPiAtCX0KPiA+ID4gLQo+ID4gPiAtCXJldHVybiB0cnVlOwo+ID4gPiAtfQo+
ID4gPiAtCj4gPiA+IC1zdGF0aWMgYm9vbAo+ID4gPiAtYnh0X2RkaV9wbGxfc2VsZWN0KHN0cnVj
dCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ID4gPiAtCQnCoMKgwqBzdHJ1Y3QgaW50ZWxfY3J0
Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiA+ID4gLQkJwqDCoMKgc3RydWN0IGludGVsX2VuY29kZXIg
KmVuY29kZXIpCj4gPiA+IC17Cj4gPiA+IC0JcmV0dXJuICEhaW50ZWxfZ2V0X3NoYXJlZF9kcGxs
KGludGVsX2NydGMsIGNydGNfc3RhdGUsCj4gPiA+IGVuY29kZXIpOwo+ID4gPiAtfQo+ID4gPiAt
Cj4gPiA+IMKgLyoKPiA+ID4gwqAgKiBUcmllcyB0byBmaW5kIGEgKnNoYXJlZCogUExMIGZvciB0
aGUgQ1JUQyBhbmQgc3RvcmUgaXQgaW4KPiA+ID4gwqAgKiBpbnRlbF9jcnRjLT5kZGlfcGxsX3Nl
bC4KPiA+ID4gQEAgLTExNzgsMTkgKzExMzcsMTYgQEAgYnh0X2RkaV9wbGxfc2VsZWN0KHN0cnVj
dCBpbnRlbF9jcnRjCj4gPiA+ICppbnRlbF9jcnRjLAo+ID4gPiDCoGJvb2wgaW50ZWxfZGRpX3Bs
bF9zZWxlY3Qoc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMsCj4gPiA+IMKgCQkJwqDCoHN0
cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ID4gPiDCoHsKPiA+ID4gLQlzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGludGVsX2NydGMtCj4gPiA+
ID5iYXNlLmRldik7Cj4gPiA+IMKgCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyID0KPiA+
ID4gwqAJCWludGVsX2RkaV9nZXRfY3J0Y19uZXdfZW5jb2RlcihjcnRjX3N0YXRlKTsKPiA+ID4g
KwlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbDsKPiA+ID4gwqAKPiA+ID4gLQlpZiAoSVNf
R0VOOV9CQyhkZXZfcHJpdikpCj4gPiA+IC0JCXJldHVybiBza2xfZGRpX3BsbF9zZWxlY3QoaW50
ZWxfY3J0YywgY3J0Y19zdGF0ZSwKPiA+ID4gLQkJCQkJwqDCoGVuY29kZXIpOwo+ID4gPiAtCWVs
c2UgaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKQo+ID4gPiAtCQlyZXR1cm4gYnh0X2RkaV9wbGxf
c2VsZWN0KGludGVsX2NydGMsIGNydGNfc3RhdGUsCj4gPiA+IC0JCQkJCcKgwqBlbmNvZGVyKTsK
PiA+ID4gLQllbHNlCj4gPiA+IC0JCXJldHVybiBoc3dfZGRpX3BsbF9zZWxlY3QoaW50ZWxfY3J0
YywgY3J0Y19zdGF0ZSwKPiA+ID4gLQkJCQkJwqDCoGVuY29kZXIpOwo+ID4gPiArCXBsbCA9IGlu
dGVsX2dldF9zaGFyZWRfZHBsbChpbnRlbF9jcnRjLCBjcnRjX3N0YXRlLAo+ID4gPiBlbmNvZGVy
KTsKPiA+IAo+ID4gSSB3b25kZXIgaWYgaW50ZWxfZGRpX3BsbF9zZWxlY3QoKSBoYXMgYW55IGdv
b2QgcmVhc29uIHRvIGV2ZW4gZXhpc3QKPiA+IGFueW1vcmUuIEl0J3MganVzdCBjYWxsaW5nIHRo
aXMgb25lIGZ1bmN0aW9uLCBzbyBtYXliZSB3ZSBzaG91bGQganVzdAo+ID4gY2FsbCBpdCBkaXJl
Y3RseT8KPiAKPiBZb3UncmUgcmlnaHQgaGVyZS4gVGhlbiB0aGUgdHdvIGNhbGxlcnMgd291bGQg
YmUKPiBoYXN3ZWxsX2NydGNfY29tcHV0ZV9jbG9jaygpIGFuZCBpcm9ubGFrZV9jcnRjX2NvbXB1
dGVfY2xvY2soKSwgd2hpY2gKPiBtYWtlcyBldmVuIG1vcmUgc2VuZS4gSSdsbCBzdWJtaXQgYW5v
dGhlciBwYXRjaC4KPiAKPiA+IAo+ID4gPiAKPiA+ID4gKwlpZiAoIXBsbCkKPiA+ID4gKwkJRFJN
X0RFQlVHX0RSSVZFUigiZmFpbGVkIHRvIGZpbmQgUExMIGZvciBwaXBlCj4gPiA+ICVjXG4iLAo+
ID4gPiArCQkJCcKgwqBwaXBlX25hbWUoaW50ZWxfY3J0Yy0+cGlwZSkpOwo+ID4gPiArCj4gPiA+
ICsJcmV0dXJuIHBsbDsKPiA+IAo+ID4gSSB3b3VsZCBwcm9iYWJseSB3cml0ZSAncGxsICE9IE5V
TEwnIGZvciBhIGJpdCBvZiBleHRyYSBjbGFyaXR5Lgo+IAo+IEFyZSB5b3UgdGFsa2luZyBhYm91
dCB0aGUgcmV0dXJuIHN0YXRlbWVudCBvciB0aGUgaWYgY29uZGl0aW9uPwoKVGhlIHJldHVybi4K
Cj4gCj4gSSdsbCBhc3N1bWUgeW91J3JlIHRhbGtpbmcgYWJvdXQgdGhlIHJldHVybiBzdGF0ZW1l
bnQuIEkgY2FuIGZpeCB0aGlzLgo+IEFub3RoZXIgdGhpbmcgd291bGQgYmUgInJldHVybiAhIXBs
bCIuIEknbSBmaW5lIHdpdGggYWxsIGFwcHJvYWNoZXMuCgpGb3Igd2hhdGV2ZXIgcmVhc29uIEkn
dmUgc3RhcnRlZCB0byBwcmVmZXIgIT1OVUxMIHR5cGUgb2Ygc3R1ZmYuCk5vdCByZWFsbHkgc3Vy
ZSB3aHkgc2luY2UgSSB1c2VkIHRvIGRpc2xpa2UgaXQgd2hlbiBJIHdhcyB5b3VuZ2VyLgoKPiAK
PiA+IAo+ID4gRWl0aGVyIHdheQo+ID4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls
bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gVGhhbmtzIQo+IAo+ID4gCj4gPiA+IAo+
ID4gPiDCoH0KPiA+ID4gwqAKPiA+ID4gwqB2b2lkIGludGVsX2RkaV9zZXRfcGlwZV9zZXR0aW5n
cyhjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZQo+ID4gPiAqY3J0Y19zdGF0ZSkKPiA+ID4g
LS3CoAo+ID4gPiAyLjcuNAo+ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPiBJ
bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPiAKCi0tIApWaWxsZSBTeXJq
w6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs
LWdmeAo=