From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/3] drm/i915: Use LINEAR modifier instead
	of NONE
Date: Wed, 29 Mar 2017 23:03:40 +0300
Message-ID: <20170329200340.GB30290@intel.com>
References: <20170324212950.2206-1-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20170324212950.2206-1-ben@bwidawsk.net>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBNYXIgMjQsIDIwMTcgYXQgMDI6Mjk6NDhQTSAtMDcwMCwgQmVuIFdpZGF3c2t5IHdy
b3RlOgo+IFRoZXkncmUgdGhlIHNhbWUsIHNvIHVzZSB0aGUgb25lIHdoaWNoIG1ha2VzIG1vcmUg
c2Vuc2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogQmVuIFdpZGF3c2t5IDxiZW5AYndpZGF3c2submV0
PgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl
bC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAy
OCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl
cnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz
cGxheS5jCj4gaW5kZXggOWEyOGE4OTE3ZGMxLi42OTZkMTA2NDYxZjggMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTE5OTcsNyArMTk5Nyw3IEBAIGludGVsX3Rp
bGVfd2lkdGhfYnl0ZXMoY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsIGludCBwbGFu
ZSkKPiAgCXVuc2lnbmVkIGludCBjcHAgPSBmYi0+Zm9ybWF0LT5jcHBbcGxhbmVdOwo+ICAKPiAg
CXN3aXRjaCAoZmItPm1vZGlmaWVyKSB7Cj4gLQljYXNlIERSTV9GT1JNQVRfTU9EX05PTkU6Cj4g
KwljYXNlIERSTV9GT1JNQVRfTU9EX0xJTkVBUjoKPiAgCQlyZXR1cm4gY3BwOwo+ICAJY2FzZSBJ
OTE1X0ZPUk1BVF9NT0RfWF9USUxFRDoKPiAgCQlpZiAoSVNfR0VOMihkZXZfcHJpdikpCj4gQEAg
LTIwMzMsNyArMjAzMyw3IEBAIGludGVsX3RpbGVfd2lkdGhfYnl0ZXMoY29uc3Qgc3RydWN0IGRy
bV9mcmFtZWJ1ZmZlciAqZmIsIGludCBwbGFuZSkKPiAgc3RhdGljIHVuc2lnbmVkIGludAo+ICBp
bnRlbF90aWxlX2hlaWdodChjb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwgaW50IHBs
YW5lKQo+ICB7Cj4gLQlpZiAoZmItPm1vZGlmaWVyID09IERSTV9GT1JNQVRfTU9EX05PTkUpCj4g
KwlpZiAoZmItPm1vZGlmaWVyID09IERSTV9GT1JNQVRfTU9EX0xJTkVBUikKPiAgCQlyZXR1cm4g
MTsKPiAgCWVsc2UKPiAgCQlyZXR1cm4gaW50ZWxfdGlsZV9zaXplKHRvX2k5MTUoZmItPmRldikp
IC8KPiBAQCAtMjEwNyw3ICsyMTA3LDcgQEAgc3RhdGljIHVuc2lnbmVkIGludCBpbnRlbF9zdXJm
X2FsaWdubWVudChjb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwKPiAgCQlyZXR1cm4g
NDA5NjsKPiAgCj4gIAlzd2l0Y2ggKGZiLT5tb2RpZmllcikgewo+IC0JY2FzZSBEUk1fRk9STUFU
X01PRF9OT05FOgo+ICsJY2FzZSBEUk1fRk9STUFUX01PRF9MSU5FQVI6Cj4gIAkJcmV0dXJuIGlu
dGVsX2xpbmVhcl9hbGlnbm1lbnQoZGV2X3ByaXYpOwo+ICAJY2FzZSBJOTE1X0ZPUk1BVF9NT0Rf
WF9USUxFRDoKPiAgCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+IEBAIC0yMjkwLDcg
KzIyOTAsNyBAQCBzdGF0aWMgdTMyIGludGVsX2FkanVzdF90aWxlX29mZnNldChpbnQgKngsIGlu
dCAqeSwKPiAgCj4gIAlXQVJOX09OKG5ld19vZmZzZXQgPiBvbGRfb2Zmc2V0KTsKPiAgCj4gLQlp
ZiAoZmItPm1vZGlmaWVyICE9IERSTV9GT1JNQVRfTU9EX05PTkUpIHsKPiArCWlmIChmYi0+bW9k
aWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSKSB7Cj4gIAkJdW5zaWduZWQgaW50IHRpbGVf
c2l6ZSwgdGlsZV93aWR0aCwgdGlsZV9oZWlnaHQ7Cj4gIAkJdW5zaWduZWQgaW50IHBpdGNoX3Rp
bGVzOwo+ICAKPiBAQCAtMjM0NSw3ICsyMzQ1LDcgQEAgc3RhdGljIHUzMiBfaW50ZWxfY29tcHV0
ZV90aWxlX29mZnNldChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
IAlpZiAoYWxpZ25tZW50KQo+ICAJCWFsaWdubWVudC0tOwo+ICAKPiAtCWlmIChmYl9tb2RpZmll
ciAhPSBEUk1fRk9STUFUX01PRF9OT05FKSB7Cj4gKwlpZiAoZmJfbW9kaWZpZXIgIT0gRFJNX0ZP
Uk1BVF9NT0RfTElORUFSKSB7Cj4gIAkJdW5zaWduZWQgaW50IHRpbGVfc2l6ZSwgdGlsZV93aWR0
aCwgdGlsZV9oZWlnaHQ7Cj4gIAkJdW5zaWduZWQgaW50IHRpbGVfcm93cywgdGlsZXMsIHBpdGNo
X3RpbGVzOwo+ICAKPiBAQCAtMjQ3MSw3ICsyNDcxLDcgQEAgaW50ZWxfZmlsbF9mYl9pbmZvKHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJCQkJICAgIERSTV9ST1RBVEVf
MCwgdGlsZV9zaXplKTsKPiAgCQlvZmZzZXQgLz0gdGlsZV9zaXplOwo+ICAKPiAtCQlpZiAoZmIt
Pm1vZGlmaWVyICE9IERSTV9GT1JNQVRfTU9EX05PTkUpIHsKPiArCQlpZiAoZmItPm1vZGlmaWVy
ICE9IERSTV9GT1JNQVRfTU9EX0xJTkVBUikgewo+ICAJCQl1bnNpZ25lZCBpbnQgdGlsZV93aWR0
aCwgdGlsZV9oZWlnaHQ7Cj4gIAkJCXVuc2lnbmVkIGludCBwaXRjaF90aWxlczsKPiAgCQkJc3Ry
dWN0IGRybV9yZWN0IHI7Cj4gQEAgLTI4MDMsNyArMjgwMyw3IEBAIHN0YXRpYyBpbnQgc2tsX21h
eF9wbGFuZV93aWR0aChjb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwgaW50IHBsYW5l
LAo+ICAJaW50IGNwcCA9IGZiLT5mb3JtYXQtPmNwcFtwbGFuZV07Cj4gIAo+ICAJc3dpdGNoIChm
Yi0+bW9kaWZpZXIpIHsKPiAtCWNhc2UgRFJNX0ZPUk1BVF9NT0RfTk9ORToKPiArCWNhc2UgRFJN
X0ZPUk1BVF9NT0RfTElORUFSOgo+ICAJY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRDoKPiAg
CQlzd2l0Y2ggKGNwcCkgewo+ICAJCWNhc2UgODoKPiBAQCAtMzE5OSw3ICszMTk5LDcgQEAgc3Rh
dGljIHZvaWQgaXJvbmxha2VfdXBkYXRlX3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAq
cHJpbWFyeSwKPiAgc3RhdGljIHUzMgo+ICBpbnRlbF9mYl9zdHJpZGVfYWxpZ25tZW50KGNvbnN0
IHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLCBpbnQgcGxhbmUpCj4gIHsKPiAtCWlmIChmYi0+
bW9kaWZpZXIgPT0gRFJNX0ZPUk1BVF9NT0RfTk9ORSkKPiArCWlmIChmYi0+bW9kaWZpZXIgPT0g
RFJNX0ZPUk1BVF9NT0RfTElORUFSKQo+ICAJCXJldHVybiA2NDsKPiAgCWVsc2UKPiAgCQlyZXR1
cm4gaW50ZWxfdGlsZV93aWR0aF9ieXRlcyhmYiwgcGxhbmUpOwo+IEBAIC0zMjk4LDcgKzMyOTgs
NyBAQCBzdGF0aWMgdTMyIHNrbF9wbGFuZV9jdGxfZm9ybWF0KHVpbnQzMl90IHBpeGVsX2Zvcm1h
dCkKPiAgc3RhdGljIHUzMiBza2xfcGxhbmVfY3RsX3RpbGluZyh1aW50NjRfdCBmYl9tb2RpZmll
cikKPiAgewo+ICAJc3dpdGNoIChmYl9tb2RpZmllcikgewo+IC0JY2FzZSBEUk1fRk9STUFUX01P
RF9OT05FOgo+ICsJY2FzZSBEUk1fRk9STUFUX01PRF9MSU5FQVI6Cj4gIAkJYnJlYWs7Cj4gIAlj
YXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+ICAJCXJldHVybiBQTEFORV9DVExfVElMRURf
WDsKPiBAQCAtODQyNiw3ICs4NDI2LDcgQEAgc2t5bGFrZV9nZXRfaW5pdGlhbF9wbGFuZV9jb25m
aWcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAl0aWxpbmcgPSB2YWwgJiBQTEFORV9DVExf
VElMRURfTUFTSzsKPiAgCXN3aXRjaCAodGlsaW5nKSB7Cj4gIAljYXNlIFBMQU5FX0NUTF9USUxF
RF9MSU5FQVI6Cj4gLQkJZmItPm1vZGlmaWVyID0gRFJNX0ZPUk1BVF9NT0RfTk9ORTsKPiArCQlm
Yi0+bW9kaWZpZXIgPSBEUk1fRk9STUFUX01PRF9MSU5FQVI7Cj4gIAkJYnJlYWs7Cj4gIAljYXNl
IFBMQU5FX0NUTF9USUxFRF9YOgo+ICAJCXBsYW5lX2NvbmZpZy0+dGlsaW5nID0gSTkxNV9USUxJ
TkdfWDsKPiBAQCAtMTAzOTksNyArMTAzOTksNyBAQCBzdGF0aWMgdm9pZCBza2xfZG9fbW1pb19m
bGlwKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ICAJY3RsID0gSTkxNV9SRUFEKFBM
QU5FX0NUTChwaXBlLCAwKSk7Cj4gIAljdGwgJj0gflBMQU5FX0NUTF9USUxFRF9NQVNLOwo+ICAJ
c3dpdGNoIChmYi0+bW9kaWZpZXIpIHsKPiAtCWNhc2UgRFJNX0ZPUk1BVF9NT0RfTk9ORToKPiAr
CWNhc2UgRFJNX0ZPUk1BVF9NT0RfTElORUFSOgo+ICAJCWJyZWFrOwo+ICAJY2FzZSBJOTE1X0ZP
Uk1BVF9NT0RfWF9USUxFRDoKPiAgCQljdGwgfD0gUExBTkVfQ1RMX1RJTEVEX1g7Cj4gQEAgLTEz
NzU2LDcgKzEzNzU2LDcgQEAgaW50ZWxfY2hlY2tfY3Vyc29yX3BsYW5lKHN0cnVjdCBkcm1fcGxh
bmUgKnBsYW5lLAo+ICAJCXJldHVybiAtRU5PTUVNOwo+ICAJfQo+ICAKPiAtCWlmIChmYi0+bW9k
aWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTk9ORSkgewo+ICsJaWYgKGZiLT5tb2RpZmllciAhPSBE
Uk1fRk9STUFUX01PRF9MSU5FQVIpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJjdXJzb3IgY2Fubm90
IGJlIHRpbGVkXG4iKTsKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiBAQCAtMTQ0MTIsNyAr
MTQ0MTIsNyBAQCBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVs
X2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKPiAgCQkJCSAgICAgIG1vZGVfY21kLT5tb2RpZmllclsw
XSk7Cj4gIAkJCWdvdG8gZXJyOwo+ICAJCX0KPiAtCWNhc2UgRFJNX0ZPUk1BVF9NT0RfTk9ORToK
PiArCWNhc2UgRFJNX0ZPUk1BVF9NT0RfTElORUFSOgo+ICAJY2FzZSBJOTE1X0ZPUk1BVF9NT0Rf
WF9USUxFRDoKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gQEAgLTE0NDM1LDcgKzE0NDM1LDcg
QEAgc3RhdGljIGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBpbnRlbF9mcmFtZWJ1
ZmZlciAqaW50ZWxfZmIsCj4gIAkJCQkJICAgbW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCk7Cj4gIAlp
ZiAobW9kZV9jbWQtPnBpdGNoZXNbMF0gPiBwaXRjaF9saW1pdCkgewo+ICAJCURSTV9ERUJVR19L
TVMoIiVzIHBpdGNoICgldSkgbXVzdCBiZSBhdCBtb3N0ICVkXG4iLAo+IC0JCQkgICAgICBtb2Rl
X2NtZC0+bW9kaWZpZXJbMF0gIT0gRFJNX0ZPUk1BVF9NT0RfTk9ORSA/Cj4gKwkJCSAgICAgIG1v
ZGVfY21kLT5tb2RpZmllclswXSAhPSBEUk1fRk9STUFUX01PRF9MSU5FQVIgPwo+ICAJCQkgICAg
ICAidGlsZWQiIDogImxpbmVhciIsCj4gIAkJCSAgICAgIG1vZGVfY21kLT5waXRjaGVzWzBdLCBw
aXRjaF9saW1pdCk7Cj4gIAkJZ290byBlcnI7Cj4gLS0gCj4gMi4xMi4xCj4gCj4gX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGlu
ZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3ly
asOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK