From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/3] drm/i915: Use LINEAR modifier instead
 of NONE
Date: Wed, 29 Mar 2017 23:28:44 +0300
Message-ID: <20170329202844.GD30290@intel.com>
References: <20170324212950.2206-1-ben@bwidawsk.net>
 <20170329200340.GB30290@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20170329200340.GB30290@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBNYXIgMjksIDIwMTcgYXQgMTE6MDM6NDBQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk
IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDI0LCAyMDE3IGF0IDAyOjI5OjQ4UE0gLTA3MDAsIEJlbiBX
aWRhd3NreSB3cm90ZToKPiA+IFRoZXkncmUgdGhlIHNhbWUsIHNvIHVzZSB0aGUgb25lIHdoaWNo
IG1ha2VzIG1vcmUgc2Vuc2UuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEJlbiBXaWRhd3NreSA8
YmVuQGJ3aWRhd3NrLm5ldD4KPiAKPiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs
ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCkFuZCBwdXNoZWQgdG8gZGlucSBpbW1lZGlhdGVs
eS4gVGhhbmtzIGZvciB0aGUgcGF0Y2guCgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMjggKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+
ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiA+
IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggOWEyOGE4OTE3
ZGMxLi42OTZkMTA2NDYxZjggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs
YXkuYwo+ID4gQEAgLTE5OTcsNyArMTk5Nyw3IEBAIGludGVsX3RpbGVfd2lkdGhfYnl0ZXMoY29u
c3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsIGludCBwbGFuZSkKPiA+ICAJdW5zaWduZWQg
aW50IGNwcCA9IGZiLT5mb3JtYXQtPmNwcFtwbGFuZV07Cj4gPiAgCj4gPiAgCXN3aXRjaCAoZmIt
Pm1vZGlmaWVyKSB7Cj4gPiAtCWNhc2UgRFJNX0ZPUk1BVF9NT0RfTk9ORToKPiA+ICsJY2FzZSBE
Uk1fRk9STUFUX01PRF9MSU5FQVI6Cj4gPiAgCQlyZXR1cm4gY3BwOwo+ID4gIAljYXNlIEk5MTVf
Rk9STUFUX01PRF9YX1RJTEVEOgo+ID4gIAkJaWYgKElTX0dFTjIoZGV2X3ByaXYpKQo+ID4gQEAg
LTIwMzMsNyArMjAzMyw3IEBAIGludGVsX3RpbGVfd2lkdGhfYnl0ZXMoY29uc3Qgc3RydWN0IGRy
bV9mcmFtZWJ1ZmZlciAqZmIsIGludCBwbGFuZSkKPiA+ICBzdGF0aWMgdW5zaWduZWQgaW50Cj4g
PiAgaW50ZWxfdGlsZV9oZWlnaHQoY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsIGlu
dCBwbGFuZSkKPiA+ICB7Cj4gPiAtCWlmIChmYi0+bW9kaWZpZXIgPT0gRFJNX0ZPUk1BVF9NT0Rf
Tk9ORSkKPiA+ICsJaWYgKGZiLT5tb2RpZmllciA9PSBEUk1fRk9STUFUX01PRF9MSU5FQVIpCj4g
PiAgCQlyZXR1cm4gMTsKPiA+ICAJZWxzZQo+ID4gIAkJcmV0dXJuIGludGVsX3RpbGVfc2l6ZSh0
b19pOTE1KGZiLT5kZXYpKSAvCj4gPiBAQCAtMjEwNyw3ICsyMTA3LDcgQEAgc3RhdGljIHVuc2ln
bmVkIGludCBpbnRlbF9zdXJmX2FsaWdubWVudChjb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVy
ICpmYiwKPiA+ICAJCXJldHVybiA0MDk2Owo+ID4gIAo+ID4gIAlzd2l0Y2ggKGZiLT5tb2RpZmll
cikgewo+ID4gLQljYXNlIERSTV9GT1JNQVRfTU9EX05PTkU6Cj4gPiArCWNhc2UgRFJNX0ZPUk1B
VF9NT0RfTElORUFSOgo+ID4gIAkJcmV0dXJuIGludGVsX2xpbmVhcl9hbGlnbm1lbnQoZGV2X3By
aXYpOwo+ID4gIAljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+ID4gIAkJaWYgKElOVEVM
X0dFTihkZXZfcHJpdikgPj0gOSkKPiA+IEBAIC0yMjkwLDcgKzIyOTAsNyBAQCBzdGF0aWMgdTMy
IGludGVsX2FkanVzdF90aWxlX29mZnNldChpbnQgKngsIGludCAqeSwKPiA+ICAKPiA+ICAJV0FS
Tl9PTihuZXdfb2Zmc2V0ID4gb2xkX29mZnNldCk7Cj4gPiAgCj4gPiAtCWlmIChmYi0+bW9kaWZp
ZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTk9ORSkgewo+ID4gKwlpZiAoZmItPm1vZGlmaWVyICE9IERS
TV9GT1JNQVRfTU9EX0xJTkVBUikgewo+ID4gIAkJdW5zaWduZWQgaW50IHRpbGVfc2l6ZSwgdGls
ZV93aWR0aCwgdGlsZV9oZWlnaHQ7Cj4gPiAgCQl1bnNpZ25lZCBpbnQgcGl0Y2hfdGlsZXM7Cj4g
PiAgCj4gPiBAQCAtMjM0NSw3ICsyMzQ1LDcgQEAgc3RhdGljIHUzMiBfaW50ZWxfY29tcHV0ZV90
aWxlX29mZnNldChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAg
CWlmIChhbGlnbm1lbnQpCj4gPiAgCQlhbGlnbm1lbnQtLTsKPiA+ICAKPiA+IC0JaWYgKGZiX21v
ZGlmaWVyICE9IERSTV9GT1JNQVRfTU9EX05PTkUpIHsKPiA+ICsJaWYgKGZiX21vZGlmaWVyICE9
IERSTV9GT1JNQVRfTU9EX0xJTkVBUikgewo+ID4gIAkJdW5zaWduZWQgaW50IHRpbGVfc2l6ZSwg
dGlsZV93aWR0aCwgdGlsZV9oZWlnaHQ7Cj4gPiAgCQl1bnNpZ25lZCBpbnQgdGlsZV9yb3dzLCB0
aWxlcywgcGl0Y2hfdGlsZXM7Cj4gPiAgCj4gPiBAQCAtMjQ3MSw3ICsyNDcxLDcgQEAgaW50ZWxf
ZmlsbF9mYl9pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCQkJ
CQkgICAgRFJNX1JPVEFURV8wLCB0aWxlX3NpemUpOwo+ID4gIAkJb2Zmc2V0IC89IHRpbGVfc2l6
ZTsKPiA+ICAKPiA+IC0JCWlmIChmYi0+bW9kaWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTk9ORSkg
ewo+ID4gKwkJaWYgKGZiLT5tb2RpZmllciAhPSBEUk1fRk9STUFUX01PRF9MSU5FQVIpIHsKPiA+
ICAJCQl1bnNpZ25lZCBpbnQgdGlsZV93aWR0aCwgdGlsZV9oZWlnaHQ7Cj4gPiAgCQkJdW5zaWdu
ZWQgaW50IHBpdGNoX3RpbGVzOwo+ID4gIAkJCXN0cnVjdCBkcm1fcmVjdCByOwo+ID4gQEAgLTI4
MDMsNyArMjgwMyw3IEBAIHN0YXRpYyBpbnQgc2tsX21heF9wbGFuZV93aWR0aChjb25zdCBzdHJ1
Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwgaW50IHBsYW5lLAo+ID4gIAlpbnQgY3BwID0gZmItPmZv
cm1hdC0+Y3BwW3BsYW5lXTsKPiA+ICAKPiA+ICAJc3dpdGNoIChmYi0+bW9kaWZpZXIpIHsKPiA+
IC0JY2FzZSBEUk1fRk9STUFUX01PRF9OT05FOgo+ID4gKwljYXNlIERSTV9GT1JNQVRfTU9EX0xJ
TkVBUjoKPiA+ICAJY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRDoKPiA+ICAJCXN3aXRjaCAo
Y3BwKSB7Cj4gPiAgCQljYXNlIDg6Cj4gPiBAQCAtMzE5OSw3ICszMTk5LDcgQEAgc3RhdGljIHZv
aWQgaXJvbmxha2VfdXBkYXRlX3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqcHJpbWFy
eSwKPiA+ICBzdGF0aWMgdTMyCj4gPiAgaW50ZWxfZmJfc3RyaWRlX2FsaWdubWVudChjb25zdCBz
dHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiwgaW50IHBsYW5lKQo+ID4gIHsKPiA+IC0JaWYgKGZi
LT5tb2RpZmllciA9PSBEUk1fRk9STUFUX01PRF9OT05FKQo+ID4gKwlpZiAoZmItPm1vZGlmaWVy
ID09IERSTV9GT1JNQVRfTU9EX0xJTkVBUikKPiA+ICAJCXJldHVybiA2NDsKPiA+ICAJZWxzZQo+
ID4gIAkJcmV0dXJuIGludGVsX3RpbGVfd2lkdGhfYnl0ZXMoZmIsIHBsYW5lKTsKPiA+IEBAIC0z
Mjk4LDcgKzMyOTgsNyBAQCBzdGF0aWMgdTMyIHNrbF9wbGFuZV9jdGxfZm9ybWF0KHVpbnQzMl90
IHBpeGVsX2Zvcm1hdCkKPiA+ICBzdGF0aWMgdTMyIHNrbF9wbGFuZV9jdGxfdGlsaW5nKHVpbnQ2
NF90IGZiX21vZGlmaWVyKQo+ID4gIHsKPiA+ICAJc3dpdGNoIChmYl9tb2RpZmllcikgewo+ID4g
LQljYXNlIERSTV9GT1JNQVRfTU9EX05PTkU6Cj4gPiArCWNhc2UgRFJNX0ZPUk1BVF9NT0RfTElO
RUFSOgo+ID4gIAkJYnJlYWs7Cj4gPiAgCWNhc2UgSTkxNV9GT1JNQVRfTU9EX1hfVElMRUQ6Cj4g
PiAgCQlyZXR1cm4gUExBTkVfQ1RMX1RJTEVEX1g7Cj4gPiBAQCAtODQyNiw3ICs4NDI2LDcgQEAg
c2t5bGFrZV9nZXRfaW5pdGlhbF9wbGFuZV9jb25maWcoc3RydWN0IGludGVsX2NydGMgKmNydGMs
Cj4gPiAgCXRpbGluZyA9IHZhbCAmIFBMQU5FX0NUTF9USUxFRF9NQVNLOwo+ID4gIAlzd2l0Y2gg
KHRpbGluZykgewo+ID4gIAljYXNlIFBMQU5FX0NUTF9USUxFRF9MSU5FQVI6Cj4gPiAtCQlmYi0+
bW9kaWZpZXIgPSBEUk1fRk9STUFUX01PRF9OT05FOwo+ID4gKwkJZmItPm1vZGlmaWVyID0gRFJN
X0ZPUk1BVF9NT0RfTElORUFSOwo+ID4gIAkJYnJlYWs7Cj4gPiAgCWNhc2UgUExBTkVfQ1RMX1RJ
TEVEX1g6Cj4gPiAgCQlwbGFuZV9jb25maWctPnRpbGluZyA9IEk5MTVfVElMSU5HX1g7Cj4gPiBA
QCAtMTAzOTksNyArMTAzOTksNyBAQCBzdGF0aWMgdm9pZCBza2xfZG9fbW1pb19mbGlwKHN0cnVj
dCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+ID4gIAljdGwgPSBJOTE1X1JFQUQoUExBTkVfQ1RM
KHBpcGUsIDApKTsKPiA+ICAJY3RsICY9IH5QTEFORV9DVExfVElMRURfTUFTSzsKPiA+ICAJc3dp
dGNoIChmYi0+bW9kaWZpZXIpIHsKPiA+IC0JY2FzZSBEUk1fRk9STUFUX01PRF9OT05FOgo+ID4g
KwljYXNlIERSTV9GT1JNQVRfTU9EX0xJTkVBUjoKPiA+ICAJCWJyZWFrOwo+ID4gIAljYXNlIEk5
MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+ID4gIAkJY3RsIHw9IFBMQU5FX0NUTF9USUxFRF9YOwo+
ID4gQEAgLTEzNzU2LDcgKzEzNzU2LDcgQEAgaW50ZWxfY2hlY2tfY3Vyc29yX3BsYW5lKHN0cnVj
dCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gPiAgCX0KPiA+ICAK
PiA+IC0JaWYgKGZiLT5tb2RpZmllciAhPSBEUk1fRk9STUFUX01PRF9OT05FKSB7Cj4gPiArCWlm
IChmYi0+bW9kaWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSKSB7Cj4gPiAgCQlEUk1fREVC
VUdfS01TKCJjdXJzb3IgY2Fubm90IGJlIHRpbGVkXG4iKTsKPiA+ICAJCXJldHVybiAtRUlOVkFM
Owo+ID4gIAl9Cj4gPiBAQCAtMTQ0MTIsNyArMTQ0MTIsNyBAQCBzdGF0aWMgaW50IGludGVsX2Zy
YW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKPiA+ICAJ
CQkJICAgICAgbW9kZV9jbWQtPm1vZGlmaWVyWzBdKTsKPiA+ICAJCQlnb3RvIGVycjsKPiA+ICAJ
CX0KPiA+IC0JY2FzZSBEUk1fRk9STUFUX01PRF9OT05FOgo+ID4gKwljYXNlIERSTV9GT1JNQVRf
TU9EX0xJTkVBUjoKPiA+ICAJY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRDoKPiA+ICAJCWJy
ZWFrOwo+ID4gIAlkZWZhdWx0Ogo+ID4gQEAgLTE0NDM1LDcgKzE0NDM1LDcgQEAgc3RhdGljIGlu
dCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50ZWxf
ZmIsCj4gPiAgCQkJCQkgICBtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0KTsKPiA+ICAJaWYgKG1vZGVf
Y21kLT5waXRjaGVzWzBdID4gcGl0Y2hfbGltaXQpIHsKPiA+ICAJCURSTV9ERUJVR19LTVMoIiVz
IHBpdGNoICgldSkgbXVzdCBiZSBhdCBtb3N0ICVkXG4iLAo+ID4gLQkJCSAgICAgIG1vZGVfY21k
LT5tb2RpZmllclswXSAhPSBEUk1fRk9STUFUX01PRF9OT05FID8KPiA+ICsJCQkgICAgICBtb2Rl
X2NtZC0+bW9kaWZpZXJbMF0gIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSID8KPiA+ICAJCQkgICAg
ICAidGlsZWQiIDogImxpbmVhciIsCj4gPiAgCQkJICAgICAgbW9kZV9jbWQtPnBpdGNoZXNbMF0s
IHBpdGNoX2xpbWl0KTsKPiA+ICAJCWdvdG8gZXJyOwo+ID4gLS0gCj4gPiAyLjEyLjEKPiA+IAo+
ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGRy
aS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
PiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl
dmVsCj4gCj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RDCj4gX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs
aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOk
bMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v
cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngK