From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/8] drm/i915/dp: Check error return during
 DPCD capability queries
Date: Wed, 26 Apr 2017 18:08:24 +0300
Message-ID: <20170426150824.GZ30290@intel.com>
References: <1493214013-15580-1-git-send-email-imre.deak@intel.com>
 <1493214013-15580-3-git-send-email-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E203A6E455
 for <intel-gfx@lists.freedesktop.org>; Wed, 26 Apr 2017 15:08:27 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1493214013-15580-3-git-send-email-imre.deak@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBBcHIgMjYsIDIwMTcgYXQgMDQ6NDA6MDdQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl
Ogo+IFRoZSBhc3N1bXB0aW9ucyBvZiB0aGVzZSB1c2VycyBvZiBkcm1fZHBfZHBjZF9yZWFkYigp
IGlzIHRoYXQgdGhlIHBhc3NlZAo+IGluIG91dHB1dCBidWZmZXIgd29uJ3QgY2hhbmdlIGluIGNh
c2Ugb2YgZXJyb3IsIGJ1dCB0aGlzIGlzbid0Cj4gZ3VhcmFudGVlZC4KCkhtbS4gV2UgYmxpbmRs
eSBjb3B5IGFzIG1hbnkgYnl0ZXMgZnJvbSB0aGUgcnhidWYgaW50byB0aGUgdXNlcgpwcm92aWRl
ZCBidWZmZXIgYXMgdGhlIGhhcmR3YXJlIHRvbGQgdXMgdG8uIEFuZCB3aGV0aGVyIHRoZSB0cmFu
c2ZlcgphY3R1YWxseSBpcyBjb25zaWRlcmVkIGEgc3VjY2VzcyBvciBub3QgZGVwZW5kcyBvbiB3
aGF0IHRoZSBmaXJzdApyZWNlaXZlZCBieXRlIHNheXMuIEkgZG9uJ3QgcmVjYWxsIHdoYXQgdGhl
IERQIHNwZWMgcmVhbGx5IHNheXMgYWJvdXQKcmVwbHlpbmcgd2l0aCBtb3JlIHRoYW4gb25lIGJ5
dGUgb24gZmFpbHVyZSwgYnV0IEkgZ3Vlc3Mgd2Ugc2hvdWxkbid0CmRlcGVuZCBvbiBpdCBhbnl3
YXkuCgpXZSBjb3VsZCBhY3R1YWxseSBtYWtlIHRoYXQgZ3VhcmFudGVlIGlmIHdlIG1vdmVkIHR4
YnVmK3J4YnVmIHVwCmludG8gZHJtX2RwX2RwY2RfYWNjZXNzKCkgYW5kIGRpZCB0aGUgY29weSB0
byB0aGUgdXNlciBidWZmZXIKb25seSBvbiBzdWNjZXMuIEJ1dCB0aGF0IHdvdWxkIHJlcXVpcmUg
Y2hhbmdpbmcgYWxsIHRoZSBEUApjYXBhYmxlIGRyaXZlcnMgYXQgdGhlIHNhbWUgdGltZSwgc28g
d291bGQgcmVxdWlyZSBzb21lb25lCm1vdGl2YXRlZCBlbm91Z2guCgpJbiB0aGUgbWVhbnRpbWUK
UmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j
b20+Cgo+IEZpeCB0aGlzIGJ5IHRyZWF0aW5nIGFueSBlcnJvciBhcyB0aGUgbGFjayBvZiB0aGUg
Z2l2ZW4KPiBjYXBhYmlsaXR5Lgo+IAo+IEluIGNhc2Ugb2YgRFBfU0lOS19ERVZJQ0VfQVVYX0ZS
QU1FX1NZTkNfQ0FQIGFuIGVycm9yIHdvdWxkIGxlYXZlIHRoZQo+IGJ1ZmZlciB1bmluaXRpYWxp
emVkIGV2ZW4gd2l0aCB0aGUgYWJvdmUgYXNzdW1wdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBJ
bXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2RwLmMgfCAyMCArKysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl
ZCwgMTIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2RwLmMKPiBpbmRleCAwODgzNGY3Li40YTZmZWI2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
cC5jCj4gQEAgLTMwODgsNyArMzA4OCw4IEBAIHN0YXRpYyBib29sIGludGVsX2RwX2dldF95X2Nv
cmRfc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHsKPiAgCXVpbnQ4X3QgcHNy
X2NhcHMgPSAwOwo+ICAKPiAtCWRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9Q
U1JfQ0FQUywgJnBzcl9jYXBzKTsKPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAt
PmF1eCwgRFBfUFNSX0NBUFMsICZwc3JfY2FwcykgIT0gMSkKPiArCQlyZXR1cm4gZmFsc2U7Cj4g
IAlyZXR1cm4gcHNyX2NhcHMgJiBEUF9QU1IyX1NVX1lfQ09PUkRJTkFURV9SRVFVSVJFRDsKPiAg
fQo+ICAKPiBAQCAtMzA5Niw5ICszMDk3LDkgQEAgc3RhdGljIGJvb2wgaW50ZWxfZHBfZ2V0X2Nv
bG9yaW1ldHJ5X3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICB7Cj4gIAl1aW50
OF90IGRwcnggPSAwOwo+ICAKPiAtCWRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LAo+
IC0JCQlEUF9EUFJYX0ZFQVRVUkVfRU5VTUVSQVRJT05fTElTVCwKPiAtCQkJJmRwcngpOwo+ICsJ
aWYgKGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9EUFJYX0ZFQVRVUkVfRU5V
TUVSQVRJT05fTElTVCwKPiArCQkJICAgICAgJmRwcngpICE9IDEpCj4gKwkJcmV0dXJuIGZhbHNl
Owo+ICAJcmV0dXJuIGRwcnggJiBEUF9WU0NfU0RQX0VYVF9GT1JfQ09MT1JJTUVUUllfU1VQUE9S
VEVEOwo+ICB9Cj4gIAo+IEBAIC0zMTA2LDcgKzMxMDcsOSBAQCBzdGF0aWMgYm9vbCBpbnRlbF9k
cF9nZXRfYWxwbV9zdGF0dXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgewo+ICAJdWlu
dDhfdCBhbHBtX2NhcHMgPSAwOwo+ICAKPiAtCWRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+
YXV4LCBEUF9SRUNFSVZFUl9BTFBNX0NBUCwgJmFscG1fY2Fwcyk7Cj4gKwlpZiAoZHJtX2RwX2Rw
Y2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1JFQ0VJVkVSX0FMUE1fQ0FQLAo+ICsJCQkgICAg
ICAmYWxwbV9jYXBzKSAhPSAxKQo+ICsJCXJldHVybiBmYWxzZTsKPiAgCXJldHVybiBhbHBtX2Nh
cHMgJiBEUF9BTFBNX0NBUDsKPiAgfQo+ICAKPiBAQCAtMzY3OSw5ICszNjgyLDEwIEBAIGludGVs
X2VkcF9pbml0X2RwY2Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQl1aW50OF90IGZy
YW1lX3N5bmNfY2FwOwo+ICAKPiAgCQlkZXZfcHJpdi0+cHNyLnNpbmtfc3VwcG9ydCA9IHRydWU7
Cj4gLQkJZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCj4gLQkJCQkgIERQX1NJTktf
REVWSUNFX0FVWF9GUkFNRV9TWU5DX0NBUCwKPiAtCQkJCSAgJmZyYW1lX3N5bmNfY2FwKTsKPiAr
CQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCj4gKwkJCQkgICAgICBEUF9T
SU5LX0RFVklDRV9BVVhfRlJBTUVfU1lOQ19DQVAsCj4gKwkJCQkgICAgICAmZnJhbWVfc3luY19j
YXApICE9IDEpCj4gKwkJCWZyYW1lX3N5bmNfY2FwID0gMDsKPiAgCQlkZXZfcHJpdi0+cHNyLmF1
eF9mcmFtZV9zeW5jID0gZnJhbWVfc3luY19jYXAgPyB0cnVlIDogZmFsc2U7Cj4gIAkJLyogUFNS
MiBuZWVkcyBmcmFtZSBzeW5jIGFzIHdlbGwgKi8KPiAgCQlkZXZfcHJpdi0+cHNyLnBzcjJfc3Vw
cG9ydCA9IGRldl9wcml2LT5wc3IuYXV4X2ZyYW1lX3N5bmM7Cj4gLS0gCj4gMi41LjAKPiAKPiBf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm
eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApW
aWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeAo=