From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/8] drm/i915/dp: Check error return during
 DPCD capability queries
Date: Wed, 26 Apr 2017 18:30:59 +0300
Message-ID: <20170426153059.GC30290@intel.com>
References: <1493214013-15580-1-git-send-email-imre.deak@intel.com>
 <1493214013-15580-3-git-send-email-imre.deak@intel.com>
 <20170426150824.GZ30290@intel.com>
 <20170426152342.GC15301@ideak-desk.fi.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 665C96E45D
 for <intel-gfx@lists.freedesktop.org>; Wed, 26 Apr 2017 15:31:17 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20170426152342.GC15301@ideak-desk.fi.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBBcHIgMjYsIDIwMTcgYXQgMDY6MjM6NDJQTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl
Ogo+IE9uIFdlZCwgQXByIDI2LCAyMDE3IGF0IDA2OjA4OjI0UE0gKzAzMDAsIFZpbGxlIFN5cmrD
pGzDpCB3cm90ZToKPiA+IE9uIFdlZCwgQXByIDI2LCAyMDE3IGF0IDA0OjQwOjA3UE0gKzAzMDAs
IEltcmUgRGVhayB3cm90ZToKPiA+ID4gVGhlIGFzc3VtcHRpb25zIG9mIHRoZXNlIHVzZXJzIG9m
IGRybV9kcF9kcGNkX3JlYWRiKCkgaXMgdGhhdCB0aGUgcGFzc2VkCj4gPiA+IGluIG91dHB1dCBi
dWZmZXIgd29uJ3QgY2hhbmdlIGluIGNhc2Ugb2YgZXJyb3IsIGJ1dCB0aGlzIGlzbid0Cj4gPiA+
IGd1YXJhbnRlZWQuCj4gPiAKPiA+IEhtbS4gV2UgYmxpbmRseSBjb3B5IGFzIG1hbnkgYnl0ZXMg
ZnJvbSB0aGUgcnhidWYgaW50byB0aGUgdXNlcgo+ID4gcHJvdmlkZWQgYnVmZmVyIGFzIHRoZSBo
YXJkd2FyZSB0b2xkIHVzIHRvLiAKPiAKPiBIYXZlbid0IGNoZWNrZWQgdGhpcywgYnV0IG5vdyBs
b29raW5nIGF0IGl0IGRvZXNuJ3QgdGhlIAo+ICdieXRlcyA+IHJlY3Zfc2l6ZScgY2hlY2sgaW4g
aW50ZWxfZHBfYXV4X2NoKCkgYm91bmQgdGhhdD8KCkhtbS4gUmlnaHQsIHNvIGluIHRoZSBjYXNl
IG9mIG9uZSBieXRlIHJlYWQgd2Ugd2lsbCBzdGlsbCBjb3B5IHRoZQphY3R1YWwgZGF0YSBieXRl
IGFzIHdlbGwsIGlmIHRoZSBoYXJkd2FyZSByZXR1cm5lZCBvbmUuIFNvIGl0IGNvdWxkCnN0aWxs
IGNsb2JiZXIgdGhlIGJ5dGUgd2Ugd291bGQgbGlrZSB0byBwcmVzZXJ2ZS4gSSB0aGluay4KCj4g
Cj4gPiBBbmQgd2hldGhlciB0aGUgdHJhbnNmZXIKPiA+IGFjdHVhbGx5IGlzIGNvbnNpZGVyZWQg
YSBzdWNjZXNzIG9yIG5vdCBkZXBlbmRzIG9uIHdoYXQgdGhlIGZpcnN0Cj4gPiByZWNlaXZlZCBi
eXRlIHNheXMuIEkgZG9uJ3QgcmVjYWxsIHdoYXQgdGhlIERQIHNwZWMgcmVhbGx5IHNheXMgYWJv
dXQKPiA+IHJlcGx5aW5nIHdpdGggbW9yZSB0aGFuIG9uZSBieXRlIG9uIGZhaWx1cmUsIGJ1dCBJ
IGd1ZXNzIHdlIHNob3VsZG4ndAo+ID4gZGVwZW5kIG9uIGl0IGFueXdheS4KPiA+IAo+ID4gV2Ug
Y291bGQgYWN0dWFsbHkgbWFrZSB0aGF0IGd1YXJhbnRlZSBpZiB3ZSBtb3ZlZCB0eGJ1ZityeGJ1
ZiB1cAo+ID4gaW50byBkcm1fZHBfZHBjZF9hY2Nlc3MoKSBhbmQgZGlkIHRoZSBjb3B5IHRvIHRo
ZSB1c2VyIGJ1ZmZlcgo+ID4gb25seSBvbiBzdWNjZXMuIEJ1dCB0aGF0IHdvdWxkIHJlcXVpcmUg
Y2hhbmdpbmcgYWxsIHRoZSBEUAo+ID4gY2FwYWJsZSBkcml2ZXJzIGF0IHRoZSBzYW1lIHRpbWUs
IHNvIHdvdWxkIHJlcXVpcmUgc29tZW9uZQo+ID4gbW90aXZhdGVkIGVub3VnaC4KPiAKPiBPay4g
SSBzdG9wcGVkIGF0IHRoZSBaUjI0dyB3b3JrYXJvdW5kIGluIGRybV9kcF9kcGNkX3JlYWQoKS4u
IEJ1dCB0aGF0Cj4gY291bGQgYWxzbyBiZSB1c2VkIHdpdGggYSBzZXBhcmF0ZSBidWZmZXIuIElu
IGFueSBjYXNlIEkgdGhvdWdodCB0aGF0Cj4gZXZlbiB3aXRoIHRoZSBndWFyYW50ZWUgdGhhdCB0
aGUgYnVmZmVyIGRvZXNuJ3QgY2hhbmdlIC0gd2hpY2ggaXMgaW4KPiBnZW5lcmFsIGEgcmVhc29u
YWJsZSBhc3N1bXB0aW9uIC0gY2hlY2tpbmcgZm9yIHRoZSBlcnJvciByZXR1cm4gd291bGQKPiBi
ZSBtb3JlIHJvYnVzdC4KPiAKPiA+IAo+ID4gSW4gdGhlIG1lYW50aW1lCj4gPiBSZXZpZXdlZC1i
eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBU
aGFua3MuCj4gCj4gPiAKPiA+ID4gRml4IHRoaXMgYnkgdHJlYXRpbmcgYW55IGVycm9yIGFzIHRo
ZSBsYWNrIG9mIHRoZSBnaXZlbgo+ID4gPiBjYXBhYmlsaXR5Lgo+ID4gPiAKPiA+ID4gSW4gY2Fz
ZSBvZiBEUF9TSU5LX0RFVklDRV9BVVhfRlJBTUVfU1lOQ19DQVAgYW4gZXJyb3Igd291bGQgbGVh
dmUgdGhlCj4gPiA+IGJ1ZmZlciB1bmluaXRpYWxpemVkIGV2ZW4gd2l0aCB0aGUgYWJvdmUgYXNz
dW1wdGlvbi4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFr
QGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
cC5jIHwgMjAgKysrKysrKysrKysrLS0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBp
bnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9kcC5jCj4gPiA+IGluZGV4IDA4ODM0ZjcuLjRhNmZlYjYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBAQCAtMzA4OCw3ICszMDg4LDggQEAgc3RhdGljIGJvb2wg
aW50ZWxfZHBfZ2V0X3lfY29yZF9zdGF0dXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+
ID4gIHsKPiA+ID4gIAl1aW50OF90IHBzcl9jYXBzID0gMDsKPiA+ID4gIAo+ID4gPiAtCWRybV9k
cF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9QU1JfQ0FQUywgJnBzcl9jYXBzKTsKPiA+
ID4gKwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1BTUl9DQVBTLCAm
cHNyX2NhcHMpICE9IDEpCj4gPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ID4gIAlyZXR1cm4gcHNy
X2NhcHMgJiBEUF9QU1IyX1NVX1lfQ09PUkRJTkFURV9SRVFVSVJFRDsKPiA+ID4gIH0KPiA+ID4g
IAo+ID4gPiBAQCAtMzA5Niw5ICszMDk3LDkgQEAgc3RhdGljIGJvb2wgaW50ZWxfZHBfZ2V0X2Nv
bG9yaW1ldHJ5X3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4gPiAgewo+ID4g
PiAgCXVpbnQ4X3QgZHByeCA9IDA7Cj4gPiA+ICAKPiA+ID4gLQlkcm1fZHBfZHBjZF9yZWFkYigm
aW50ZWxfZHAtPmF1eCwKPiA+ID4gLQkJCURQX0RQUlhfRkVBVFVSRV9FTlVNRVJBVElPTl9MSVNU
LAo+ID4gPiAtCQkJJmRwcngpOwo+ID4gPiArCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxf
ZHAtPmF1eCwgRFBfRFBSWF9GRUFUVVJFX0VOVU1FUkFUSU9OX0xJU1QsCj4gPiA+ICsJCQkgICAg
ICAmZHByeCkgIT0gMSkKPiA+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gPiAgCXJldHVybiBkcHJ4
ICYgRFBfVlNDX1NEUF9FWFRfRk9SX0NPTE9SSU1FVFJZX1NVUFBPUlRFRDsKPiA+ID4gIH0KPiA+
ID4gIAo+ID4gPiBAQCAtMzEwNiw3ICszMTA3LDkgQEAgc3RhdGljIGJvb2wgaW50ZWxfZHBfZ2V0
X2FscG1fc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPiA+ICB7Cj4gPiA+ICAJ
dWludDhfdCBhbHBtX2NhcHMgPSAwOwo+ID4gPiAgCj4gPiA+IC0JZHJtX2RwX2RwY2RfcmVhZGIo
JmludGVsX2RwLT5hdXgsIERQX1JFQ0VJVkVSX0FMUE1fQ0FQLCAmYWxwbV9jYXBzKTsKPiA+ID4g
KwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1JFQ0VJVkVSX0FMUE1f
Q0FQLAo+ID4gPiArCQkJICAgICAgJmFscG1fY2FwcykgIT0gMSkKPiA+ID4gKwkJcmV0dXJuIGZh
bHNlOwo+ID4gPiAgCXJldHVybiBhbHBtX2NhcHMgJiBEUF9BTFBNX0NBUDsKPiA+ID4gIH0KPiA+
ID4gIAo+ID4gPiBAQCAtMzY3OSw5ICszNjgyLDEwIEBAIGludGVsX2VkcF9pbml0X2RwY2Qoc3Ry
dWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ID4gIAkJdWludDhfdCBmcmFtZV9zeW5jX2NhcDsK
PiA+ID4gIAo+ID4gPiAgCQlkZXZfcHJpdi0+cHNyLnNpbmtfc3VwcG9ydCA9IHRydWU7Cj4gPiA+
IC0JCWRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LAo+ID4gPiAtCQkJCSAgRFBfU0lO
S19ERVZJQ0VfQVVYX0ZSQU1FX1NZTkNfQ0FQLAo+ID4gPiAtCQkJCSAgJmZyYW1lX3N5bmNfY2Fw
KTsKPiA+ID4gKwkJaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LAo+ID4gPiAr
CQkJCSAgICAgIERQX1NJTktfREVWSUNFX0FVWF9GUkFNRV9TWU5DX0NBUCwKPiA+ID4gKwkJCQkg
ICAgICAmZnJhbWVfc3luY19jYXApICE9IDEpCj4gPiA+ICsJCQlmcmFtZV9zeW5jX2NhcCA9IDA7
Cj4gPiA+ICAJCWRldl9wcml2LT5wc3IuYXV4X2ZyYW1lX3N5bmMgPSBmcmFtZV9zeW5jX2NhcCA/
IHRydWUgOiBmYWxzZTsKPiA+ID4gIAkJLyogUFNSMiBuZWVkcyBmcmFtZSBzeW5jIGFzIHdlbGwg
Ki8KPiA+ID4gIAkJZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBvcnQgPSBkZXZfcHJpdi0+cHNyLmF1
eF9mcmFtZV9zeW5jOwo+ID4gPiAtLSAKPiA+ID4gMi41LjAKPiA+ID4gCj4gPiA+IF9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IEludGVsLWdmeCBt
YWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBo
dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+
ID4gCj4gPiAtLSAKPiA+IFZpbGxlIFN5cmrDpGzDpAo+ID4gSW50ZWwgT1RDCgotLSAKVmlsbGUg
U3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz
a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p
bnRlbC1nZngK