From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 5/8] drm/i915: Check error return when converting pipe to connector Date: Thu, 27 Apr 2017 14:49:55 +0300 Message-ID: <20170427114955.GL30290@intel.com> References: <1493227086-3807-3-git-send-email-imre.deak@intel.com> <1493282214-11808-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id F04FE893E7 for ; Thu, 27 Apr 2017 11:49:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1493282214-11808-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMjcsIDIwMTcgYXQgMTE6MzY6NTRBTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEFuIGVycm9yIGZyb20gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoKSB3b3VsZCBt ZWFuIGEgYnVnIHNvbWV3aGVyZQo+IGVsc2UsIGJ1dCB3ZSBzdGlsbCBzaG91bGQgY2hlY2sgZm9y IGl0IHRvIHByZXZlbnQgc29tZSBvdGhlciBtb3JlCj4gb2JzY3VyZSBidWcgbGF0ZXIuCj4gCj4g djI6Cj4gLSBGYWxsIGJhY2sgdG8gYSByZWFzb25hYmxlIGRlZmF1bHQgaW5zdGVhZCBvZiBiYWls aW5nIG91dCBpbiBjYXNlIG9mCj4gICBlcnJvci4gKEphbmkpCj4gdjM6Cj4gLSBGaXggcy9QSVBF X0lOVkFMSUQvSU5WQUxJRF9QSVBFLyB0eXBvLiAoSmFuaSkKPiAKPiBDYzogSmFuaSBOaWt1bGEg PGphbmkubmlrdWxhQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVs LmMgfCAxNyArKysrKysrKysrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcGFuZWwuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiBp bmRleCBjYjUwYzUyLi5kMWFiYmYxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BhbmVsLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5j Cj4gQEAgLTg4OCwxMCArODg4LDE0IEBAIHN0YXRpYyB2b2lkIHBjaF9lbmFibGVfYmFja2xpZ2h0 KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gIAlzdHJ1 Y3QgaW50ZWxfcGFuZWwgKnBhbmVsID0gJmNvbm5lY3Rvci0+cGFuZWw7Cj4gIAllbnVtIHBpcGUg cGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gLQllbnVt IHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXIgPQo+IC0JCWludGVsX3BpcGVfdG9fY3B1X3RyYW5z Y29kZXIoZGV2X3ByaXYsIHBpcGUpOwo+ICsJZW51bSB0cmFuc2NvZGVyIGNwdV90cmFuc2NvZGVy Owo+ICAJdTMyIGNwdV9jdGwyLCBwY2hfY3RsMSwgcGNoX2N0bDI7Cj4gIAo+ICsJaWYgKCFXQVJO X09OX09OQ0UocGlwZSA9PSBJTlZBTElEX1BJUEUpKQo+ICsJCWNwdV90cmFuc2NvZGVyID0gaW50 ZWxfcGlwZV90b19jcHVfdHJhbnNjb2RlcihkZXZfcHJpdiwgcGlwZSk7Cj4gKwllbHNlCj4gKwkJ Y3B1X3RyYW5zY29kZXIgPSBUUkFOU0NPREVSX0VEUDsKPiArCj4gIAljcHVfY3RsMiA9IEk5MTVf UkVBRChCTENfUFdNX0NQVV9DVEwyKTsKPiAgCWlmIChjcHVfY3RsMiAmIEJMTV9QV01fRU5BQkxF KSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygiY3B1IGJhY2tsaWdodCBhbHJlYWR5IGVuYWJsZWRcbiIp Owo+IEBAIC05NzMsNiArOTc3LDkgQEAgc3RhdGljIHZvaWQgaTk2NV9lbmFibGVfYmFja2xpZ2h0 KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCWVudW0gcGlwZSBwaXBlID0g aW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiAgCXUzMiBjdGwsIGN0 bDIsIGZyZXE7Cj4gIAo+ICsJaWYgKFdBUk5fT05fT05DRShwaXBlID09IElOVkFMSURfUElQRSkp Cj4gKwkJcGlwZSA9IFBJUEVfQTsKPiArCj4gIAljdGwyID0gSTkxNV9SRUFEKEJMQ19QV01fQ1RM Mik7Cj4gIAlpZiAoY3RsMiAmIEJMTV9QV01fRU5BQkxFKSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygi YmFja2xpZ2h0IGFscmVhZHkgZW5hYmxlZFxuIik7Cj4gQEAgLTEwMzcsNiArMTA0NCw5IEBAIHN0 YXRpYyB2b2lkIGJ4dF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNv bm5lY3RvcikKPiAgCWVudW0gcGlwZSBwaXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0 b3IoY29ubmVjdG9yKTsKPiAgCXUzMiBwd21fY3RsLCB2YWw7Cj4gIAo+ICsJaWYgKFdBUk5fT05f T05DRShwaXBlKSA9PSBJTlZBTElEX1BJUEUpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XgoKSXNuJ3QgdGhhdCB0aGluZyBpbiB0aGUgd3JvbmcgcGxhY2U/Cgo+ICsJCXBpcGUgPSBQSVBF X0E7Cj4gKwo+ICAJLyogQ29udHJvbGxlciAxIHVzZXMgdGhlIHV0aWxpdHkgcGluLiAqLwo+ICAJ aWYgKHBhbmVsLT5iYWNrbGlnaHQuY29udHJvbGxlciA9PSAxKSB7Cj4gIAkJdmFsID0gSTkxNV9S RUFEKFVUSUxfUElOX0NUTCk7Cj4gQEAgLTEwOTMsNyArMTEwMyw4IEBAIHZvaWQgaW50ZWxfcGFu ZWxfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4g IAlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCkKPiAgCQlyZXR1cm47Cj4gIAo+IC0JRFJN X0RFQlVHX0tNUygicGlwZSAlY1xuIiwgcGlwZV9uYW1lKHBpcGUpKTsKPiArCWlmICghV0FSTl9P Tl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkKPiArCQlEUk1fREVCVUdfS01TKCJwaXBlICVj XG4iLCBwaXBlX25hbWUocGlwZSkpOwo+ICAKPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5iYWNr bGlnaHRfbG9jayk7Cj4gIAo+IC0tIAo+IDIuNS4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK