From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH v5 3/3] drm/i915: Add format modifiers for Intel Date: Wed, 17 May 2017 18:14:29 -0700 Message-ID: <20170518011429.GD2334@mail.bwidawsk.net> References: <20170516213126.8269-1-ben@bwidawsk.net> <20170516213126.8269-3-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Emil Velikov Cc: Intel GFX , "Kristian H . Kristensen" , DRI Development List-Id: intel-gfx@lists.freedesktop.org T24gMTctMDUtMTcgMDE6MjA6NTAsIEVtaWwgVmVsaWtvdiB3cm90ZToKPkhpIEJlbiwKPgo+QSBj b3VwbGUgb2Ygc21hbGwgcXVlc3Rpb25zL3N1Z2dlc3Rpb25zIHRoYXQgSSBob3BlIHlvdSBmaW5k IHVzZWZ1bC4KPlBsZWFzZSBkb24ndCBibG9jayBhbnkgb2YgdGhpcyB3b3JrIGJhc2VkIG9uIG15 IGNvbW1lbnRzLgo+Cj5PbiAxNiBNYXkgMjAxNyBhdCAyMjozMSwgQmVuIFdpZGF3c2t5IDxiZW5A YndpZGF3c2submV0PiB3cm90ZToKPgo+PiArc3RhdGljIGJvb2wgaW50ZWxfcHJpbWFyeV9wbGFu ZV9mb3JtYXRfbW9kX3N1cHBvcnRlZChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBm b3JtYXQsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdWludDY0X3QgbW9kaWZpZXIpCj4+ICt7Cj4+ICsgICAgICAgc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+ZGV2KTsKPj4gKwo+PiArICAgICAg IGlmIChXQVJOX09OKG1vZGlmaWVyID09IERSTV9GT1JNQVRfTU9EX0lOVkFMSUQpKQo+PiArICAg ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+PiArCj4+ICsgICAgICAgaWYgKElOVEVMX0dFTihk ZXZfcHJpdikgPj0gOSkKPj4gKyAgICAgICAgICAgICAgIHJldHVybiBza2xfbW9kX3N1cHBvcnRl ZChmb3JtYXQsIG1vZGlmaWVyKTsKPj4gKyAgICAgICBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3By aXYpID49IDQpCj4+ICsgICAgICAgICAgICAgICByZXR1cm4gaTk2NV9tb2Rfc3VwcG9ydGVkKGZv cm1hdCwgbW9kaWZpZXIpOwo+PiArICAgICAgIGVsc2UKPj4gKyAgICAgICAgICAgICAgIHJldHVy biBpOHh4X21vZF9zdXBwb3J0ZWQoZm9ybWF0LCBtb2RpZmllcik7Cj4+ICsKPk5pdDogaWYgeW91 IHJld3JpdGUgdGhpcyBhcyBiZWxvdywgdGhlIGNvbnRyb2wgZmxvdyBzaG91bGQgYmUgY2xlYXJl ci4KPlRodXMgdGhlICdyZXR1cm4gZmFsc2U7JyBhdCB0aGUgZW5kLCB3aWxsIGJlIFttb3JlXSBv YnZpb3VzIHRoYXQgaXQncwo+dW5yZWFjaGFibGUgOy0pCj4KPiAgICAgICBpZiAoSU5URUxfR0VO KGRldl9wcml2KSA+PSA5KQo+ICAgICAgICAgICAgICAgcmV0dXJuIHNrbF9tb2Rfc3VwcG9ydGVk KGZvcm1hdCwgbW9kaWZpZXIpOwo+Cj4gICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g NCkKPiAgICAgICAgICAgICAgIHJldHVybiBpOTY1X21vZF9zdXBwb3J0ZWQoZm9ybWF0LCBtb2Rp Zmllcik7Cj4KPiAgICAgICByZXR1cm4gaTh4eF9tb2Rfc3VwcG9ydGVkKGZvcm1hdCwgbW9kaWZp ZXIpOwo+Cj4KCkl0J3MgYSBnb29kIHBvaW50LCBob3dldmVyIG1hbnkgb3RoZXIgYmxvY2tzIG9m IGNvZGUgZG8gdGhlIHNhbWUgdGhpbmcsIGFuZCBJCnRoaW5rIHRoZSBuYXR1cmUgb2YgaWYvZWxz ZSBpZi9lbHNlIGltcGxpZXMgdW5yZWFjaGFibGUuIEkgY2FuIGFkZAp1bnJlYWNoYWJsZSgpLi4u IEluIGZhY3QsIEkganVzdCBkaWQuCgo+PiArICAgICAgIHJldHVybiBmYWxzZTsKPj4gK30KPj4g Kwo+Cj4KPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPgo+PiArc3RhdGljIGJvb2wg aW50ZWxfc3ByaXRlX3BsYW5lX2Zvcm1hdF9tb2Rfc3VwcG9ydGVkKHN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHVpbnQzMl90IGZvcm1hdCwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCBtb2RpZmllcikKPj4gK3sKPj4gKyAgICAg ICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHBsYW5lLT5kZXYp Owo+PiArCj4+ICsgICAgICAgaWYgKFdBUk5fT04obW9kaWZpZXIgPT0gRFJNX0ZPUk1BVF9NT0Rf SU5WQUxJRCkpCj4+ICsgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+ICsKPj4gKyAgICAg ICBCVUdfT04ocGxhbmUtPmJhc2UudHlwZSAhPSBEUk1fUExBTkVfVFlQRV9PVkVSTEFZKTsKPj4g Kwo+PiArICAgICAgIHN3aXRjaCAoZm9ybWF0KSB7Cj4+ICsgICAgICAgICAgICAgICBjYXNlIERS TV9GT1JNQVRfWEJHUjIxMDEwMTA6Cj4+ICsgICAgICAgICAgICAgICBjYXNlIERSTV9GT1JNQVRf QUJHUjIxMDEwMTA6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmIChJU19WQUxMRVlWSUVX KGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAg YnJlYWs7Cj4+ICsgICAgICAgICAgICAgICBjYXNlIERSTV9GT1JNQVRfUkdCNTY1Ogo+PiArICAg ICAgICAgICAgICAgY2FzZSBEUk1fRk9STUFUX0FCR1I4ODg4Ogo+PiArICAgICAgICAgICAgICAg Y2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+PiArICAgICAgICAgICAgICAgICAgICAgICBpZiAo SU5URUxfR0VOKGRldl9wcml2KSA+PSA5IHx8IElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElT X0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJldHVybiB0cnVlOwo+PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPj4gKyAgICAg ICAgICAgICAgIGNhc2UgRFJNX0ZPUk1BVF9YQkdSODg4ODoKPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gNikKPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7Cj4+ICsgICAgICAgICAgICAgICBjYXNlIERSTV9GT1JNQVRfWFJHQjg4ODg6Cj4+ICsgICAg ICAgICAgICAgICBjYXNlIERSTV9GT1JNQVRfWVVZVjoKPj4gKyAgICAgICAgICAgICAgIGNhc2Ug RFJNX0ZPUk1BVF9ZVllVOgo+PiArICAgICAgICAgICAgICAgY2FzZSBEUk1fRk9STUFUX1VZVlk6 Cj4+ICsgICAgICAgICAgICAgICBjYXNlIERSTV9GT1JNQVRfVllVWToKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+ICsgICAgICAgfQo+PiArCj4+ICsgICAgICAgcmV0 dXJuIGZhbHNlOwo+PiArfQo+PiArCj4+ICtjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX2Z1bmNzIGlu dGVsX3Nwcml0ZV9wbGFuZV9mdW5jcyA9IHsKPj4gKyAgICAgICAgLnVwZGF0ZV9wbGFuZSA9IGRy bV9hdG9taWNfaGVscGVyX3VwZGF0ZV9wbGFuZSwKPj4gKyAgICAgICAgLmRpc2FibGVfcGxhbmUg PSBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX3BsYW5lLAo+PiArICAgICAgICAuZGVzdHJveSA9 IGludGVsX3BsYW5lX2Rlc3Ryb3ksCj4+ICsgICAgICAgIC5zZXRfcHJvcGVydHkgPSBkcm1fYXRv bWljX2hlbHBlcl9wbGFuZV9zZXRfcHJvcGVydHksCj4+ICsgICAgICAgIC5hdG9taWNfZ2V0X3By b3BlcnR5ID0gaW50ZWxfcGxhbmVfYXRvbWljX2dldF9wcm9wZXJ0eSwKPj4gKyAgICAgICAgLmF0 b21pY19zZXRfcHJvcGVydHkgPSBpbnRlbF9wbGFuZV9hdG9taWNfc2V0X3Byb3BlcnR5LAo+PiAr ICAgICAgICAuYXRvbWljX2R1cGxpY2F0ZV9zdGF0ZSA9IGludGVsX3BsYW5lX2R1cGxpY2F0ZV9z dGF0ZSwKPj4gKyAgICAgICAgLmF0b21pY19kZXN0cm95X3N0YXRlID0gaW50ZWxfcGxhbmVfZGVz dHJveV9zdGF0ZSwKPj4gKyAgICAgICAgLmZvcm1hdF9tb2Rfc3VwcG9ydGVkID0gaW50ZWxfc3By aXRlX3BsYW5lX2Zvcm1hdF9tb2Rfc3VwcG9ydGVkLAo+PiArfTsKPj4gKwo+SGF2aW5nIGEgZHVs bCBtb21lbnQgLSBpcyBpbnRlbF9zcHJpdGVfcGxhbmVfZnVuY3MgKCsKPmludGVsX3Nwcml0ZV9w bGFuZV9mb3JtYXRfbW9kX3N1cHBvcnRlZCkgdW51c2VkIG9yIEknbSBzZWVpbmcgdGhpbmdzPwo+ SWYgb25lIGlzIHRvIGtlZXAgaXQsIGZvciBmdXR1cmUgd29yaywgcGVyaGFwcyBpdCdzIHdvcnRo IGFkZGluZyBhIDItMwo+d29yZCBjb21tZW50LAo+Cj5SZWdhcmRzLAo+RW1pbAoKTm90IHN1cmUg aG93IHRoaXMgaGFwcGVuZWQsIGl0IGlzIGEgbWlzdGFrZS4gVGhhbmtzIGZvciBzcG90dGluZyBp dC4gSGVyZSdzIHdoYXQKSSBnb3QgbG9jYWxseToKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKaW5kZXggMzUxOWMxMGFiY2MzLi5hOGY0YzU3ODNlYzIgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMKQEAgLTEzNDc5LDcgKzEzNDc5LDcgQEAgc3RhdGljIGJvb2wgaW50 ZWxfcHJpbWFyeV9wbGFuZV9mb3JtYXRfbW9kX3N1cHBvcnRlZChzdHJ1Y3QgZHJtX3BsYW5lICpw bGFuZSwKICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICByZXR1cm4gaTh4eF9tb2Rfc3VwcG9y dGVkKGZvcm1hdCwgbW9kaWZpZXIpOwoKLSAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgdW5y ZWFjaGFibGUoKTsKIH0KCiBzdGF0aWMgYm9vbCBpbnRlbF9jdXJzb3JfcGxhbmVfZm9ybWF0X21v ZF9zdXBwb3J0ZWQoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCmRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Nwcml0ZS5jCmluZGV4IGU3YzVjMGE5NGJiZC4uMWQ1ODJiNDM2YjU5IDEwMDY0NAotLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYworKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9zcHJpdGUuYwpAQCAtMTIzMyw3ICsxMjMzLDcgQEAgaW50ZWxfc3ByaXRlX3Bs YW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCgogICAgICAgIGlm IChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpCiAgICAgICAgICAgICAgICByZXQgPSBkcm1fdW5p dmVyc2FsX3BsYW5lX2luaXQoJmRldl9wcml2LT5kcm0sICZpbnRlbF9wbGFuZS0+YmFzZSwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwb3NzaWJsZV9jcnRj cywgJmludGVsX3BsYW5lX2Z1bmNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBvc3NpYmxlX2NydGNzLCAmaW50ZWxfc3ByaXRlX3BsYW5lX2Z1bmNzLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBsYW5lX2Zvcm1h dHMsIG51bV9wbGFuZV9mb3JtYXRzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG1vZGlmaWVycywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBEUk1fUExBTkVfVFlQRV9PVkVSTEFZLAoKCi0tIApCZW4gV2lkYXdza3ks IEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=