From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH v5] dma-buf/sync-file: Defer creation of sync_file->name Date: Wed, 24 May 2017 22:38:13 -0300 Message-ID: <20170525013813.GC16058@jade> References: <20170515101055.10266-1-chris@chris-wilson.co.uk> <20170516111042.24719-1-chris@chris-wilson.co.uk> <20170522193156.jp4ab7gi6pehjerp@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170522193156.jp4ab7gi6pehjerp@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org MjAxNy0wNS0yMiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+OgoKPiBPbiBUdWUsIE1h eSAxNiwgMjAxNyBhdCAxMjoxMDo0MlBNICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBD b25zdHJ1Y3RpbmcgdGhlIG5hbWUgdGFrZXMgdGhlIG1ham9yaXR5IG9mIHRoZSB0aW1lIGZvciBh bGxvY2F0aW5nIGEKPiA+IHN5bmNfZmlsZSB0byB3cmFwIGEgZmVuY2UsIGFuZCB0aGUgbmFtZSBp cyB2ZXJ5IHJhcmVseSB1c2VkIChvbmx5IHZpYQo+ID4gdGhlIHN5bmNfZmlsZSBzdGF0dXMgdXNl ciBpbnRlcmZhY2UpLiBUbyByZWR1Y2UgdGhlIGltcGFjdCBvbiB0aGUgY29tbW9uCj4gPiBwYXRo ICh0aGF0IG9mIGNyZWF0aW5nIHN5bmNfZmlsZSB0byBwYXNzIGFyb3VuZCksIGRlZmVyIHRoZSBj b25zdHJ1Y3Rpb24KPiA+IG9mIHRoZSBuYW1lIHVudGlsIGl0IGlzIGZpcnN0IHVzZWQuCj4gPiAK PiA+IHYyOiBVcGRhdGUga2VybmVsZG9jIChrYnVpbGQgdGVzdCByb2JvdCkKPiA+IHYzOiBzeW5j X2RlYnVnLmMgd2FzIHBlZWtpbmcgYXQgdGhlIG5hbWUKPiA+IHY0OiBDb21tZW50IHVwb24gdGhl IHBvdGVudGlhbCByYWNlIGJldHdlZW4gdHdvIHVzZXJzIG9mCj4gPiBzeW5jX2ZpbGVfZ2V0X25h bWUoKSBhbmQgY2xhaW0gdGhhdCBzdWNoIGEgcmFjZSBpcyBiZWxvdyB0aGUgbGV2ZWwgb2YKPiA+ IG5vdGljZS4gSG93ZXZlciwgdG8gcHJldmVudCBhbnkgZnV0dXJlIG51aXNhbmNlLCB1c2UgYSBn bG9iYWwgc3BpbmxvY2sKPiA+IHRvIHNlcmlhbGl6ZSB0aGUgYXNzaWdubWVudCBvZiB0aGUgbmFt ZS4KPiA+IHY1OiBDb21wbGV0ZWx5IGF2b2lkIHRoZSByZWFkL3dyaXRlIHJhY2UgYnkgb25seSBz dG9yaW5nIHRoZSBuYW1lIHBhc3NlZAo+ID4gaW4gZnJvbSB0aGUgdXNlciBpbnNpZGUgc3luY19m aWxlLT51c2VyX25hbWUgYW5kIHBhc3NpbmcgaW4gYSBidWZmZXIgdG8KPiA+IGR5bmFtaWNhbGx5 IGNvbnN0cnVjdCB0aGUgbmFtZSBvdGhlcndpc2UuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gQ2M6IFN1bWl0IFNlbXdh bCA8c3VtaXQuc2Vtd2FsQGxpbmFyby5vcmc+Cj4gPiBDYzogR3VzdGF2byBQYWRvdmFuIDxndXN0 YXZvQHBhZG92YW4ub3JnPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3 bGwuY2g+Cj4gPiBDYzogRGF2aWQgSGVycm1hbm4gPGRoLmhlcnJtYW5uQGdtYWlsLmNvbT4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZG1hLWJ1Zi9zeW5jX2RlYnVnLmMgfCAgNCArKystCj4gPiAgZHJp dmVycy9kbWEtYnVmL3N5bmNfZmlsZS5jICB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLQo+ID4gIGluY2x1ZGUvbGludXgvc3luY19maWxlLmggICAgfCAgNSArKyst LQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS1idWYvc3luY19kZWJ1Zy5jIGIvZHJp dmVycy9kbWEtYnVmL3N5bmNfZGVidWcuYwo+ID4gaW5kZXggNGIxNzMxZWU3NDU4Li41OWEzYjJm OGVlOTEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2RtYS1idWYvc3luY19kZWJ1Zy5jCj4gPiAr KysgYi9kcml2ZXJzL2RtYS1idWYvc3luY19kZWJ1Zy5jCj4gPiBAQCAtMTMyLDkgKzEzMiwxMSBA QCBzdGF0aWMgdm9pZCBzeW5jX3ByaW50X29iaihzdHJ1Y3Qgc2VxX2ZpbGUgKnMsIHN0cnVjdCBz eW5jX3RpbWVsaW5lICpvYmopCj4gPiAgc3RhdGljIHZvaWQgc3luY19wcmludF9zeW5jX2ZpbGUo c3RydWN0IHNlcV9maWxlICpzLAo+ID4gIAkJCQkgIHN0cnVjdCBzeW5jX2ZpbGUgKnN5bmNfZmls ZSkKPiA+ICB7Cj4gPiArCWNoYXIgYnVmWzEyOF07Cj4gPiAgCWludCBpOwo+ID4gIAo+ID4gLQlz ZXFfcHJpbnRmKHMsICJbJXBdICVzOiAlc1xuIiwgc3luY19maWxlLCBzeW5jX2ZpbGUtPm5hbWUs Cj4gPiArCXNlcV9wcmludGYocywgIlslcF0gJXM6ICVzXG4iLCBzeW5jX2ZpbGUsCj4gPiArCQkg ICBzeW5jX2ZpbGVfZ2V0X25hbWUoc3luY19maWxlLCBidWYsIHNpemVvZihidWYpKSwKPiA+ICAJ CSAgIHN5bmNfc3RhdHVzX3N0cihkbWFfZmVuY2VfZ2V0X3N0YXR1cyhzeW5jX2ZpbGUtPmZlbmNl KSkpOwo+ID4gIAo+ID4gIAlpZiAoZG1hX2ZlbmNlX2lzX2FycmF5KHN5bmNfZmlsZS0+ZmVuY2Up KSB7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEtYnVmL3N5bmNfZmlsZS5jIGIvZHJpdmVy cy9kbWEtYnVmL3N5bmNfZmlsZS5jCj4gPiBpbmRleCBjOWViNDk5N2NmY2MuLmQ3ZTIxOWQyNjY5 ZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYwo+ID4gKysrIGIv ZHJpdmVycy9kbWEtYnVmL3N5bmNfZmlsZS5jCj4gPiBAQCAtODAsMTEgKzgwLDYgQEAgc3RydWN0 IHN5bmNfZmlsZSAqc3luY19maWxlX2NyZWF0ZShzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSkKPiA+ ICAKPiA+ICAJc3luY19maWxlLT5mZW5jZSA9IGRtYV9mZW5jZV9nZXQoZmVuY2UpOwo+ID4gIAo+ ID4gLQlzbnByaW50ZihzeW5jX2ZpbGUtPm5hbWUsIHNpemVvZihzeW5jX2ZpbGUtPm5hbWUpLCAi JXMtJXMlbGx1LSVkIiwKPiA+IC0JCSBmZW5jZS0+b3BzLT5nZXRfZHJpdmVyX25hbWUoZmVuY2Up LAo+ID4gLQkJIGZlbmNlLT5vcHMtPmdldF90aW1lbGluZV9uYW1lKGZlbmNlKSwgZmVuY2UtPmNv bnRleHQsCj4gPiAtCQkgZmVuY2UtPnNlcW5vKTsKPiA+IC0KPiA+ICAJcmV0dXJuIHN5bmNfZmls ZTsKPiA+ICB9Cj4gPiAgRVhQT1JUX1NZTUJPTChzeW5jX2ZpbGVfY3JlYXRlKTsKPiA+IEBAIC0x MjksNiArMTI0LDM2IEBAIHN0cnVjdCBkbWFfZmVuY2UgKnN5bmNfZmlsZV9nZXRfZmVuY2UoaW50 IGZkKQo+ID4gIH0KPiA+ICBFWFBPUlRfU1lNQk9MKHN5bmNfZmlsZV9nZXRfZmVuY2UpOwo+ID4g IAo+ID4gKy8qKgo+ID4gKyAqIHN5bmNfZmlsZV9nZXRfbmFtZSAtIGdldCB0aGUgbmFtZSBvZiB0 aGUgc3luY19maWxlCj4gPiArICogQHN5bmNfZmlsZToJCXN5bmNfZmlsZSB0byBnZXQgdGhlIGZl bmNlIGZyb20KPiA+ICsgKiBAYnVmOgkJZGVzdGluYXRpb24gYnVmZmVyIHRvIGNvcHkgc3luY19m aWxlIG5hbWUgaW50bwo+ID4gKyAqIEBsZW46CQlhdmFpbGFibGUgc2l6ZSBvZiBkZXN0aW5hdGlv biBidWZmZXIuCj4gPiArICoKPiA+ICsgKiBFYWNoIHN5bmNfZmlsZSBtYXkgaGF2ZSBhIG5hbWUg YXNzaWduZWQgZWl0aGVyIGJ5IHRoZSB1c2VyICh3aGVuIG1lcmdpbmcKPiA+ICsgKiBzeW5jX2Zp bGVzIHRvZ2V0aGVyKSBvciBjcmVhdGVkIGZyb20gdGhlIGZlbmNlIGl0IGNvbnRhaW5zLiBJbiB0 aGUgbGF0dGVyCj4gPiArICogY2FzZSBjb25zdHJ1Y3Rpb24gb2YgdGhlIG5hbWUgaXMgZGVmZXJy ZWQgdW50aWwgdXNlLCBhbmQgc28gcmVxdWlyZXMKPiA+ICsgKiBzeW5jX2ZpbGVfZ2V0X25hbWUo KS4KPiA+ICsgKgo+ID4gKyAqIFJldHVybnM6IGEgc3RyaW5nIHJlcHJlc2VudGluZyB0aGUgbmFt ZS4KPiA+ICsgKi8KPiA+ICtjaGFyICpzeW5jX2ZpbGVfZ2V0X25hbWUoc3RydWN0IHN5bmNfZmls ZSAqc3luY19maWxlLCBjaGFyICpidWYsIGludCBsZW4pCj4gPiArewo+ID4gKwlpZiAoc3luY19m aWxlLT51c2VyX25hbWVbMF0pIHsKPiA+ICsJCXN0cmxjcHkoYnVmLCBzeW5jX2ZpbGUtPnVzZXJf bmFtZSwgbGVuKTsKPiA+ICsJfSBlbHNlIHsKPiA+ICsJCXN0cnVjdCBkbWFfZmVuY2UgKmZlbmNl ID0gc3luY19maWxlLT5mZW5jZTsKPiA+ICsKPiA+ICsJCXNucHJpbnRmKGJ1ZiwgbGVuLCAiJXMt JXMlbGx1LSVkIiwKPiA+ICsJCQkgZmVuY2UtPm9wcy0+Z2V0X2RyaXZlcl9uYW1lKGZlbmNlKSwK PiA+ICsJCQkgZmVuY2UtPm9wcy0+Z2V0X3RpbWVsaW5lX25hbWUoZmVuY2UpLAo+ID4gKwkJCSBm ZW5jZS0+Y29udGV4dCwKPiA+ICsJCQkgZmVuY2UtPnNlcW5vKTsKPiA+ICsJfQo+ID4gKwo+ID4g KwlyZXR1cm4gYnVmOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgaW50IHN5bmNfZmlsZV9zZXRf ZmVuY2Uoc3RydWN0IHN5bmNfZmlsZSAqc3luY19maWxlLAo+ID4gIAkJCSAgICAgICBzdHJ1Y3Qg ZG1hX2ZlbmNlICoqZmVuY2VzLCBpbnQgbnVtX2ZlbmNlcykKPiA+ICB7Cj4gPiBAQCAtMjY2LDcg KzI5MSw3IEBAIHN0YXRpYyBzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGVfbWVyZ2UoY29uc3Qg Y2hhciAqbmFtZSwgc3RydWN0IHN5bmNfZmlsZSAqYSwKPiA+ICAJCWdvdG8gZXJyOwo+ID4gIAl9 Cj4gPiAgCj4gPiAtCXN0cmxjcHkoc3luY19maWxlLT5uYW1lLCBuYW1lLCBzaXplb2Yoc3luY19m aWxlLT5uYW1lKSk7Cj4gPiArCXN0cmxjcHkoc3luY19maWxlLT51c2VyX25hbWUsIG5hbWUsIHNp emVvZihzeW5jX2ZpbGUtPnVzZXJfbmFtZSkpOwo+ID4gIAlyZXR1cm4gc3luY19maWxlOwo+ID4g IAo+ID4gIGVycjoKPiA+IEBAIC00MTksNyArNDQ0LDcgQEAgc3RhdGljIGxvbmcgc3luY19maWxl X2lvY3RsX2ZlbmNlX2luZm8oc3RydWN0IHN5bmNfZmlsZSAqc3luY19maWxlLAo+ID4gIAl9Cj4g PiAgCj4gPiAgbm9fZmVuY2VzOgo+ID4gLQlzdHJsY3B5KGluZm8ubmFtZSwgc3luY19maWxlLT5u YW1lLCBzaXplb2YoaW5mby5uYW1lKSk7Cj4gPiArCXN5bmNfZmlsZV9nZXRfbmFtZShzeW5jX2Zp bGUsIGluZm8ubmFtZSwgc2l6ZW9mKGluZm8ubmFtZSkpOwo+ID4gIAlpbmZvLnN0YXR1cyA9IGRt YV9mZW5jZV9pc19zaWduYWxlZChzeW5jX2ZpbGUtPmZlbmNlKTsKPiA+ICAJaW5mby5udW1fZmVu Y2VzID0gbnVtX2ZlbmNlczsKPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3N5 bmNfZmlsZS5oIGIvaW5jbHVkZS9saW51eC9zeW5jX2ZpbGUuaAo+ID4gaW5kZXggZDM3YmVlZmRm YmQ1Li41MjI2ZDYyYWU5MWIgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3N5bmNfZmls ZS5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4L3N5bmNfZmlsZS5oCj4gPiBAQCAtMjMsNyArMjMs NyBAQAo+ID4gIC8qKgo+ID4gICAqIHN0cnVjdCBzeW5jX2ZpbGUgLSBzeW5jIGZpbGUgdG8gZXhw b3J0IHRvIHRoZSB1c2Vyc3BhY2UKPiA+ICAgKiBAZmlsZToJCWZpbGUgcmVwcmVzZW50aW5nIHRo aXMgZmVuY2UKPiA+IC0gKiBAbmFtZToJCW5hbWUgb2Ygc3luY19maWxlLiAgVXNlZnVsIGZvciBk ZWJ1Z2dpbmcKPiA+ICsgKiBAdXNlcl9uYW1lOgkJbmFtZSBvZiBzeW5jX2ZpbGUuICBVc2VmdWwg Zm9yIGRlYnVnZ2luZwo+ID4gICAqIEBzeW5jX2ZpbGVfbGlzdDoJbWVtYmVyc2hpcCBpbiBnbG9i YWwgZmlsZSBsaXN0Cj4gPiAgICogQHdxOgkJCXdhaXQgcXVldWUgZm9yIGZlbmNlIHNpZ25hbGlu Zwo+ID4gICAqIEBmZW5jZToJCWZlbmNlIHdpdGggdGhlIGZlbmNlcyBpbiB0aGUgc3luY19maWxl Cj4gPiBAQCAtMzEsNyArMzEsNyBAQAo+ID4gICAqLwo+ID4gIHN0cnVjdCBzeW5jX2ZpbGUgewo+ ID4gIAlzdHJ1Y3QgZmlsZQkJKmZpbGU7Cj4gPiAtCWNoYXIJCQluYW1lWzMyXTsKPiAKPiBNYXli ZSBpbmxpbmUga2VybmVsZG9jIGFuIGV4cGxhaW4gYSBiaXQgYmV0dGVyIHdoYXQncyBnb2luZyBv bjoKPiAKPiAJLyoqCj4gCSAqIEB1c2VyX25hbWU6Cj4gCSAqCj4gCSAqIE5hbWUgb2YgdGhlIHN5 bmMgZmlsZSBwcm92aWRlZCBieSB1c2Vyc3BhY2UsIGZvciBtZXJnZWQgZmVuY2VzLgo+IAkgKiBP dGhlcndpc2UgZ2VuZXJhdGVkIHRocm91Z2ggZHJpdmVyIGNhbGxiYWNrcyAoaW4gd2hpY2ggY2Fz ZSB0aGUKPiAJICogZW50aXJlIGFycmF5IGlzIDApLgo+IAkgKi8KPiAKPiBNaWdodCBiZSBvdmVy a2lsbCwgc28gbm90IGdvaW5nIHRvIGluc2lzdCBhdCBhbGwuIEVpdGhlciB3YXk6Cj4gCj4gUmV2 aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CgpJIGZpeGVk IGl0LiBBcHBsaWVkIHdpdGggdGhlIG1vZGlmaWNhdGlvbiBwcm9wb3NlZCBieSBEYW5pZWwuIFRo YW5rcyBmb3IKdGhlIHBhdGNoLgoKR3VzdGF2bwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==