From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Du, Changbin" Subject: Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected Date: Thu, 25 May 2017 14:09:44 +0800 Message-ID: <20170525060944.GA25623@intel.com> References: <1495615839-20797-1-git-send-email-changbin.du@intel.com> <87efvetrl1.fsf@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0157528777==" Return-path: In-Reply-To: <87efvetrl1.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com, intel-gvt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0157528777== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Jani, just relized you are in i915 team. :) > > +menu "Intel GVT-g graphics virtualization host support" > > + depends on DRM_I915 > > + depends on 64BIT > > + > > config DRM_I915_GVT > > - bool "Enable Intel GVT-g graphics virtualization host support" > > - depends on DRM_I915 > > - depends on 64BIT > > - default n > > - help > > + bool "Enable Intel GVT-g graphics virtualization host support" > > + default n > > + depends on DRM_I915_GVT_KVMGT > > + help >=20 > With this change, you can't actually change this config option. It's > purely subject to CONFIG_DRM_I915_GVT_KVMGT. You need to enable KVMGT to > even see this option, but enabling it will enable this one too. You > can't disable this before you disable KVMGT, but then disabling KVMGT > will disable this one too. This config option becomes pointless as a > visible option. Which isn't all that bad, considering > Documentation/kbuild/kconfig-language.txt: > Jani, this is by design in this patch. We will add another xengt hypervisor= glue layer to support XenGT. After that, enable DRM_I915_GVT only if at least on= e of KVMGT or XENGT enabled or both. Also it doesn't make sense that we only bui= ld KVMGT/XenGT module without DRM_I915_GVT. Such mechanism is not as straigforward as two simple 'choice', so I agree w= ith 'choice' if you prefer it. As you said, it is not a big problem. > Note: > select should be used with care. select will force > a symbol to a value without visiting the dependencies. > By abusing select you are able to select a symbol FOO even > if FOO depends on BAR that is not set. > In general use select only for non-visible symbols > (no prompts anywhere) and for symbols with no dependencies. > That will limit the usefulness but on the other hand avoid > the illegal configurations all over. >=20 Yes, we should always be carefull with 'select' and should not use it if possible. So here I must create a 'menu' to ensure its safety. > BR, > Jani. >=20 > > Choose this option if you want to enable Intel GVT-g graphics > > virtualization technology host support with integrated graphics. > > With GVT-g, it's possible to have one integrated graphics > > @@ -116,13 +119,14 @@ config DRM_I915_GVT > > =20 > > config DRM_I915_GVT_KVMGT > > tristate "Enable KVM/VFIO support for Intel GVT-g" > > - depends on DRM_I915_GVT > > + select DRM_I915_GVT > > depends on KVM > > depends on VFIO_MDEV && VFIO_MDEV_DEVICE > > default n > > help > > Choose this option if you want to enable KVMGT support for > > Intel GVT-g. > > +endmenu > > =20 > > menu "drm/i915 Debugging" > > depends on DRM_I915 >=20 > --=20 > Jani Nikula, Intel Open Source Technology Center > _______________________________________________ > intel-gvt-dev mailing list > intel-gvt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev --=20 Thanks, Changbin Du --d6Gm4EdcadzBjdND Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZJnUoAAoJEAanuZwLnPNUj+kH/Rqr9g15RgKnMI4DCRSXXC21 3a+ja34fgZvV6T1YatTEu1N2qdNN7ByQmndFkRfVFRaq5lStOy5BaBI9dU8Z7TqZ sY6mt3+FudZclH206uMO0bn3TGL0E6k4ksvtxyQNBBht05vUWpHf/Bb6ZFhKLVp1 NTXuV3k7kVd79etTCJY4tM86W/HamekhC896J7lyvQ2ZyFK3LO5R9QXEhl2s6mPZ p1YoRW/1oVb4ARZvj5+oYabOavJcyuu8Xhiq6n0s+QnAuObAo4TC4asAxColMQxc WAZS8wbFC/vt7MKCwQ3CILfTuhS05E+UFk2THXZIDdeqVbiGwrla0I9EmTTbMHQ= =AQOl -----END PGP SIGNATURE----- --d6Gm4EdcadzBjdND-- --===============0157528777== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0157528777==--