From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
"Rafael J . Wysocki " <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Borislav Petkov <bp@suse.de>,
intel-gfx@lists.freedesktop.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 4/5] ACPI / extlog: Switch to use new generic UUID API
Date: Wed, 31 May 2017 22:41:51 +0300 [thread overview]
Message-ID: <20170531194152.65927-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com>
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/acpi_extlog.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c
index 502ea4dc2080..6b101d595ccc 100644
--- a/drivers/acpi/acpi_extlog.c
+++ b/drivers/acpi/acpi_extlog.c
@@ -141,9 +141,9 @@ static int extlog_print(struct notifier_block *nb, unsigned long val,
int cpu = mce->extcpu;
struct acpi_hest_generic_status *estatus, *tmp;
struct acpi_hest_generic_data *gdata;
- const uuid_le *fru_id = &NULL_UUID_LE;
+ const guid_t *fru_id = &guid_null;
char *fru_text = "";
- uuid_le *sec_type;
+ guid_t *sec_type;
static u32 err_seq;
estatus = extlog_elog_entry_check(cpu, bank);
@@ -165,11 +165,11 @@ static int extlog_print(struct notifier_block *nb, unsigned long val,
err_seq++;
gdata = (struct acpi_hest_generic_data *)(tmp + 1);
if (gdata->validation_bits & CPER_SEC_VALID_FRU_ID)
- fru_id = (uuid_le *)gdata->fru_id;
+ fru_id = (guid_t *)gdata->fru_id;
if (gdata->validation_bits & CPER_SEC_VALID_FRU_TEXT)
fru_text = gdata->fru_text;
- sec_type = (uuid_le *)gdata->section_type;
- if (!uuid_le_cmp(*sec_type, CPER_SEC_PLATFORM_MEM)) {
+ sec_type = (guid_t *)gdata->section_type;
+ if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {
struct cper_sec_mem_err *mem = (void *)(gdata + 1);
if (gdata->error_data_length >= sizeof(*mem))
trace_extlog_mem_event(mem, err_seq, fru_id, fru_text,
@@ -182,17 +182,17 @@ static int extlog_print(struct notifier_block *nb, unsigned long val,
static bool __init extlog_get_l1addr(void)
{
- u8 uuid[16];
+ guid_t guid;
acpi_handle handle;
union acpi_object *obj;
- acpi_str_to_uuid(extlog_dsm_uuid, uuid);
-
+ if (guid_parse(extlog_dsm_uuid, &guid))
+ return false;
if (ACPI_FAILURE(acpi_get_handle(NULL, "\\_SB", &handle)))
return false;
- if (!acpi_check_dsm(handle, uuid, EXTLOG_DSM_REV, 1 << EXTLOG_FN_ADDR))
+ if (!acpi_check_dsm(handle, guid.b, EXTLOG_DSM_REV, 1 << EXTLOG_FN_ADDR))
return false;
- obj = acpi_evaluate_dsm_typed(handle, uuid, EXTLOG_DSM_REV,
+ obj = acpi_evaluate_dsm_typed(handle, guid.b, EXTLOG_DSM_REV,
EXTLOG_FN_ADDR, NULL, ACPI_TYPE_INTEGER);
if (!obj) {
return false;
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-31 19:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 19:41 [PATCH v2 0/5] ACPI et al: convert to use new UUID API Andy Shevchenko
2017-05-31 19:41 ` [PATCH v2 1/5] acpi, nfit: Switch to use new generic " Andy Shevchenko
2017-06-01 14:26 ` Dan Williams
2017-06-05 16:01 ` Christoph Hellwig
2017-06-05 16:18 ` Andy Shevchenko
2017-05-31 19:41 ` [PATCH v2 2/5] ACPI / APEI: " Andy Shevchenko
2017-05-31 23:56 ` kbuild test robot
2017-06-01 9:50 ` Andy Shevchenko
2017-06-05 16:01 ` Christoph Hellwig
2017-06-05 16:19 ` Andy Shevchenko
2017-06-05 16:22 ` Christoph Hellwig
2017-06-05 16:28 ` Andy Shevchenko
2017-05-31 19:41 ` [PATCH v2 3/5] ACPI / bus: " Andy Shevchenko
2017-05-31 22:42 ` Rafael J. Wysocki
2017-05-31 23:56 ` kbuild test robot
2017-06-01 0:05 ` kbuild test robot
2017-06-05 16:03 ` Christoph Hellwig
2017-06-05 16:20 ` Andy Shevchenko
2017-06-05 20:37 ` Rafael J. Wysocki
2017-06-06 9:58 ` Christoph Hellwig
2017-05-31 19:41 ` Andy Shevchenko [this message]
2017-06-05 16:06 ` [PATCH v2 4/5] ACPI / extlog: " Christoph Hellwig
2017-06-05 16:23 ` Andy Shevchenko
2017-06-05 21:23 ` Christoph Hellwig
2017-05-31 19:41 ` [PATCH v2 5/5] ACPI: Switch to use generic guid_t in acpi_evaluate_dsm() Andy Shevchenko
2017-05-31 20:21 ` Mark Brown
2017-05-31 22:42 ` Rafael J. Wysocki
2017-06-01 6:03 ` Christoph Hellwig
2017-06-01 0:08 ` kbuild test robot
2017-06-01 0:11 ` kbuild test robot
2017-06-01 14:12 ` Jarkko Sakkinen
2017-06-01 14:24 ` Dan Williams
2017-06-02 12:25 ` Adrian Hunter
2017-05-31 19:45 ` [PATCH v2 0/5] ACPI et al: convert to use new UUID API Christoph Hellwig
2017-05-31 19:45 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-05-31 20:07 ` [PATCH v2 0/5] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531194152.65927-5-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).