From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: s/fbc_fc/fbc_false_color/
Date: Tue, 6 Jun 2017 19:41:18 +0300 [thread overview]
Message-ID: <20170606164118.GH12629@intel.com> (raw)
In-Reply-To: <1496762119.2876.23.camel@rdvivi-vienna>
On Tue, Jun 06, 2017 at 03:15:09PM +0000, Vivi, Rodrigo wrote:
> On Tue, 2017-06-06 at 15:44 +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We're not that short on characters that we can't spell out
> > "false_color". Saves me from figuring out what "fc" means
> > the next time look at the code.
>
> Yeap, even I took a while to remember what was fc last time that I saw
> this...
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Pushed to dinq. Thanks for the review.
>
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 8fdb911344b3..a6ba2100bb88 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -1694,7 +1694,7 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
> > return 0;
> > }
> >
> > -static int i915_fbc_fc_get(void *data, u64 *val)
> > +static int i915_fbc_false_color_get(void *data, u64 *val)
> > {
> > struct drm_i915_private *dev_priv = data;
> >
> > @@ -1706,7 +1706,7 @@ static int i915_fbc_fc_get(void *data, u64 *val)
> > return 0;
> > }
> >
> > -static int i915_fbc_fc_set(void *data, u64 val)
> > +static int i915_fbc_false_color_set(void *data, u64 val)
> > {
> > struct drm_i915_private *dev_priv = data;
> > u32 reg;
> > @@ -1727,8 +1727,8 @@ static int i915_fbc_fc_set(void *data, u64 val)
> > return 0;
> > }
> >
> > -DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_fc_fops,
> > - i915_fbc_fc_get, i915_fbc_fc_set,
> > +DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_false_color_fops,
> > + i915_fbc_false_color_get, i915_fbc_false_color_set,
> > "%llu\n");
> >
> > static int i915_ips_status(struct seq_file *m, void *unused)
> > @@ -4869,7 +4869,7 @@ static const struct i915_debugfs_files {
> > {"i915_pri_wm_latency", &i915_pri_wm_latency_fops},
> > {"i915_spr_wm_latency", &i915_spr_wm_latency_fops},
> > {"i915_cur_wm_latency", &i915_cur_wm_latency_fops},
> > - {"i915_fbc_false_color", &i915_fbc_fc_fops},
> > + {"i915_fbc_false_color", &i915_fbc_false_color_fops},
> > {"i915_dp_test_data", &i915_displayport_test_data_fops},
> > {"i915_dp_test_type", &i915_displayport_test_type_fops},
> > {"i915_dp_test_active", &i915_displayport_test_active_fops},
>
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-06-06 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 12:44 [PATCH] drm/i915: s/fbc_fc/fbc_false_color/ ville.syrjala
2017-06-06 15:15 ` Vivi, Rodrigo
2017-06-06 16:41 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606164118.GH12629@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).