From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Make i915_gem_object_phys_attach() use obj->mm.lock more appropriately Date: Mon, 12 Jun 2017 16:46:40 +0300 Message-ID: <20170612134640.GB12629@intel.com> References: <20170608105344.4828-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBD666E0BC for ; Mon, 12 Jun 2017 13:46:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170608105344.4828-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMDgsIDIwMTcgYXQgMTE6NTM6NDRBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEFjdHVhbGx5IHRyYW5zZmVycmluZyBmcm9tIHNobWVtZnMgdG8gdGhlIHBoeXNpY2Fs bHkgY29udGlndW91cyBzZXQgb2YKPiBwYWdlcyBzaG91bGQgYmUgd2hvbGx5IGd1YXJkZWQgYnkg aXRzIG9iai0+bW0ubG9jayEKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz QGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYyB8IDQzICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCBhZmY0NDk4MDczOTkuLmRiMTY4ZTM5NWU4ZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC01NzQsNyArNTc0LDggQEAgaW50Cj4gIGk5 MTVfZ2VtX29iamVjdF9hdHRhY2hfcGh5cyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq LAo+ICAJCQkgICAgaW50IGFsaWduKQo+ICB7Cj4gLQlpbnQgcmV0Owo+ICsJc3RydWN0IHNnX3Rh YmxlICpwYWdlczsKPiArCWludCBlcnI7Cj4gIAo+ICAJaWYgKGFsaWduID4gb2JqLT5iYXNlLnNp emUpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gQEAgLTU4MiwzMiArNTgzLDQ0IEBAIGk5MTVfZ2Vt X29iamVjdF9hdHRhY2hfcGh5cyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAJ aWYgKG9iai0+b3BzID09ICZpOTE1X2dlbV9waHlzX29wcykKPiAgCQlyZXR1cm4gMDsKPiAgCj4g LQlpZiAob2JqLT5tbS5tYWR2ICE9IEk5MTVfTUFEVl9XSUxMTkVFRCkKPiAtCQlyZXR1cm4gLUVG QVVMVDsKPiAtCj4gLQlpZiAob2JqLT5iYXNlLmZpbHAgPT0gTlVMTCkKPiArCWlmIChvYmotPm9w cyAhPSAmaTkxNV9nZW1fb2JqZWN0X29wcykKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gLQly ZXQgPSBpOTE1X2dlbV9vYmplY3RfdW5iaW5kKG9iaik7Cj4gLQlpZiAocmV0KQo+IC0JCXJldHVy biByZXQ7Cj4gKwllcnIgPSBpOTE1X2dlbV9vYmplY3RfdW5iaW5kKG9iaik7Cj4gKwlpZiAoZXJy KQo+ICsJCXJldHVybiBlcnI7Cj4gKwo+ICsJbXV0ZXhfbG9jaygmb2JqLT5tbS5sb2NrKTsKPiAr Cj4gKwlpZiAob2JqLT5tbS5xdWlya2VkKSB7Cj4gKwkJZXJyID0gLUVGQVVMVDsKPiArCQlnb3Rv IGVycl91bmxvY2s7Cj4gKwl9Cj4gIAo+IC0JX19pOTE1X2dlbV9vYmplY3RfcHV0X3BhZ2VzKG9i aiwgSTkxNV9NTV9OT1JNQUwpOwoKQXJlIHdlIG5vdyBsZWFraW5nIHRoZSBvbGQgbW0ucGFnZXM/ Cgo+IC0JaWYgKG9iai0+bW0ucGFnZXMpCj4gLQkJcmV0dXJuIC1FQlVTWTsKPiArCWlmIChvYmot Pm1tLm1hcHBpbmcpIHsKPiArCQllcnIgPSAtRUJVU1k7Cj4gKwkJZ290byBlcnJfdW5sb2NrOwo+ ICsJfQo+ICAKPiAtCUdFTV9CVUdfT04ob2JqLT5vcHMgIT0gJmk5MTVfZ2VtX29iamVjdF9vcHMp Owo+ICsJcGFnZXMgPSBvYmotPm1tLnBhZ2VzOwo+ICAJb2JqLT5vcHMgPSAmaTkxNV9nZW1fcGh5 c19vcHM7Cj4gIAo+IC0JcmV0ID0gaTkxNV9nZW1fb2JqZWN0X3Bpbl9wYWdlcyhvYmopOwo+IC0J aWYgKHJldCkKPiArCWVyciA9IF9faTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlcyhvYmopOwo+ICsJ aWYgKGVycikKPiAgCQlnb3RvIGVycl94ZmVyOwo+ICAKPiArCS8qIFBlcm1hLXBpbiAodW50aWwg cmVsZWFzZSkgdGhlIHBoeXNpY2FsIHNldCBvZiBwYWdlcyAqLwo+ICsJX19pOTE1X2dlbV9vYmpl Y3RfcGluX3BhZ2VzKG9iaik7Cj4gKwo+ICsJbXV0ZXhfdW5sb2NrKCZvYmotPm1tLmxvY2spOwo+ ICAJcmV0dXJuIDA7Cj4gIAo+ICBlcnJfeGZlcjoKPiAgCW9iai0+b3BzID0gJmk5MTVfZ2VtX29i amVjdF9vcHM7Cj4gLQlyZXR1cm4gcmV0Owo+ICsJb2JqLT5tbS5wYWdlcyA9IHBhZ2VzOwo+ICtl cnJfdW5sb2NrOgo+ICsJbXV0ZXhfdW5sb2NrKCZvYmotPm1tLmxvY2spOwo+ICsJcmV0dXJuIGVy cjsKPiAgfQo+ICAKPiAgc3RhdGljIGludAo+IC0tIAo+IDIuMTEuMAo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrD pGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==