From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 1/2] drm/atomic: move waiting for hw_done to a helper Date: Wed, 14 Jun 2017 17:52:35 +0300 Message-ID: <20170614145235.GO12629@intel.com> References: <20170614090842.9669-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170614090842.9669-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdW4gMTQsIDIwMTcgYXQgMTE6MDg6NDFBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gTW92aW5nIHRoZSB3YWl0IHRvIGEgaGVscGVyIGFsbG93cyBjYWxsZXJzIG91 dHNpZGUgb2YgdGhlIGNvcmUgdG8KPiB3YWl0IGZvciBwZW5kaW5nIHVwZGF0ZXMgdG8gY29tcGxl dGUuCj4gCj4gVGhpcyBjYW4gYmUgdXNlZCB0byBwcmV2ZW50IHJhY2VzIGFnYWluc3Qgbm9uYmxv Y2tpbmcgbW9kZXNldHMuCj4gT25seSB0aGUgaHdfZG9uZSBjYWxsIGluIHN3YXBfc3RhdGUgaXMg bW92ZWQgdG8gYSBoZWxwZXIsIGRvaW5nCj4gaXQgZm9yIHRoZSBvdGhlciBjYWxsZXJzIHJlcXVp cmVzIHRvbyBtYW55IGNoYW5nZXMgYW5kIEkgdGhpbmsgdGhpcwo+IGlzIHRoZSBvbmx5IHVzZWZ1 bCBvbmUgdG8gZXhwb3J0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxt YWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljX2hlbHBlci5jIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLQo+ICBpbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oICAgICB8ICAxICsKPiAg MiBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IDg2ZDMwOTNjNmM5Yi4uMWIwNjhj ZTFhZWE5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAtMjA2Nyw2 ICsyMDY3LDQxIEBAIHZvaWQgZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFuZXMoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jbGVh bnVwX3BsYW5lcyk7Cj4gIAo+ICAvKioKPiArICogZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3Jf aHdfZG9uZSAtIHdhaXQgZm9yIGFsbCBwcmV2aW91cyBodyB1cGRhdGVzIHRvIGNvbXBsZXRlLgo+ ICsgKiBAY3J0YzogY3J0YyB0byB3YWl0IG9uLgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHdh aXRzIGZvciBhbGwgcHJldmlvdXMgaGFyZHdhcmUgdXBkYXRlcyBxdWV1ZWQgb24gQGNydGMKPiAr ICogdG8gY29tcGxldGUuCj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqIDAgb24gc3VjY2Vzcywg bmVnYXRpdmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ICsgKi8KPiAraW50IGRybV9hdG9taWNf aGVscGVyX3dhaXRfZm9yX2h3X2RvbmUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICt7Cj4gKwlz dHJ1Y3QgZHJtX2NydGNfY29tbWl0ICpjb21taXQ7Cj4gKwlsb25nIHJldDsKPiArCj4gKwlzcGlu X2xvY2soJmNydGMtPmNvbW1pdF9sb2NrKTsKPiArCWNvbW1pdCA9IGxpc3RfZmlyc3RfZW50cnlf b3JfbnVsbCgmY3J0Yy0+Y29tbWl0X2xpc3QsCj4gKwkJCXN0cnVjdCBkcm1fY3J0Y19jb21taXQs IGNvbW1pdF9lbnRyeSk7Cj4gKwlpZiAoY29tbWl0KQo+ICsJCWRybV9jcnRjX2NvbW1pdF9nZXQo Y29tbWl0KTsKPiArCXNwaW5fdW5sb2NrKCZjcnRjLT5jb21taXRfbG9jayk7Cj4gKwo+ICsJaWYg KCFjb21taXQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJcmV0ID0gd2FpdF9mb3JfY29tcGxldGlv bl90aW1lb3V0KCZjb21taXQtPmh3X2RvbmUsIDEwICogSFopOwo+ICsJZHJtX2NydGNfY29tbWl0 X3B1dChjb21taXQpOwo+ICsKPiArCWlmIChyZXQgPT0gMCkKPiArCQlyZXR1cm4gLUVCVVNZOwoK LUVUSU1FRE9VVCA/Cgo+ICsKPiArCXJldHVybiByZXQgPiAwID8gMCA6IHJldDsKPiArfQo+ICtF WFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2h3X2RvbmUpOwo+ICsKPiAr LyoqCj4gICAqIGRybV9hdG9taWNfaGVscGVyX3N3YXBfc3RhdGUgLSBzdG9yZSBhdG9taWMgc3Rh dGUgaW50byBjdXJyZW50IHN3IHN0YXRlCj4gICAqIEBzdGF0ZTogYXRvbWljIHN0YXRlCj4gICAq IEBzdGFsbDogc3RhbGwgZm9yIHByb2NlZWRpbmcgY29tbWl0cwo+IEBAIC0yMTA3LDI4ICsyMTQy LDE2IEBAIHZvaWQgZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21p Y19zdGF0ZSAqc3RhdGUsCj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRl LCAqbmV3X2NydGNfc3RhdGU7Cj4gIAlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiAgCXN0cnVj dCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9wbGFuZV9zdGF0ZSwgKm5ld19wbGFuZV9zdGF0ZTsKPiAt CXN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNvbW1pdDsKPiAgCXZvaWQgKm9iaiwgKm9ial9zdGF0 ZTsKPiAgCWNvbnN0IHN0cnVjdCBkcm1fcHJpdmF0ZV9zdGF0ZV9mdW5jcyAqZnVuY3M7Cj4gIAo+ ICAJaWYgKHN0YWxsKSB7Cj4gIAkJZm9yX2VhY2hfbmV3X2NydGNfaW5fc3RhdGUoc3RhdGUsIGNy dGMsIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4gLQkJCXNwaW5fbG9jaygmY3J0Yy0+Y29tbWl0X2xv Y2spOwo+IC0JCQljb21taXQgPSBsaXN0X2ZpcnN0X2VudHJ5X29yX251bGwoJmNydGMtPmNvbW1p dF9saXN0LAo+IC0JCQkJCXN0cnVjdCBkcm1fY3J0Y19jb21taXQsIGNvbW1pdF9lbnRyeSk7Cj4g LQkJCWlmIChjb21taXQpCj4gLQkJCQlkcm1fY3J0Y19jb21taXRfZ2V0KGNvbW1pdCk7Cj4gLQkJ CXNwaW5fdW5sb2NrKCZjcnRjLT5jb21taXRfbG9jayk7Cj4gKwkJCXJldCA9IGRybV9hdG9taWNf aGVscGVyX3dhaXRfZm9yX2h3X2RvbmUoY3J0Yyk7Cj4gIAo+IC0JCQlpZiAoIWNvbW1pdCkKPiAt CQkJCWNvbnRpbnVlOwo+IC0KPiAtCQkJcmV0ID0gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0 KCZjb21taXQtPmh3X2RvbmUsCj4gLQkJCQkJCQkgIDEwKkhaKTsKPiAtCQkJaWYgKHJldCA9PSAw KQo+ICsJCQlpZiAocmV0IDwgMCkKPiAgCQkJCURSTV9FUlJPUigiW0NSVEM6JWQ6JXNdIGh3X2Rv bmUgdGltZWQgb3V0XG4iLAo+ICAJCQkJCSAgY3J0Yy0+YmFzZS5pZCwgY3J0Yy0+bmFtZSk7Cj4g LQkJCWRybV9jcnRjX2NvbW1pdF9wdXQoY29tbWl0KTsKPiAgCQl9Cj4gIAl9Cj4gIAo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJt X2F0b21pY19oZWxwZXIuaAo+IGluZGV4IGYwYTg2NzhhZTk4ZS4uMTc1YTFhM2ZlZDM2IDEwMDY0 NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVyLmgKPiArKysgYi9pbmNsdWRl L2RybS9kcm1fYXRvbWljX2hlbHBlci5oCj4gQEAgLTc3LDYgKzc3LDcgQEAgdm9pZAo+ICBkcm1f YXRvbWljX2hlbHBlcl9kaXNhYmxlX3BsYW5lc19vbl9jcnRjKHN0cnVjdCBkcm1fY3J0Y19zdGF0 ZSAqb2xkX2NydGNfc3RhdGUsCj4gIAkJCQkJIGJvb2wgYXRvbWljKTsKPiAgCj4gK2ludCBkcm1f YXRvbWljX2hlbHBlcl93YWl0X2Zvcl9od19kb25lKHN0cnVjdCBkcm1fY3J0YyAqY3J0Yyk7Cj4g IHZvaWQgZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqc3RhdGUsCj4gIAkJCQkgIGJvb2wgc3RhbGwpOwo+ICAKPiAtLSAKPiAyLjExLjAKPiAKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApW aWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=