From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 01/14] drm: add HDMI 2.0 VIC support for AVI info-frames Date: Wed, 14 Jun 2017 22:20:32 +0200 Message-ID: <20170614202032.GA8856@ulmo> References: <1497462465-14066-1-git-send-email-shashank.sharma@intel.com> <1497462465-14066-2-git-send-email-shashank.sharma@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0856350729==" Return-path: In-Reply-To: <1497462465-14066-2-git-send-email-shashank.sharma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shashank Sharma Cc: Jose Abreu , ander.conselvan.de.oliveira@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org --===============0856350729== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 14, 2017 at 11:17:32PM +0530, Shashank Sharma wrote: [...] > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 2e55599..d312fe1 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -4334,12 +4334,14 @@ EXPORT_SYMBOL(drm_set_preferred_mode); > * data from a DRM display mode > * @frame: HDMI AVI infoframe > * @mode: DRM display mode > + * @is_hdmi2_sink: Sink is HDMI 2.0 compliant > * > * Return: 0 on success or a negative error code on failure. > */ > int > drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame, > - const struct drm_display_mode *mode) > + const struct drm_display_mode *mode, > + bool is_hdmi2_sink) Perhaps instead of passing a boolean flag here we could pass a const struct drm_hdmi_info *. That way the checks could be made more explicit and it becomes more obvious what to pass into the function. Also, as it is every driver will have to derive is_hdmi2_sink by itself, and they're likely to have to do the same thing as i915 anyway. Thierry --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAllBmo0ACgkQ3SOs138+ s6EXcA/+Pacqgt+7ltuNphDzamrDprTflKbNkJsSgqegpweCiME0EHL+1dE3umt2 JtLkeILPsKIDCxVAJCNHC5JIXldFto4Q/ETN02+ID1l/y6EJm1yG1ciL4+04GCiD XLFOX/NCQlJdeP7rLGRu3wWToQops5eM+tWR5kSirv6aUBQLmJ3jKcvDqAkOgH6r GUeB4LbRLjSyH16/kp9pWhhOJsl/TKGOny6pQse3n+puYUjcBofn47I4vAn53Oxm N3eh2BMIlfyFzyjdtWWlOVMzwLILbiqyQwCNxMPokp/zCRZSRJEtB+DeA8m/sjMn uo0SW8wdx6zHhXmxYZFl9Qr+xizZU93ccDh9/vAbCWFgZjoTN1TyHHyzMJLi6gn5 Z3LkQzfwXCrj8Bu2BFnsgVRvvHlcXAVGxShVczttd3qzeRxI08CtBw1iyOoJqPUo 9uHE9hpqe+8pOqT3MsfNdFs5auzzDlUxV/bQN2vR5GzS8FHooEStKr4+7cRlmMb8 2vhvcM4Yw75e8lChl1s/67Z1qw1Zf3VPdf24hyVUPFxoqj5qntKCPIc31mygmCwh blHEBBLh9AZCEkVYAcQQLeWDFpR1f5nfAZ7zEPwneeZTWiojuCR1sWZtgb1Ue+PD PDfkb8F1DtLoIs+d5xF1wVkpq2p+IHF2zMQrd9kLdw9Mni2LgOI= =9kb6 -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X-- --===============0856350729== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0856350729==--