intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Set value of fake mst encoder's hpd pin
@ 2017-06-15  1:38 Ethan Hsieh
  2017-06-15  2:00 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-06-15 10:27 ` [PATCH] " Ville Syrjälä
  0 siblings, 2 replies; 3+ messages in thread
From: Ethan Hsieh @ 2017-06-15  1:38 UTC (permalink / raw)
  To: intel-gfx, drm-intel-fixes; +Cc: ethan.hsieh

We receive hotplug event, but do not handle it. Set value of fake mst
encoder's hpd pin to handle hotplug event.

Before applying the patch:
[   36.595058] [drm:intel_get_hpd_pins [i915]] hotplug event received, stat 0x00200000, dig 0x10101012, pins 0x00000020
[   36.595172] [drm:i915_hotplug_work_func [i915]] running encoder hotplug functions

After applying the patch:
[   29.807410] [drm:intel_get_hpd_pins [i915]] hotplug event received, stat 0x00200000, dig 0x10101012, pins 0x00000020
[   29.807524] [drm:i915_hotplug_work_func [i915]] running encoder hotplug functions
[   30.086098] [drm:i915_hotplug_work_func [i915]] Connector DP-4 (pin 5) received hotplug event.
[   30.086123] [drm:i915_hotplug_work_func [i915]] [CONNECTOR:74:DP-4] status updated from connected to disconnected
[   30.086181] [drm:intel_dp_destroy_mst_connector [i915]]
[   30.087752] [drm:drm_helper_probe_single_connector_modes [drm_kms_helper]] [CONNECTOR:74:DP-4] disconnected
[   30.091979] [drm:drm_mode_setcrtc [drm]] [CRTC:39:pipe B]

Signed-off-by: Ethan Hsieh <ethan.hsieh@canonical.com>
---
 drivers/gpu/drm/i915/intel_dp_mst.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
index 3715386..2ef9f18 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -563,6 +563,7 @@ intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum
 	intel_encoder->type = INTEL_OUTPUT_DP_MST;
 	intel_encoder->power_domain = intel_dig_port->base.power_domain;
 	intel_encoder->port = intel_dig_port->port;
+	intel_encoder->hpd_pin = intel_dig_port->base.hpd_pin;
 	intel_encoder->crtc_mask = 0x7;
 	intel_encoder->cloneable = 0;
 
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Set value of fake mst encoder's hpd pin
  2017-06-15  1:38 [PATCH] drm/i915: Set value of fake mst encoder's hpd pin Ethan Hsieh
@ 2017-06-15  2:00 ` Patchwork
  2017-06-15 10:27 ` [PATCH] " Ville Syrjälä
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-06-15  2:00 UTC (permalink / raw)
  To: Ethan Hsieh; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Set value of fake mst encoder's hpd pin
URL   : https://patchwork.freedesktop.org/series/25810/
State : success

== Summary ==

Series 25810v1 drm/i915: Set value of fake mst encoder's hpd pin
https://patchwork.freedesktop.org/api/1.0/series/25810/revisions/1/mbox/

Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                fail       -> PASS       (fi-snb-2600) fdo#100007
Test kms_busy:
        Subgroup basic-flip-default-b:
                dmesg-warn -> FAIL       (fi-skl-6700hq) fdo#101144
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-skl-6700hq) fdo#100461

fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fdo#100461 https://bugs.freedesktop.org/show_bug.cgi?id=100461

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:445s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:431s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:587s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:505s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:485s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:490s
fi-glk-2a        total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:589s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:432s
fi-hsw-4770r     total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:16  time:414s
fi-ilk-650       total:278  pass:227  dwarn:0   dfail:0   fail:0   skip:50  time:418s
fi-ivb-3520m     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:18  time:489s
fi-ivb-3770      total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:18  time:471s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:470s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:571s
fi-kbl-r         total:278  pass:259  dwarn:1   dfail:0   fail:0   skip:18  time:581s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:460s
fi-skl-6700hq    total:278  pass:228  dwarn:1   dfail:0   fail:27  skip:22  time:405s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:464s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:484s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:441s
fi-snb-2520m     total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:28  time:540s
fi-snb-2600      total:278  pass:248  dwarn:0   dfail:0   fail:0   skip:29  time:403s

cafd1e4df1e6e039268c4e4b1a55c88915d21f2e drm-tip: 2017y-06m-14d-19h-56m-24s UTC integration manifest
4e64830 drm/i915: Set value of fake mst encoder's hpd pin

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4954/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Set value of fake mst encoder's hpd pin
  2017-06-15  1:38 [PATCH] drm/i915: Set value of fake mst encoder's hpd pin Ethan Hsieh
  2017-06-15  2:00 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-06-15 10:27 ` Ville Syrjälä
  1 sibling, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2017-06-15 10:27 UTC (permalink / raw)
  To: Ethan Hsieh; +Cc: intel-gfx, drm-intel-fixes

On Thu, Jun 15, 2017 at 09:38:10AM +0800, Ethan Hsieh wrote:
> We receive hotplug event, but do not handle it. Set value of fake mst
> encoder's hpd pin to handle hotplug event.

We're not supposed to handle it like that. The HPD is for the main encoder,
the MST hotplug handling comes via the topology manager.

> 
> Before applying the patch:
> [   36.595058] [drm:intel_get_hpd_pins [i915]] hotplug event received, stat 0x00200000, dig 0x10101012, pins 0x00000020
> [   36.595172] [drm:i915_hotplug_work_func [i915]] running encoder hotplug functions
> 
> After applying the patch:
> [   29.807410] [drm:intel_get_hpd_pins [i915]] hotplug event received, stat 0x00200000, dig 0x10101012, pins 0x00000020
> [   29.807524] [drm:i915_hotplug_work_func [i915]] running encoder hotplug functions
> [   30.086098] [drm:i915_hotplug_work_func [i915]] Connector DP-4 (pin 5) received hotplug event.
> [   30.086123] [drm:i915_hotplug_work_func [i915]] [CONNECTOR:74:DP-4] status updated from connected to disconnected
> [   30.086181] [drm:intel_dp_destroy_mst_connector [i915]]
> [   30.087752] [drm:drm_helper_probe_single_connector_modes [drm_kms_helper]] [CONNECTOR:74:DP-4] disconnected
> [   30.091979] [drm:drm_mode_setcrtc [drm]] [CRTC:39:pipe B]
> 
> Signed-off-by: Ethan Hsieh <ethan.hsieh@canonical.com>
> ---
>  drivers/gpu/drm/i915/intel_dp_mst.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> index 3715386..2ef9f18 100644
> --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> @@ -563,6 +563,7 @@ intel_dp_create_fake_mst_encoder(struct intel_digital_port *intel_dig_port, enum
>  	intel_encoder->type = INTEL_OUTPUT_DP_MST;
>  	intel_encoder->power_domain = intel_dig_port->base.power_domain;
>  	intel_encoder->port = intel_dig_port->port;
> +	intel_encoder->hpd_pin = intel_dig_port->base.hpd_pin;
>  	intel_encoder->crtc_mask = 0x7;
>  	intel_encoder->cloneable = 0;
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-15 10:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-15  1:38 [PATCH] drm/i915: Set value of fake mst encoder's hpd pin Ethan Hsieh
2017-06-15  2:00 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-06-15 10:27 ` [PATCH] " Ville Syrjälä

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).