Re: [PATCH v9 05/21] drm/i915: Add support for per engine reset recovery

Chris Wilson
2017-06-19T12:46:08Z

Quoting Michel Thierry (2017-06-15 21:18:12)
> @@ -2992,10 +3014,8 @@ void i915_gem_reset_finish(struct drm_i915_private *dev_priv)
>
> lockdep_assert_held(&dev_priv->drm.struct_mutex);
>
> - for_each_engine(engine, dev_priv, id) {
> - tasklet_enable(&engine->irq_tasklet);
> - kthread_unpark(engine->breadcrumbs.signaler);
> - }
> + for_each_engine(engine, dev_priv, id)
> + i915_gem_reset_finish_engine(engine);

And we shouldn't forget to clear the active_request here!
-Chris