From: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Lyude <lyude@redhat.com>
Subject: [PATCH i-g-t v4 2/3] chamelium: Remove init reset duplicate in favor of per-test reset
Date: Tue, 4 Jul 2017 16:33:18 +0300 [thread overview]
Message-ID: <20170704133319.5130-2-paul.kocialkowski@linux.intel.com> (raw)
In-Reply-To: <20170704133319.5130-1-paul.kocialkowski@linux.intel.com>
Since most tests are already doing a reset, there is no need to
duplicate it at init time. This removes that duplicate reset and adds
a call to reset_state where in-test resets where not done previously.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
---
lib/igt_chamelium.c | 2 --
tests/chamelium.c | 6 ++++++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 225f98c3..624f448b 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -1233,8 +1233,6 @@ struct chamelium *chamelium_init(int drm_fd)
if (!chamelium_read_config(chamelium, drm_fd))
goto error;
- chamelium_reset(chamelium);
-
cleanup_instance = chamelium;
igt_install_exit_handler(chamelium_exit_handler);
diff --git a/tests/chamelium.c b/tests/chamelium.c
index 346018a5..6247d537 100644
--- a/tests/chamelium.c
+++ b/tests/chamelium.c
@@ -431,6 +431,8 @@ test_display_crc_single(data_t *data, struct chamelium_port *port)
drmModeConnector *connector;
int fb_id, i;
+ reset_state(data, port);
+
output = prepare_output(data, &display, port);
connector = chamelium_port_get_connector(data->chamelium, port, false);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -485,6 +487,8 @@ test_display_crc_multiple(data_t *data, struct chamelium_port *port)
drmModeConnector *connector;
int fb_id, i, j, captured_frame_count;
+ reset_state(data, port);
+
output = prepare_output(data, &display, port);
connector = chamelium_port_get_connector(data->chamelium, port, false);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
@@ -544,6 +548,8 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
drmModeConnector *connector;
int fb_id, i, j;
+ reset_state(data, port);
+
output = prepare_output(data, &display, port);
connector = chamelium_port_get_connector(data->chamelium, port, false);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-04 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 13:33 [PATCH i-g-t v4 1/3] tests/chamelium: Update connector state without reprobe when possible Paul Kocialkowski
2017-07-04 13:33 ` Paul Kocialkowski [this message]
2017-07-06 15:45 ` [PATCH i-g-t v4 2/3] chamelium: Remove init reset duplicate in favor of per-test reset Lyude Paul
2017-07-04 13:33 ` [PATCH i-g-t v4 3/3] Make igtrc configuration common, with configurable suspend/resume delay Paul Kocialkowski
2017-07-06 15:57 ` Lyude Paul
2017-07-06 16:02 ` [PATCH i-g-t v4 1/3] tests/chamelium: Update connector state without reprobe when possible Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704133319.5130-2-paul.kocialkowski@linux.intel.com \
--to=paul.kocialkowski@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).