* [PATCH] drm/i915/cnl: Gen10 render context size.
@ 2017-07-06 21:06 Rodrigo Vivi
2017-07-06 23:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-07-07 2:51 ` [PATCH] " Ben Widawsky
0 siblings, 2 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2017-07-06 21:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi
No change on render context size is required for Gen10.
So this patch doesn't change the default behaviour,
but only avoid the missing_case message.
Cc: Ben Widawsky <benjamin.widawsky@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_engine_cs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index a55cd72..24db316 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -149,6 +149,7 @@ struct engine_info {
switch (INTEL_GEN(dev_priv)) {
default:
MISSING_CASE(INTEL_GEN(dev_priv));
+ case 10:
case 9:
return GEN9_LR_CONTEXT_RENDER_SIZE;
case 8:
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/cnl: Gen10 render context size.
2017-07-06 21:06 [PATCH] drm/i915/cnl: Gen10 render context size Rodrigo Vivi
@ 2017-07-06 23:22 ` Patchwork
2017-07-07 2:51 ` [PATCH] " Ben Widawsky
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-07-06 23:22 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Gen10 render context size.
URL : https://patchwork.freedesktop.org/series/26955/
State : success
== Summary ==
Series 26955v1 drm/i915/cnl: Gen10 render context size.
https://patchwork.freedesktop.org/api/1.0/series/26955/revisions/1/mbox/
Test kms_force_connector_basic:
Subgroup force-connector-state:
skip -> PASS (fi-ivb-3520m) fdo#101048 +3
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-j1900) fdo#101705 +1
fdo#101048 https://bugs.freedesktop.org/show_bug.cgi?id=101048
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:443s
fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:433s
fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:348s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:534s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:505s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:496s
fi-byt-n2820 total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:496s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:591s
fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:429s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:415s
fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:419s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:488s
fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:473s
fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:470s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:569s
fi-kbl-r total:279 pass:260 dwarn:1 dfail:0 fail:0 skip:18 time:591s
fi-pnv-d510 total:279 pass:221 dwarn:3 dfail:0 fail:0 skip:55 time:563s
fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:461s
fi-skl-6700hq total:279 pass:262 dwarn:0 dfail:0 fail:0 skip:17 time:592s
fi-skl-6700k total:279 pass:257 dwarn:4 dfail:0 fail:0 skip:18 time:466s
fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:473s
fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:443s
fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:542s
fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:408s
2132c198e6afd4ed75e89eee86c40c7def49c1dc drm-tip: 2017y-07m-06d-20h-24m-04s UTC integration manifest
6a788d0 drm/i915/cnl: Gen10 render context size.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_5135/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Gen10 render context size.
2017-07-06 21:06 [PATCH] drm/i915/cnl: Gen10 render context size Rodrigo Vivi
2017-07-06 23:22 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-07-07 2:51 ` Ben Widawsky
2017-07-07 16:38 ` Rodrigo Vivi
1 sibling, 1 reply; 5+ messages in thread
From: Ben Widawsky @ 2017-07-07 2:51 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On 17-07-06 14:06:24, Vivi, Rodrigo wrote:
>No change on render context size is required for Gen10.
>
>So this patch doesn't change the default behaviour,
>but only avoid the missing_case message.
>
>Cc: Ben Widawsky <benjamin.widawsky@intel.com>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/cnl: Gen10 render context size.
2017-07-07 2:51 ` [PATCH] " Ben Widawsky
@ 2017-07-07 16:38 ` Rodrigo Vivi
2017-07-14 17:33 ` Daniele Ceraolo Spurio
0 siblings, 1 reply; 5+ messages in thread
From: Rodrigo Vivi @ 2017-07-07 16:38 UTC (permalink / raw)
To: Ben Widawsky; +Cc: intel-gfx, Rodrigo Vivi
patch merged to dinq. thanks for reviewing.
On Thu, Jul 6, 2017 at 7:51 PM, Ben Widawsky
<benjamin.widawsky@intel.com> wrote:
> On 17-07-06 14:06:24, Vivi, Rodrigo wrote:
>>
>> No change on render context size is required for Gen10.
>>
>> So this patch doesn't change the default behaviour,
>> but only avoid the missing_case message.
>>
>> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
>
> [snip]
>
>
> --
> Ben Widawsky, Intel Open Source Technology Center
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/cnl: Gen10 render context size.
2017-07-07 16:38 ` Rodrigo Vivi
@ 2017-07-14 17:33 ` Daniele Ceraolo Spurio
0 siblings, 0 replies; 5+ messages in thread
From: Daniele Ceraolo Spurio @ 2017-07-14 17:33 UTC (permalink / raw)
To: Rodrigo Vivi, Ben Widawsky; +Cc: intel-gfx, Rodrigo Vivi
Hi,
I'm a bit late to the party, but as I already mentioned at [1] the CNL
render ctx size is smaller than the gen9 one according to the specs. The
ctx format in the specs contains 16752 dwords, i.e. 17 pages, to which
we need to add 1 page for the PPHWSP, so 18 pages total. If we re-use
the gen9 size we end up wasting 4 pages per lrc.
I don't have access to a CNL to test this but I've been told that a
setup using 19 pages (1 more for safety) has been tested successfully on
CNL.
-Daniele
[1] https://lists.freedesktop.org/archives/intel-gfx/2017-April/125321.html
On 07/07/17 09:38, Rodrigo Vivi wrote:
> patch merged to dinq. thanks for reviewing.
>
> On Thu, Jul 6, 2017 at 7:51 PM, Ben Widawsky
> <benjamin.widawsky@intel.com> wrote:
>> On 17-07-06 14:06:24, Vivi, Rodrigo wrote:
>>>
>>> No change on render context size is required for Gen10.
>>>
>>> So this patch doesn't change the default behaviour,
>>> but only avoid the missing_case message.
>>>
>>> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
>>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>
>>
>> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
>>
>> [snip]
>>
>>
>> --
>> Ben Widawsky, Intel Open Source Technology Center
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-14 17:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-06 21:06 [PATCH] drm/i915/cnl: Gen10 render context size Rodrigo Vivi
2017-07-06 23:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-07-07 2:51 ` [PATCH] " Ben Widawsky
2017-07-07 16:38 ` Rodrigo Vivi
2017-07-14 17:33 ` Daniele Ceraolo Spurio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox