From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 21/22] drm/atomic: Introduce drm_atomic_helper_duplicate_commited_state() Date: Fri, 7 Jul 2017 18:18:12 +0300 Message-ID: <20170707151812.GF12629@intel.com> References: <20170706202442.5394-1-ville.syrjala@linux.intel.com> <20170706202442.5394-22-ville.syrjala@linux.intel.com> <20170707120338.tahioabaifi7gpi7@phenom.ffwll.local> <20170707132157.GD12629@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx , dri-devel List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdWwgMDcsIDIwMTcgYXQgMDQ6MDU6MjhQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIEp1bCA3LCAyMDE3IGF0IDM6MjEgUE0sIFZpbGxlIFN5cmrDpGzDpAo+ IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBGcmksIEp1bCAw NywgMjAxNyBhdCAwMjowMzozOFBNICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4+IE9u IFRodSwgSnVsIDA2LCAyMDE3IGF0IDExOjI0OjQxUE0gKzAzMDAsIHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tIHdyb3RlOgo+ID4+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+PiA+Cj4gPj4gPiBGb3IgaTkxNSBHUFUgcmVzZXQg aGFuZGxpbmcgd2UnbGwgd2FudCB0byBiZSBhYmxlIHRvIGR1cGxpY2F0ZSB0aGUgc3RhdGUKPiA+ PiA+IHRoYXQgd2FzIGxhc3QgY29tbWl0ZWQgdG8gdGhlIGhhcmR3YXJlLiBGb3IgdGhhdCBwdXJw b3NlIGxldCdzIHN0YXJ0IHRvCj4gPj4gPiB0cmFjayB0aGUgY29tbWl0ZWQgc3RhdGUgZm9yIGVh Y2ggb2JqZWN0IGFuZCBwcm92aWRlIGEgd2F5IHRvIGR1cGxpY2F0ZQo+ID4+ID4gdGhlIGNvbW1t aXRlZCBzdGF0ZSBpbnRvIGEgbmV3IGRybV9hdG9taWNfc3RhdGUuIFRoZSBsb2NraW5nIGZvcgo+ ID4+ID4gLmNvbW1pdGVkX3N0YXRlIG11c3QgdG8gYmUgcHJvdmlkZWQgYnkgdGhlIGRyaXZlci4K PiA+PiA+Cj4gPj4gPiBkcm1fYXRvbWljX2hlbHBlcl9kdXBsaWNhdGVfY29tbWl0ZWRfc3RhdGUo KSBkdXBsaWNhdGVzIHRoZSBzdGF0ZQo+ID4+ID4gdG8gYm90aCBvbGRfc3RhdGUgYW5kIG5ld19z dGF0ZS4gRm9yIHRoZSBwdXJwb3NlcyBvZiBpOTE1IEdQVSByZXNldCB3ZQo+ID4+ID4gd291bGQg b25seSBuZWVkIG9uZSBvZiB0aGVtLCBidXQgd2UgYWN0dWFsbHkgbmVlZCB0d28gdG9wIGxldmVs IHN0YXRlczsKPiA+PiA+IG9uZSBmb3IgZGlzYWJsaW5nIGV2ZXJ5dGhpbmcgKHdoaWNoIHdvdWxk IG5lZWQgdGhlIGR1cGxpY2F0ZWQgc3RhdGUgdG8KPiA+PiA+IGJlIG9sZF9zdGF0ZSksIGFuZCBh bm90aGVyIHRvIHJlZW5hYmxlIGV2ZXJ5dGhpbmcgKHdoaWNoIHdvdWxkIG5lZWQgdGhlCj4gPj4g PiBkdXBsaWNhdGVkIHN0YXRlIHRvIGJlIG5ld19zdGF0ZSkuIFNvIHRvIG1ha2UgaXQgbGVzcyBj b21wbGVzIEkgZmlndXJlZAo+ID4+ID4gSSdkIGp1c3QgYWx3YXlzIGR1cGxpY2F0ZSBib3RoLiBN aWdodCB3YW50IHRvIHJldGhpbmsgdGhpcyBpZiBmb3Igbm8KPiA+PiA+IG90aGVyIHJlYXNvbiB0 aGF0IHJlZHVjaW5nIHRoZSBjaGFuY2VzIG9mIG1lbW9yeSBhbGxvY2F0aW9uIGZhaWx1cmUuCj4g Pj4gPiBEdWUgdG8gdGhlIGRvdWJsZSBzdGF0ZSBkdXBsaWNhdGlvbiB3ZSBuZWVkCj4gPj4gPiBk cm1fYXRvbWljX2hlbHBlcl9jbGVhbl9jb21taXRlZF9zdGF0ZSgpIHRvIGNsZWFuIHVwIHRoZSBk dXBsaWNhdGVkCj4gPj4gPiBvbGRfc3RhdGUgc2luY2UgdGhhdCdzIG5vdCBoYW5kbGVkIGJ5IHRo ZSBub3JtYWwgZHJtX2F0b21pY19zdGF0ZQo+ID4+ID4gY2xlYW51cCBjb2RlLgo+ID4+ID4KPiA+ PiA+IFRPRE86IGRvIHdlIHdhbnQgdGhpcyBpbiB0aGUgaGVscGVyLCBvciBtYXliZSBpdCBzaG91 bGQgYmUganVzdCBpbiBpOTE1Pwo+ID4+ID4KPiA+PiA+IHYyOiBzL2NvbW1pdGVkL2NvbW1pdHRl ZC8gZXZlcnl3aGVyZSAoY2hlY2twYXRjaCkKPiA+PiA+ICAgICBIYW5kbGUgc3RhdGUgZHVwbGlj YXRpb24gZXJyb3JzIGJldHRlcgo+ID4+ID4gdjM6IEV2ZW4gbW9yZSBjYXJlIGluIGRlYWxpbmcg d2l0aCBtZW1vcnkgYWxsb2NhdGlvbiBlcnJvcnMKPiA+PiA+ICAgICBIYW5kbGUgcHJpdmF0ZSBv YmpzIHRvbwo+ID4+ID4gICAgIERlYWwgd2l0aCB0aGUgcG90ZW50aWFsIG9yZGVyaW5nIGlzc3Vl cyBiZXR3ZWVuIHN3YXBfc3RhdGUoKQo+ID4+ID4gICAgIGFuZCBod19kb25lKCkgYnkga2VlcGlu ZyB0cmFjayBvZiB3aGljaCBzdGF0ZSB3YXMgc3dhcHBlZCBpbgo+ID4+ID4gICAgIGxhc3QKPiA+ PiA+Cj4gPj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4+Cj4gPj4gSSBzdGlsbCBkb24ndCBnZXQgd2h5IHdlIG5lZWQg dG8gZHVwbGljYXRlIHRoZSBjb21taXR0ZWQgc3RhdGUgZm9yIGdwdQo+ID4+IHJlc2V0LiBXaGVu IEkgc2FpZCBJJ20gbm90IGFnYWluc3QgYWRkaW5nIGFsbCB0aGF0IGNvbXBsZXhpdHkgbG9uZy10 ZXJtIEkKPiA+PiBtZWFudCB3aGVuIHdlIGFjdHVhbGx5IHJlYWxseSBuZWVkIGl0LiBJbW8gZzR4 IGdwdSByZXNldCBpc24ndCBhIGdvb2QKPiA+PiBqdXN0aWZpY2F0aW9uIGZvciB0aGF0LCByZXdv cmtpbmcgdGhlIGF0b21pYyB3b3JsZCBmb3IgdGhhdCBzZWVtcwo+ID4+IG1hc3NpdmVseSBvdXQg b2YgcHJvcG9ydGlvbi4KPiA+Cj4gPiBXZWxsLCBJIHN0aWxsIGRvbid0IHNlZSB3aGF0J3Mgc28g Im1hc3NpdmUiIGFib3V0IGEgY291cGxlIG9mIGV4dHJhIHN0YXRlCj4gPiBwb2ludGVycyBoYW5n aW5nIGFyb3VuZC4KPiA+Cj4gPiBBbHNvIHdoaWxlIGRvaW5nIHRoYXQgc3RhdGUgZHVwbGljYXRp b24gc3R1ZmYsIG15IG9sZCBpZGVhIG9mCj4gPiBzcGxpdHRpbmcgdGhlIGNydGMgZGlzYWJsZSBh bmQgZW5hYmxlIHBoYXNlcyBpbnRvIHNlcGFyYXRlIGF0b21pYwo+ID4gY29tbWl0cyBwb3BwZWQg dXAgYWdhaW4gaW4gbXkgaGVhZC4gRm9yIHRoYXQgYmVpbmcgYWJsZSB0byBkdXBsaWNhdGUKPiA+ IGFyYml0cmFyeSBzdGF0ZXMgd291bGQgc2VlbSBsaWtlIGEgbmljZSB0aGluZyB0byBoYXZlLiBT byB0aGUKPiA+IHJlZmFjdG9yaW5nIEkgaGFkIHRvIGRvIGNhbiBoYXZlIG90aGVyIHVzZXMuCj4g Cj4gSSBmdWxseSByZWFsaXplIHRoYXQgeW91J3JlIHVuaGFwcHkgd2l0aCBob3cgYXRvbWljIGVu ZGVkIHVwIGdldHRpbmcKPiBtZXJnZWQgYW5kIHRoYXQgeW91IHRoaW5rIGl0J3MgYSBncmF2ZSBt aXN0YWtlLiBBbmQgbWF5YmUgaXQgaXMsIG1heWJlCj4gaXQgaXNuJ3QsIEkgaGF2ZSBubyBpZGVh LgoKSSBkb24ndCB0aGluayBJIGV2ZXIgc2FpZCB0aGF0LiBJJ3ZlIHNhaWQgdGhhdCBpdCBoYXMg Y2VydGFpbiBkZXNpZ24KcHJvYmxlbXMgdGhhdCB3ZSBvdWdodCB0byBmaXguIFRoaXMgb25lIGJl aW5nIG9uZSwgYW5kIGFub3RoZXIgYmVpbmcKdG8gc2VwYXJhdGUgdGhlIHVzZXIgc3RhdGUgZnJv bSB0aGUgaW50ZXJuYWwgc3RhdGUuIFRoZSBsYXR0ZXIgSSB0aGluawp3ZSdsbCBoYXZlIHRvIHRh Y2tsZSByYXRoZXIgc29vbiB0aGFua3MgdG8gc29tZSBuZXcgaGFyZHdhcmUgaW4gdGhlCnBpcGVs aW5lLCBvciB3ZSBuZWVkIHRvIGNvbWUgdXAgd2l0aCBzb21lIG90aGVyIHdheSB0byBhY2hpZXZl IHRoZQpzYW1lIGVmZmVjdC4KCj4gQnV0IHJpZ2h0IG5vdyB3ZSBoYXZlIF9ub3RoaW5nXyBhc2tp bmcgZm9yCj4gdGhhdCByZW9yZyBhZmFpaywgYW5kIHVzaW5nIGdlbjQgcmVzZXQgdG8ganVzdGlm eSBpdCBpcyBpbiBteSBvcGluaW9uCj4gc2ltcGx5IG5vdCBzb2xpZCBlbmdpbmVlcmluZyBwcmFj dGljZS4gTWF5YmUgd2UgbmVlZCB0aGlzIGluIHRoZQo+IGZ1dHVyZSwgYW5kIHRoZW4gd2UgY2Fu IGFkZCBpdCwgYnV0IG5vdCBiZWZvcmUuIFJlZmFjdG9yaW5nIHN0dWZmIHRvCj4gcHJldHRpZnkg dGhlIGFyY2hpdGVjdHVyZSBpc24ndCByZWFsbHkgdXNlZnVsIHdvcmsuCgpOZWl0aGVyIGlzIGhh dmluZyB0byB0aHJvdyBvdXQgY29kZSB0aGF0IGFscmVhZHkgZXhpc3RzIGFuZCB3b3Jrcy4gSWYK eW91J3JlIHNvIHdvcnJpZWQgYWJvdXQgdGltZSBiZWluZyB3YXN0ZWQgb24gcHJlLWc0eCBHUFUg cmVzZXQsIHRoZW4Kd2UgY291bGQganVzdCBhcyB3ZWxsIG1lcmdlIG15IGNvZGUgYW5kIG1vdmUg b24gdG8gbW9yZSBwcm9kdWN0aXZlCmVuZGVhdm9ycy4KCj4gCj4gPj4gV2h5IGV4YWN0bHkgY2Fu J3Qgd2UgZG8gdGhpcyBzaW1wbGVyPyBJIHN0aWxsIGRvbid0IGdldCB0aGF0IHBhcnQuIElzCj4g Pj4gdGhlcmUgcmVhbGx5IG5vIHNvbHV0aW9uIHRoYXQgZG9lc24ndCBicmVhayBhdG9taWMncyBj dXJyZW50IGFzc3VtcHRpb24KPiA+PiB0aGF0IGNvbW1pdHMgYXJlIGZ1bGx5IG9yZGVyZWQgb24g YSBnaXZlbiBjcnRjPwo+ID4KPiA+IEZyb20gdGhlIHBvaW50IG9mIHZpZXcgb2YgdGhlIG9sZCBh bmQgbmV3IHN0YXRlcyBpdCBkb2Vzbid0IGFjdHVhbGx5Cj4gPiBicmVhayB0aGF0LiBUaGUgY29t bWl0cyBkb25lIGZyb20gdGhlIHJlc2V0IHBhdGggYXJlIGVzc2VudGlhbGx5Cj4gPiBpbnZpc2li bGUgdG8gdGhlIG5vcm1hbCBtb2Rlc2V0IG9wZXJhdGlvbi4KPiAKPiBZb3UgaW5zZXJ0IHNvbWV0 aGluZyBpbnRvIGEgZnVsbHkgb3JkZXJlZCBxdWV1ZS4gVGhhdCBkb2VzIGJyZWFrIHRoZQo+IGVu dGlyZSBjb25jZXB0IGFuZCBuZWVkcyBhIHBpbGUgb2YgbG9ja3MgYW5kIHN0dWZmIHRvIG1ha2Ug aXQgd29yay4KCkV4YWN0bHkgb25lIGxvY2suIFdlbGwgdHdvIGlmIHlvdSBjb3VsZCB0aGUgc3Bp bmxvY2sgdG8gcHJvdGVjdCB0aGUKY29tbWl0dGVkX3N0YXRlIHBvaW50ZXIgdXBkYXRlIGZyb20g cGFyYWxsZWwgdXBkYXRlcyB0b3VjaGluZyB0aGUgc2FtZQprbXMgb2JqZWN0LiBUaGF0IGxhdHRl ciBvbmUgY291bGQgYmUgcmVtb3ZlZCBpZiBhdG9taWMgd291bGRuJ3QgYWxsb3cKcGFyYWxsZWwg Y29tbWl0cyB0byB0b3VjaCB0aGUgc2FtZSBvYmplY3QuCgo+IFllcyBpdCdzIGRvYWJsZSwgYnV0 IGl0J3MgYSByZWRlc2lnbiB3aXRoIGFsbCB0aGUgaW1wbGljYXRpb25zIG9mCj4gc3VidGxlIGJy ZWFrYWdlIGFsbCBvdmVyLgoKV2hhdD8gSXQgZG9lc24ndCByZWFsbHkgZXZlbiBkbyBhbnl0aGlu ZyB1bmxlc3MgeW91IGRvIHRoZQpkdXBsaWNhdGVfY29tbWl0dGVkIHN0YXRlKCkuIEV2ZXJ5dGhp bmcgZWxzZSBpcyBqdXN0IGFzc2lnbmluZyBwb2ludGVycy4KU28gdW5sZXNzIHRoZXJlJ3Mgc29t ZSByZWFsbHkgb2J2aW91cyBidWcgc29tZXdoZXJlIGl0IGNhbid0IGJyZWFrCmFueXRoaW5nIG91 dHNpZGUgdGhlIEdQVSByZXNldCBwYXRoLiBBbmQgcmVhbGx5IHRoZSBvbmx5IHdheSB0byBicmVh awp0byBHUFUgcmVzZXQgcGF0aCBpcyB0byBoYXZlIGFjdHVhbCBidWdzIGluIHRoZSBub3JtYWwg ZGlzcGxheSBjb21taXQKY29kZS4KCj4gV2hpbGUgd2UgZG8gaGF2ZSBvcGVuIGJ1Z3MgZm9yIHRo ZSBjdXJyZW50Cj4gZGVzaWduLiBSZXdyaXRpbmcgdGhlIHdvcmxkIHRvIGZpeCBhIGJ1ZyBuZWVk cyBzZXJpb3VzbHkgYmV0dGVyCj4ganVzdGlmaWNhdGlvbiBpbW8uCj4gCj4gPiBUaGUgb25lIGFs dGVybmF0aXZlIHByb3Bvc2VkIGlkZWEgb2YgYWxsb3dpbmcgZ2VtIGFuZCBrbXMgc2lkZXMgZ28K PiA+IG91dCBvZiB3aGFjayBzY2FyZXMgbWUgYSBiaXQuIEkgdGhpbmsgdGhhdCBtaWdodCBsYW5k IHVzIGluIG1vcmUKPiA+IHRyb3VibGUgd2hlbiBJIGZpbmFsbHkgZ2V0IGFyb3VuZCB0byBtYWtp bmcgdGhlIHZpZGVvIG92ZXJsYXkgYQo+ID4gZHJtX3BsYW5lLgo+IAo+IFdlJ3ZlIHJ1biBwZXJm ZWN0bHkgZmluZSB3aXRoIHRoaXMgaWRlYSBmb3IgeWVhcnMuCgpOb3QgcGVyZmVjdGx5LiBJJ3Zl IGhhZCB0byBmaXggaXQgc2V2ZXJhbCB0aW1lcy4gQW5kIEkgZG9uJ3QgdGhpbmsgSSB3YXMKdGhl IG9ubHkgb25lLgoKPiAKPiA+IEFuZCBJIHRoaW5rIHRyeWluZyB0byBrZWVwIHRoZSBHUFUgcmVz ZXQgcGF0aHMgYXMgc2ltaWxhciBhcyBwb3NzaWJsZQo+ID4gYmV0d2VlbiBhbGwgdGhlIHBsYXRm b3JtcyB3b3VsZCBiZSBhIG5pY2UgdGhpbmcuIEp1c3Qgd2hhY2tpbmcKPiA+IGV2ZXJ5dGhpbmcg b24gdGhlIGhlYWQgd2l0aCBhIGhhbW1lciBvbiBvbmUgcGxhdGZvcm0gYnV0IG5vdCBvbgo+ID4g YW5vdGhlciBvbmUgc2VlbXMgdG8gbWUgbGlrZSBleHRyYSB2YXJpYXRpb24gaW4gYmVoYXZpb3Vy IHRoYXQgd2UKPiA+IGRvbid0IG5lY2Vzc2FyaWx5IHdhbnQuCj4gPgo+ID4gQnV0IGxpa2UgSSBz YWlkLCBpZiBzb21lb25lIGNhbiBjb21lIHVwIHdpdGggYSBiZXR0ZXIgc29sdXRpb24gSQo+ID4g cHJvYmFibHkgd291bGRuJ3Qgb2JqZWN0IHRvbyBtdWNoLiBJdCdzIG5vdCBnb2luZyB0byBiZSBj b21pbmcgZnJvbSBtZQo+ID4gdGhvdWdoIHNpbmNlIEkgaGF2ZSBwbGVudHkgb2Ygb3RoZXIgdGhp bmdzIHRvIGRvIGFuZCB2YWNhdGlvbiB0aW1lIGlzCj4gPiBjb21pbmcgdXAgdmVyeSBzb29uLiBT byB1bmxlc3Mgc29tZW9uZSBlbHNlIGNvbWVzIHVwIHdpdGggc29tZXRoaW5nIG5pY2UKPiA+IHNv b24gSSB0aGluayB3ZSBzaG91bGQganVzdCBnbyB3aXRoIG15IHNvbHV0aW9uIGJlY2F1c2UgYSkg aXQncyBhbHJlYWR5Cj4gPiBhdmFpbGFibGUsIGFuZCBiKSB3b3JrcyBxdWl0ZSBkZWNlbnRseSBm cm9tIHdoYXQgSSBjYW4gc2VlLgo+IAo+IEkgZ3Vlc3MgSSdsbCBoYXZlIHRvIHJldHlwZSB0aGUg b2xkIHRoaW5nIGluIHRoZSBuZXcgd29ybGQsIGJ1dCBpdAo+IHJlYWxseSBzaG91bGRuJ3QgYmUg bW9yZSB0aGFuIHRoZSBxdWljayBkcmFmdCBJJ3ZlIGxhaWQgZG93biBpbiB0aGUKPiBvbGQgdGhy ZWFkLiBUaGlzIGhlcmUgaXMgaW1vIG5vLWdvIHdpdGggYWxsIHRoZSBjb3JlIGNoYW5nZXMsIGFu ZCBldmVuCj4ganVzdCBkb25lIHdpdGhpbiBpOTE1IEkgdGhpbmsgaXQncyBoaWdobHkgZHViaW91 cyB0aGF0IGl0IHByb3ZpZGVzIGEKPiByZWFsIGJlbmVmaXQsIHNpbmNlIGRlZmFjdG8gaXQgbWVh bnMgd2UnbGwgaGF2ZSB0byBhYmFuZG9uIHRoZSBhdG9taWMKPiBoZWxwZXJzIGVudGlyZWx5LgoK Tm93IEkgdGhpbmsgeW91J3JlIGp1c3QgYmVpbmcgZGlmZmljdWx0IGZvciB0aGUgc2FrZSBvZiBp dC4gSGF2ZSB5b3UKbG9va2VkIGF0IHRoZSBjb2RlIGF0IGFsbD8gSXQncyBmdWxseSBkb25lIGZy b20gdGhlIGF0b21pYyBoZWxwZXJzCnJpZ2h0IG5vdy4gQW5kIGV2ZW4gbW92aW5nIHRoZSBjb21t aXR0ZWQgc3RhdGUgdHJhY2tpbmcgdG8gaTkxNQp3b3VsZG4ndCByZXF1aXJlIGFiYW5kb25pbmcg dGhlIGhlbHBlcnMuIFdlIGNvdWxkIGp1c3QgdXBkYXRlIHRoZQpjb21taXR0ZWQgc3RhdGUgcG9p bnRlcnMgd2hlbiB3ZSBjYWxsIGh3X2RvbmUoKSwgYW5kIHdlJ2QgaGF2ZSB0bwp1cGRhdGUgdGhl IHN0YXRlIHNlcW5vL2FnZSB0aW1lc3RhbXAgd2hlbiB3ZSBjYWxsIHN3YXBfc3RhdGUoKS4KVGhh dCdzIGFsbCB0aGVyZSBpcyB0byB0aGlzLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==