From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Bride Subject: Re: [PATCH v3 2/4] drm/i915/psr: Account for sink CRC raciness on some panels Date: Fri, 14 Jul 2017 09:04:58 -0700 Message-ID: <20170714160458.GA18144@shiv> References: <1499811596-14634-1-git-send-email-jim.bride@linux.intel.com> <1499811596-14634-3-git-send-email-jim.bride@linux.intel.com> <878tjrl5b3.fsf@nikula.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id B26D56E87D for ; Fri, 14 Jul 2017 16:07:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <878tjrl5b3.fsf@nikula.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdWwgMTQsIDIwMTcgYXQgMTI6NDY6MDhQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAxMSBKdWwgMjAxNywgSmltIEJyaWRlIDxqaW0uYnJpZGVAbGludXguaW50 ZWwuY29tPiB3cm90ZToKPiA+IEFjY29yZGluZyB0byB0aGUgZURQIHNwZWMsIHdoZW4gdGhlIGNv dW50IGZpZWxkIGluIFRFU1RfU0lOS19NSVNDCj4gPiBpbmNyZW1lbnRzIHRoZW4gdGhlIHNpeCBi eXRlcyBvZiBzaW5rIENSQyBpbmZvcm1hdGlvbiBpbiB0aGUgRFBDRAo+ID4gc2hvdWxkIGJlIHZh bGlkLiAgVW5mb3J0dW5hdGVseSwgdGhpcyBkb2Vzbid0IHNlZW0gdG8gYmUgdGhlIGNhc2UKPiA+ IG9uIHNvbWUgcGFuZWxzLCBhbmQgYXMgYSByZXN1bHQgd2UgZ2V0IHNvbWUgaW5jb3JyZWN0IGFu ZCBpbmNvbnNpc3RlbnQKPiA+IHZhbHVlcyBmcm9tIHRoZSBzaW5rIENSQyBEUENEIGxvY2F0aW9u cyBhdCB0aW1lcy4gIFRoaXMgcHJvYmxlbSBleGhpYml0cwo+ID4gaXRzZWxmIG1vcmUgb24gZmFz dGVyIHByb2Nlc3NvcnMgKHJlbGF0aXZlIGZhaWx1cmUgcmF0ZXMgSFNXIDwgU0tMIDwgS0JMLikK PiA+IEluIG9yZGVyIHRvIHRyeSBhbmQgYWNjb3VudCBmb3IgdGhpcywgd2UgdHJ5IGEgbG90IGhh cmRlciB0byByZWFkIHRoZSBzaW5rCj4gPiBDUkMgdW50aWwgd2UgZ2V0IGNvbnNpc3RlbnQgdmFs dWVzIHR3aWNlIGluIGEgcm93IGJlZm9yZSByZXR1cm5pbmcgd2hhdCB3ZQo+ID4gcmVhZCBhbmQg ZGVsYXkgZm9yIGEgdGltZSBiZWZvcmUgdHJ5aW5nIHRvIHJlYWQuICBXZSBzdGlsbCBzZWUgc29t ZQo+ID4gb2NjYXNpb25hbCBmYWlsdXJlcywgYnV0IHJlYWRpbmcgdGhlIHNpbmsgQ1JDIGlzIG11 Y2ggbW9yZSByZWxpYWJsZSwKPiA+IHBhcnRpY3VsYXJseSBvbiBTS0wgYW5kIEtCTCwgd2l0aCB0 aGVzZSBjaGFuZ2VzIHRoYW4gd2l0aG91dC4KPiA+Cj4gPiB2MjogKiBSZWR1Y2UgbnVtYmVyIG9m IHJldHJpZXMgd2hlbiByZWFkaW5nIHRoZSBzaW5rIENSQyAoSmFuaSkKPiA+ICAgICAqIFJlZmFj dG9yIHRvIG1pbmltaXplIGNoYW5nZXMgdG8gdGhlIGNvZGUgKEphbmkpCj4gPiAgICAgKiBSZWJh c2UKPiA+Cj4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4g Q2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+ID4gQ2M6IEphbmkg TmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBW aXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogSmltIEJyaWRl IDxqaW0uYnJpZGVAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYyB8IDQwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGluZGV4IDJkNDJkMDkuLjY5Yzgx MzBjIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gQEAgLTM5MDYsNiArMzkw NiwxNCBAQCBpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwg dTggKmNyYykKPiA+ICAJdTggYnVmOwo+ID4gIAlpbnQgY291bnQsIHJldDsKPiA+ICAJaW50IGF0 dGVtcHRzID0gNjsKPiA+ICsJdTggb2xkX2NyY1s2XTsKPiA+ICsKPiA+ICsJaWYgKGNyYyAhPSBO VUxMKSB7Cj4gCj4gQXMgREsgc2FpZCwgcGxlYXNlIGRyb3AgdGhlIGNoZWNrLgo+IAo+ID4gKwkJ bWVtc2V0KGNyYywgMCwgNik7Cj4gPiArCQltZW1zZXQob2xkX2NyYywgMHhmZiwgNik7Cj4gCj4g Qm90aCB1bm5lY2Vzc2FyeSwgc2VlIGJlbG93Lgo+IAo+ID4gKwl9IGVsc2Ugewo+ID4gKwkJcmV0 dXJuIC1FTk9NRU07Cj4gPiArCX0KPiA+ICAKPiA+ICAJcmV0ID0gaW50ZWxfZHBfc2lua19jcmNf c3RhcnQoaW50ZWxfZHApOwo+ID4gIAlpZiAocmV0KQo+ID4gQEAgLTM5MjksMTEgKzM5MzcsMzUg QEAgaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4ICpj cmMpCj4gPiAgCQlnb3RvIHN0b3A7Cj4gPiAgCX0KPiA+ICAKPiA+IC0JaWYgKGRybV9kcF9kcGNk X3JlYWQoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfQ1JDX1JfQ1IsIGNyYywgNikgPCAwKSB7Cj4g PiAtCQlyZXQgPSAtRUlPOwo+ID4gLQkJZ290byBzdG9wOwo+ID4gLQl9Cj4gPiArCWF0dGVtcHRz ID0gNjsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogU29tZXRpbWVzIGl0IHRha2VzIGEgd2hpbGUg Zm9yIHRoZSAicmVhbCIgQ1JDIHZhbHVlcyB0byBsYW5kIGluCj4gPiArCSAqIHRoZSBEUENELCBz byB0cnkgc2V2ZXJhbCB0aW1lcyB1bnRpbCB3ZSBnZXQgdHdvIHJlYWRzIGluIGEgcm93Cj4gPiAr CSAqIHRoYXQgYXJlIHRoZSBzYW1lLiAgSWYgd2UncmUgYW4gZURQIHBhbmVsLCBkZWxheSBiZXR3 ZWVuIHJlYWRzCj4gPiArCSAqIGZvciBhIHdoaWxlIHNpbmNlIHRoZSB2YWx1ZXMgdGFrZSBhIGJp dCBsb25nZXIgdG8gcHJvcGFnYXRlLgo+ID4gKwkgKi8KPiA+ICsJZG8gewo+IAo+IE5ldmVyIHVz ZSBhIGRvLXdoaWxlIHdoZW4gYSBmb3IgbG9vcCB3aWxsIGRvLiBmb3IgKGkgPSAwOyBpIDwgNjsg aSsrKQo+IGdldHMgaW50ZXJwcmV0ZWQgaW4gdGhlIHNwaW5lLCBubyBuZWVkIGZvciBmdXJ0aGVy IHByb2Nlc3NpbmcuCgpJIGhhZCB1c2VkIGRvLXdoaWxlIGJlY2F1c2UgaXQgd2FzIHVzZWQgZWFy bGllciB0byByZWFkIHRoZSB0ZXN0CmNvdW50IChjb2RlIEkgZGlkbid0IHRvdWNoLikgIEluIGFu eSBldmVudCwgSSBjYW4gY29udmVydCB0byBhCmZvciBsb29wIGVhc3kgZW5vdWdoLgoKPiA+ICsJ CWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgaW50ZWxfY3J0Yy0+cGlwZSk7Cj4gPiAr CQlpZiAoaXNfZWRwKGludGVsX2RwKSkKPiA+ICsJCQl1c2xlZXBfcmFuZ2UoMjAwMDAsIDI1MDAw KTsKPiAKPiBJcyB0aGUgaW50ZW50aW9uIHRvIGRvIHRoZXNlICpiZXR3ZWVuKiByZWFkcz8gSWYg eWVzLCB0aGVuIG1vdmUgdGhpcwo+ICphZnRlciogdGhlIG1lbWNtcCB0byBvbmx5IGRvIHRoaXMg YmV0d2VlbiByZWFkcy4KCk1vdmVkLgoKPiA+ICsKPiA+ICsJCWlmIChkcm1fZHBfZHBjZF9yZWFk KCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLAo+ID4gKwkJCQkgICAgIGNyYywgNikg PCAwKSB7Cj4gPiArCQkJcmV0ID0gLUVJTzsKPiA+ICsJCQlnb3RvIHN0b3A7Cj4gCj4gYnJlYWs7 CgpDaGFuZ2VkLgoKPiA+ICsJCX0KPiA+ICsKPiA+ICsJCWlmIChtZW1jbXAob2xkX2NyYywgY3Jj LCA2KSA9PSAwKSB7Cj4gPiArCQkJcmV0ID0gMDsKPiA+ICsJCQlnb3RvIHN0b3A7Cj4gPiArCQl9 IGVsc2Ugewo+ID4gKwkJCW1lbWNweShvbGRfY3JjLCBjcmMsIDYpOwo+ID4gKwkJfQo+IAo+IEFm dGVyIHlvdSd2ZSBzd2l0Y2hlZCB0aGlzIHRvIHRoZSBmb3IgbG9vcCwgeW91IGNhbiBkbzoKPiAK PiAJaWYgKGkgJiYgbWVtY21wKG9sZF9jcmMsIGNyYywgc2l6ZW9mKG9sZF9jcmMpKSA9PSAwKQo+ ICAgICAgICAgCWJyZWFrOwo+IAltZW1jcHkob2xkX2NyYywgY3JjLCBzaXplb2Yob2xkX2NyYykp OwoKQ2hhbmdlZC4gIEknbGwgc3VibWl0IGEgbmV3IHZlcnNpb24gb2YgdGhlIHBhdGNoIGFmdGVy IEkgcmV0ZXN0LgoKSmltCgo+ID4gKwl9IHdoaWxlICgtLWF0dGVtcHRzKTsKPiA+ICAKPiAKPiAJ aWYgKGkgPT0gNikgewo+IAo+ID4gKwlEUk1fREVCVUdfS01TKCJGYWlsZWQgdG8gZ2V0IENSQyBh ZnRlciA2IGF0dGVtcHRzLlxuIik7Cj4gPiArCXJldCA9IC1FVElNRURPVVQ7Cj4gCj4gCX0KPiAK PiA+ICBzdG9wOgo+ID4gIAlpbnRlbF9kcF9zaW5rX2NyY19zdG9wKGludGVsX2RwKTsKPiA+ICAJ cmV0dXJuIHJldDsKPiAKPiAtLSAKPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==