[PATCH i-g-t] igt_core: Skip sync when listing subtests

[PATCH i-g-t] igt_core: Skip sync when listing subtests

[Tvrtko Ursulin]

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

No need to sync filesystems when only listing subtest.

Extremely marginal benefit of avoid a short stall after make
followed by listing subtests.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 lib/igt_core.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/igt_core.h b/lib/igt_core.h
index 6c55c04b7de0..24f308477049 100644
--- a/lib/igt_core.h
+++ b/lib/igt_core.h
@@ -257,9 +257,10 @@ void __igt_subtest_group_restore(int);
 #define igt_main \
 	static void igt_tokencat(__real_main, __LINE__)(void); \
 	int main(int argc, char **argv) { \
-		sync(); \
 		igt_subtest_init_parse_opts(&argc, argv, NULL, NULL, NULL, \
 					    NULL, NULL); \
+		if (!igt_only_list_subtests()) \
+			sync(); \
 		igt_tokencat(__real_main, __LINE__)(); \
 		igt_exit(); \
 	} \
@@ -298,9 +299,10 @@ void igt_simple_init_parse_opts(int *argc, char **argv,
 #define igt_simple_main \
 	static void igt_tokencat(__real_main, __LINE__)(void); \
 	int main(int argc, char **argv) { \
-		sync(); \
 		igt_simple_init_parse_opts(&argc, argv, NULL, NULL, NULL, \
 					   NULL, NULL); \
+		if (!igt_only_list_subtests()) \
+			sync(); \
 		igt_tokencat(__real_main, __LINE__)(); \
 		igt_exit(); \
 	} \
-- 
2.9.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt_core: Skip sync when listing subtests

[Chris Wilson]

Quoting Tvrtko Ursulin (2017-07-21 14:00:27)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> No need to sync filesystems when only listing subtest.
> 
> Extremely marginal benefit of avoid a short stall after make
> followed by listing subtests.

Ah, I was looking for the sync recently, to move it to common_init()
alongside the other common adjustments (oom_adjust_for_doom() etc).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] igt_core: Skip sync when listing subtests

[Tvrtko Ursulin]

On 21/07/2017 14:17, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2017-07-21 14:00:27)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> No need to sync filesystems when only listing subtest.
>>
>> Extremely marginal benefit of avoid a short stall after make
>> followed by listing subtests.
> 
> Ah, I was looking for the sync recently, to move it to common_init()
> alongside the other common adjustments (oom_adjust_for_doom() etc).

That would be even better yes.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t v2] igt_core: Skip sync when listing subtests

[Tvrtko Ursulin]

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

No need to sync filesystems when only listing subtest.

Extremely marginal benefit of avoid a short stall after make
followed by listing subtests.

v2: Move sync to common_init for consolidation and simplicity.
    (Chris Wilson)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_core.c | 1 +
 lib/igt_core.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index 99a82d5ae0e1..7e5aa34237f1 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -854,6 +854,7 @@ out:
 		kmsg(KERN_INFO "[IGT] %s: executing\n", command_str);
 		print_version();
 
+		sync();
 		oom_adjust_for_doom();
 		low_mem_killer_disable(true);
 	}
diff --git a/lib/igt_core.h b/lib/igt_core.h
index 619c45c6df90..22b8c2230ea4 100644
--- a/lib/igt_core.h
+++ b/lib/igt_core.h
@@ -234,7 +234,6 @@ void __igt_subtest_group_restore(int);
 #define igt_main \
 	static void igt_tokencat(__real_main, __LINE__)(void); \
 	int main(int argc, char **argv) { \
-		sync(); \
 		igt_subtest_init_parse_opts(&argc, argv, NULL, NULL, NULL, \
 					    NULL, NULL); \
 		igt_tokencat(__real_main, __LINE__)(); \
@@ -275,7 +274,6 @@ void igt_simple_init_parse_opts(int *argc, char **argv,
 #define igt_simple_main \
 	static void igt_tokencat(__real_main, __LINE__)(void); \
 	int main(int argc, char **argv) { \
-		sync(); \
 		igt_simple_init_parse_opts(&argc, argv, NULL, NULL, NULL, \
 					   NULL, NULL); \
 		igt_tokencat(__real_main, __LINE__)(); \
-- 
2.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t v2] igt_core: Skip sync when listing subtests

[Chris Wilson]

Quoting Tvrtko Ursulin (2017-09-05 11:38:58)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> No need to sync filesystems when only listing subtest.
> 
> Extremely marginal benefit of avoid a short stall after make
> followed by listing subtests.
> 
> v2: Move sync to common_init for consolidation and simplicity.
>     (Chris Wilson)
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

sync() would also be useful between subtests, exit_subtest() along with
a variety of other cleanup handlers.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for igt_core: Skip sync when listing subtests (rev2)

[Patchwork]

== Series Details ==

Series: igt_core: Skip sync when listing subtests (rev2)
URL   : https://patchwork.freedesktop.org/series/27707/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
490b386ae36d393cdea514882a2437c6e964c13f scripts/run-tests.sh: Use piglit's --ignore-missing

with latest DRM-Tip kernel build CI_DRM_3038
9dd459ef87a9 drm-tip: 2017y-09m-04d-19h-10m-24s UTC integration manifest

Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                pass       -> FAIL       (fi-snb-2600) fdo#100215

fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215

fi-bdw-5557u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:469s
fi-bdw-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:439s
fi-blb-e6850     total:288  pass:224  dwarn:1   dfail:0   fail:0   skip:63  time:369s
fi-bsw-n3050     total:288  pass:243  dwarn:0   dfail:0   fail:0   skip:45  time:560s
fi-bwr-2160      total:288  pass:184  dwarn:0   dfail:0   fail:0   skip:104 time:255s
fi-bxt-j4205     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:521s
fi-byt-j1900     total:288  pass:254  dwarn:1   dfail:0   fail:0   skip:33  time:531s
fi-byt-n2820     total:288  pass:250  dwarn:1   dfail:0   fail:0   skip:37  time:520s
fi-cfl-s         total:288  pass:250  dwarn:4   dfail:0   fail:0   skip:34  time:473s
fi-elk-e7500     total:288  pass:230  dwarn:0   dfail:0   fail:0   skip:58  time:438s
fi-glk-2a        total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:615s
fi-hsw-4770      total:288  pass:263  dwarn:0   dfail:0   fail:0   skip:25  time:447s
fi-hsw-4770r     total:288  pass:263  dwarn:0   dfail:0   fail:0   skip:25  time:427s
fi-ilk-650       total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:430s
fi-ivb-3520m     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:514s
fi-ivb-3770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:480s
fi-kbl-7500u     total:288  pass:264  dwarn:1   dfail:0   fail:0   skip:23  time:516s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:601s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:603s
fi-pnv-d510      total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:529s
fi-skl-6260u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:487s
fi-skl-6700k     total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:537s
fi-skl-6770hq    total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:514s
fi-skl-gvtdvm    total:288  pass:266  dwarn:0   dfail:0   fail:0   skip:22  time:446s
fi-skl-x1585l    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:506s
fi-snb-2520m     total:288  pass:251  dwarn:0   dfail:0   fail:0   skip:37  time:568s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:2   skip:38  time:412s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_143/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for igt_core: Skip sync when listing subtests (rev2)

[Patchwork]

== Series Details ==

Series: igt_core: Skip sync when listing subtests (rev2)
URL   : https://patchwork.freedesktop.org/series/27707/
State : failure

== Summary ==

Test gem_exec_capture:
        Subgroup capture-blt:
                pass       -> DMESG-WARN (shard-hsw)
Test kms_flip:
        Subgroup vblank-vs-modeset-suspend-interruptible:
                pass       -> DMESG-FAIL (shard-hsw)
        Subgroup vblank-vs-dpms-suspend-interruptible:
                pass       -> DMESG-FAIL (shard-hsw)
Test gem_exec_store:
        Subgroup cachelines-blt:
                pass       -> SKIP       (shard-hsw)
Test kms_busy:
        Subgroup basic-flip-C:
                pass       -> SKIP       (shard-hsw)
Test gem_exec_flush:
        Subgroup basic-batch-kernel-default-uc:
                pass       -> SKIP       (shard-hsw)
Test gem_exec_parallel:
        Subgroup render:
                pass       -> SKIP       (shard-hsw)
        Subgroup default-fds:
                pass       -> SKIP       (shard-hsw)
Test kms_draw_crc:
        Subgroup draw-method-xrgb2101010-blt-xtiled:
                pass       -> FAIL       (shard-hsw)
Test drv_suspend:
        Subgroup sysfs-reader:
                pass       -> DMESG-FAIL (shard-hsw)
Test gem_partial_pwrite_pread:
        Subgroup write-snoop:
                pass       -> SKIP       (shard-hsw)
Test kms_setmode:
        Subgroup basic:
                fail       -> PASS       (shard-hsw) fdo#99912
Test perf:
        Subgroup blocking:
                fail       -> PASS       (shard-hsw) fdo#102252

fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-hsw        total:2265 pass:1224 dwarn:1   dfail:3   fail:15  skip:1022 time:9482s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_143/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx