From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers
Date: Tue, 1 Aug 2017 09:14:50 -0700 [thread overview]
Message-ID: <20170801161450.GA4121@mail.bwidawsk.net> (raw)
In-Reply-To: <20170731082955.GB22299@dvetter-linux.ger.corp.intel.com>
On 17-07-31 10:29:55, Daniel Vetter wrote:
>On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote:
>> On 17-07-29 13:53:10, Daniel Stone wrote:
>> > Hi Ben,
>> >
>> > On 26 July 2017 at 19:08, Ben Widawsky <ben@bwidawsk.net> wrote:
>> > > + } else if (INTEL_GEN(dev_priv) >= 9) {
>> > > intel_primary_formats = skl_primary_formats;
>> > > num_formats = ARRAY_SIZE(skl_primary_formats);
>> > > - modifiers = skl_format_modifiers;
>> > > + if (pipe >= PIPE_C)
>> > > + modifiers = skl_format_modifiers_ccs;
>> > > + else
>> > > + modifiers = skl_format_modifiers_noccs;
>> >
>> > Shouldn't that be (pipe < PIPE_C)?
>> >
>> > Cheers,
>> > Daniel
>>
>> Yep. It was wrong in v7 too :/. I have it fixed locally.
>
>Shouldn't the igt catch this, or does it not try to exercise all the
>plane/crtc combos there are?
>-Daniel
I don't know whether or not IGT should have caught this, but it wouldn't have
because I had been sending these without Ville's patches, so my patches alone
don't even build (since his patches defined the modifiers).
>--
>Daniel Vetter
>Software Engineer, Intel Corporation
>http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-08-01 16:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 18:07 [PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS Ben Widawsky
2017-07-26 18:07 ` [PATCH 2/6] drm/i915: Add render decompression support Ben Widawsky
2017-07-31 16:14 ` Daniel Stone
2017-07-26 18:07 ` [PATCH 3/6] drm: Plumb modifiers through plane init Ben Widawsky
2017-07-26 18:08 ` [PATCH 4/6] drm: Create a format/modifier blob Ben Widawsky
2017-07-26 18:08 ` [PATCH 5/6] drm/i915: Add format modifiers for Intel Ben Widawsky
2017-07-31 16:08 ` Daniel Stone
2017-07-26 18:08 ` [PATCH 6/6] drm/i915: Add support for CCS modifiers Ben Widawsky
2017-07-29 12:53 ` Daniel Stone
2017-07-29 16:25 ` Ben Widawsky
2017-07-31 8:29 ` Daniel Vetter
2017-08-01 16:14 ` Ben Widawsky [this message]
2017-08-02 10:14 ` Daniel Vetter
2017-08-02 15:43 ` Ben Widawsky
2017-08-03 8:08 ` [Intel-gfx] " Daniel Vetter
2017-08-03 17:20 ` Ben Widawsky
2017-07-29 12:55 ` Daniel Stone
2017-07-26 18:27 ` ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915: Implement .get_format_info() hook for CCS Patchwork
2017-07-31 16:12 ` [PATCH 1/6] " Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801161450.GA4121@mail.bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox