From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/4] Userptr bo slab use optimization
Date: Tue, 1 Aug 2017 11:16:09 -0700 [thread overview]
Message-ID: <20170801181609.GA11007@intel.com> (raw)
In-Reply-To: <150114755126.17819.6069112270482373160@mail.alporthouse.com>
On 17-07-27 10:25:51, Chris Wilson wrote:
>Quoting Tvrtko Ursulin (2017-07-27 10:05:00)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Yet another attempt to get this series reviewed and merged...
>>
>> I've heard Vulkan might be creating a lot of userptr objects so might be
>> interesting to check what benefit it brings to those use cases.
>
>Optimist :) My thinking is that this should only impact get_pages ->
>vma_bind, which is supposed a rare operation, and if should happen as
>part of the steady state that we have too many sg in a chain is just one
>of the myriad little paper cuts :)
>
Vulkan is critically dependent on userptr, but I don't believe we create many
usrptr BOs as the implementation and API reduce the number of BOs in general.
I don't see any reason not to do any of this though. Series is
Acked-by: Ben Widawsky <ben@bwidawsk.net>
>> As an introduction, this allows i915 to create fewer sg table entries for the bo
>> backing store representation. As such it primarily saves kernel slab memory.
>>
>> When we added this optimisation to normal i915 bos, the savings were as far as
>> I remember around 1-2MiB of slab after booting to KDE desktop, and 2-4Mib on
>> neverball (game) main screen (or maybe it was while playing).
>
>I think we also want to think about the aspect where we are creating
>objects of multiple 1G huge pages, so we are going to run into the sg
>limits very quickly.
>-Chris
--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-01 18:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 9:05 [PATCH 0/4] Userptr bo slab use optimization Tvrtko Ursulin
2017-07-27 9:05 ` [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages Tvrtko Ursulin
2017-07-27 9:05 ` [PATCH 2/4] lib/scatterlist: Avoid potential scatterlist entry overflow Tvrtko Ursulin
2017-07-28 10:53 ` [Intel-gfx] " Chris Wilson
2017-07-27 9:05 ` [PATCH 3/4] lib/scatterlist: Introduce and export __sg_alloc_table_from_pages Tvrtko Ursulin
2017-07-28 11:07 ` Chris Wilson
2017-08-02 13:06 ` [Intel-gfx] " Tvrtko Ursulin
2017-08-02 23:01 ` Andrew Morton
2017-08-03 9:21 ` Tvrtko Ursulin
2017-07-27 9:05 ` [PATCH 4/4] drm/i915: Use __sg_alloc_table_from_pages for userptr allocations Tvrtko Ursulin
2017-07-28 11:06 ` Chris Wilson
2017-07-27 9:25 ` [PATCH 0/4] Userptr bo slab use optimization Chris Wilson
2017-07-27 10:46 ` Tvrtko Ursulin
2017-07-27 10:53 ` Chris Wilson
2017-08-01 18:16 ` Ben Widawsky [this message]
2017-07-27 9:39 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801181609.GA11007@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).