From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Bride Subject: Re: [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1() Date: Mon, 7 Aug 2017 08:55:00 -0700 Message-ID: <20170807155500.GA7597@shiv> References: <1499811596-14634-1-git-send-email-jim.bride@linux.intel.com> <1499811596-14634-2-git-send-email-jim.bride@linux.intel.com> <14705705.6BrEU4IqqS@dk> <149985393987.28319.1190106748589865284@mail.alporthouse.com> <87bmonl5uj.fsf@nikula.org> <20170803214825.GA30928@shiv> <8760e3hjtu.fsf@nikula.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E9D36E505 for ; Mon, 7 Aug 2017 15:57:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <8760e3hjtu.fsf@nikula.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Paulo Zanoni , Wayne Boyer , intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMDQsIDIwMTcgYXQgMTA6Mjk6MzNBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAwMyBBdWcgMjAxNywgSmltIEJyaWRlIDxqaW0uYnJpZGVAbGludXguaW50 ZWwuY29tPiB3cm90ZToKPiA+IE9uIEZyaSwgSnVsIDE0LCAyMDE3IGF0IDEyOjM0OjI4UE0gKzAz MDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4+IE9uIFdlZCwgMTIgSnVsIDIwMTcsIENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPiB3cm90ZToKPiA+PiA+IFF1b3RpbmcgRGhp bmFrYXJhbiBQYW5kaXlhbiAoMjAxNy0wNy0xMiAwOTo0NzoyNSkKPiA+PiA+PiBPbiBUdWVzZGF5 LCBKdWx5IDExLCAyMDE3IDM6MTk6NTMgUE0gUERUIEppbSBCcmlkZSB3cm90ZToKPiA+PiA+PiA+ IE9uIFNLTCsgdGhlcmUgaXMgYSBiaXQgaW4gU1JEX0NUTCB0aGF0IHNvZnR3YXJlIGlzIG5vdCBz dXBwb3NlZCB0bwo+ID4+ID4+ID4gbW9kaWZ5LCBidXQgd2UgY3VycmVudGx5IGNsb2JiZXIgdGhh dCBiaXQgd2hlbiB3ZSBlbmFibGUgUFNSLiAgSW4KPiA+PiA+PiA+IG9yZGVyIHRvIHByZXNlcnZl IHRoZSB2YWx1ZSBvZiB0aGF0IGJpdCwgZ28gYWhlYWQgYW5kIHJlYWQgU1JEX0NUTCAKPiA+PiA+ PiAKPiA+PiA+PiBBbmQgd2hpY2ggYml0IGlzIHRoYXQ/Cj4gPgo+ID4gQml0IDI5IChDb250ZXh0 IHJlc3RvcmUgdG8gUFNSIEFjdGl2ZSkgaW4gU1JEX0NUTC4gIEknbGwgYWRkIGl0IHRvIHRoZQo+ ID4gY29tbWl0IG1lc3NhZ2UuICBJdCdzIHdvcnRoIG5vdGluZyB0aGF0IHRoZSBiaXQgaXMgbm90 IHRlY2huaWNhbGx5Cj4gPiByZXNlcnZlZCwgYnV0IHJhdGhlciB0aGF0IFNXIGlzIG5vdCBhbGxv d2VkIHRvIGNoYW5nZSBpdC4KPiA+Cj4gPj4gPgo+ID4+ID4gSSB0aGluayB3ZSB3b3VsZCBhbGwg YmUgaGFwcGllciB3aXRoIGtlZXBpbmcgdGhlIGV4cGxpY2l0IGNvbnN0cnVjdGlvbgo+ID4+ID4g KGFuZCBhIHNtYWxsZXIgcGF0Y2gpIGlmIHdlIHVzZWQKPiA+PiA+Cj4gPj4gPiAJdmFsIHw9IEk5 MTVfUkVBRChFRFBfUFNSX0NUTCkgJiBFRFBfUFNSX0NUTF9SU1ZEX01BU0s7Cj4gPj4gCj4gPj4g QWdyZWVkLiBBdm9pZCByZWFkLW1vZGlmeS13cml0ZSBhcyBtdWNoIGFzIHBvc3NpYmxlLgo+ID4K PiA+IEkgY2FuIGRvIHRoaXMgaWYgZXZlcnlvbmUgdGhpbmtzIGl0J3MgdGhlIHRoaW5nIHRvIGRv LCBidXQgaXQKPiA+IGRvZXMgb3BlbiB1cyB1cCB0byBhIHNpbWlsYXIgY2xhc3Mgb2YgYnVnIChC LVNwZWMgcmVzdHJpY3RpbmcgbW9kcwo+ID4gdG8gYSBiaXQgLyBiaXQgcmFuZ2UgYWZ0ZXIgaW5p dGlhbCBzdXBwb3J0IGZvciBhIHBsYXRmb3JtIHdhcyBhZGRlZCkKPiA+IGluIHRoZSBmdXR1cmUu ICBJTUhPIHRoZSBjb2RlIGFzIHdyaXR0ZW4gaXMgc2FmZXIuCj4gCj4gQ2hyaXMnIHN1Z2dlc3Rp b24gcHJlc2VydmVzIHRoZSByZXN0cmljdGVkIGJpdHMgdGhhdCBtdXN0IHJlbWFpbiB0aGUKPiBz YW1lLCB3aGlsZSBpbml0aWFsaXppbmcgZXZlcnl0aGluZyBlbHNlLiBJbnN0ZWFkIG9mIG9ubHkg Y2hhbmdpbmcgdGhlCj4gYml0cyB3ZSBtdXN0IGNoYW5nZSwgb25seSBwcmVzZXJ2ZSB0aGUgYml0 cyB3ZSBtdXN0IG5vdCBjaGFuZ2UuIFNvcnJ5IGlmCj4gSSB3YXNuJ3QgY2xlYXIgd2l0aCB0aGUg ImFzIG11Y2ggYXMgcG9zc2libGUiIHBhcnQgdGhlcmUuCgpJIHRoaW5rIEkgZm9sbG93ZWQgeW91 LiAgV2hhdCBJIHdhcyB0cnlpbmcgdG8gaGlnaGxpZ2h0IGlzIHRoYXQgdGhlCnBhdGNoIGFzIHdy aXR0ZW4gZG9lc24ndCB0b3VjaCBhbnl0aGluZyBvdGhlciB0aGFuIHdoYXQgd2UgZXhwbGljaXRs eQpuZWVkIHRvIGluaXRpYWxpemUuICBXaGlsZSBDaHJpcycgc3VnZ2VzdGlvbiBpcyBtdWNoIG1v cmUgdGVyc2UsIGl0CmxlYXZlcyB1cyBvcGVuIHRvIGFub3RoZXIgYml0IGJlaW5nIGZsYWdnZWQg b3V0IGFzICdzb2Z0d2FyZQpzaG91bGRuJ3QgY2hhbmdlJyBhbmQgd2UnZCBoYXZlIGEgc2ltaWxh ciBidWcgYWdhaW4uICBUaGUgcGF0Y2ggYXMKd3JpdHRlbiBkb2Vzbid0IGV4cG9zZSB1cyB0byB0 aGF0IHNpdHVhdGlvbi4gIEknbSBoYXBweSB0byBnbyB3aXRoCkNocmlzJyBzdWdnZXN0aW9uIGlm IGV2ZXJ5b25lIHN0aWxsIHRoaW5rcyBpdCdzIHRoZSByaWdodCB0aGluZywgYnV0Ckkgd2FudGVk IHRvIGhpZ2hsaWdodCB0aGF0IGl0J3Mgbm90IGVudGlyZWx5IGVxdWl2YWxlbnQgdG8gd2hhdCB3 YXMKaW4gdGhlIG9yaWdpbmFsIHBhdGNoIGFuZCBpbiBteSBvcGluaW9uIGl0J3MgbGVzcyBzYWZl IHRoYW4gdGhlCm9yaWdpbmFsIHBhdGNoLgoKPiBQcmVzZXJ2aW5nIHRoZSByZXN0cmljdGVkIGJp dHMgaXMgYSBmdW5jdGlvbmFsIGNoYW5nZSwgYW5kIHRoZSBzdWJqZWN0Cj4gb2YgdGhpcyBwYXRj aCBkb2VzIG5vdCByZWZsZWN0IHRoYXQuIFdoZW4gSSBsb29rIGF0IHRoZSBsb2dzLCBJIHByZXR0 eQo+IG11Y2ggZXhwZWN0IGNsZWFuIHVwIGNvbW1pdHMgdG8gYmUgbm9uLWZ1bmN0aW9uYWwuIFRo ZXJlIGFyZSBzb21lIGFyZWFzCj4gd2hlcmUgSSdkIGxvb2sgdGhlIG90aGVyIHdheSwgYnV0IFBT UiBpcyBzb21ldGhpbmcgd2hlcmUgd2UgbXVzdAo+IGNhcmVmdWxseSBzcGxpdCB1cCB0aGUgcGF0 Y2hlcyBhbmQgd3JpdGUgdGhlIGNvbW1pdCBtZXNzYWdlcyBkaWxpZ2VudGx5LAo+IGJlY2F1c2Ug SSBrbm93IHdlIHdpbGwgYmUgc3BlbmRpbmcgdGltZSBkZWJ1Z2dpbmcgdGhpcyBjb2RlIGFuZCBy ZWFkaW5nCj4gdGhlIGxvZ3MuCgpJIHdpbGwgcmVtb3ZlIHRoZSB3b3JkICdjbGVhbi11cCcgYW5k IHJld29yZCB0aGUgc3ViamVjdCwgaW5kZXBlbmRlbnQKb2Ygd2hhdCB3ZSBkZWNpZGUgcmVsYXRp dmUgdG8gdGhlIHR3byBhcHByb2FjaGVzIGRlc2NyaWJlZCBhYm92ZS4KVGhlIGJvZHkgb2YgdGhl IGNvbW1pdCBtZXNzYWdlIChJTUhPKSBkb2VzIGEgZ29vZCBqb2IgKGFuZCBJJ2xsIGFkZAp0aGUg c3BlY2lmaWMgYml0IGluIFNSRF9DVEwgdG8gdGhlIGJvZHkgYWxzbykgb2YgZGVzY3JpYmluZyB0 aGUKZnVuY3Rpb25hbCBjaGFuZ2VzIHRoYXQgdGhlIHBhdGNoIG1ha2VzLgoKSmltCgo+IEJSLAo+ IEphbmkuCj4gCj4gCj4gCj4gPgo+ID4gSmltCj4gPgo+ID4KPiA+PiAKPiA+PiBCUiwKPiA+PiBK YW5pLgo+ID4+IAo+ID4+IAo+ID4+IC0tIAo+ID4+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBUZWNobm9sb2d5IENlbnRlcgo+ID4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4+IEludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJ bnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK