From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Bride Subject: Re: [PATCH v4 2/4] drm/i915/psr: Account for sink CRC raciness on some panels Date: Mon, 7 Aug 2017 08:58:25 -0700 Message-ID: <20170807155825.GB7597@shiv> References: <1499811596-14634-1-git-send-email-jim.bride@linux.intel.com> <1500413648-4765-1-git-send-email-jim.bride@linux.intel.com> <1500413648-4765-2-git-send-email-jim.bride@linux.intel.com> <1501873113.31712.81.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F1458987C for ; Mon, 7 Aug 2017 16:01:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1501873113.31712.81.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "Nikula, Jani" , "intel-gfx@lists.freedesktop.org" , "Zanoni, Paulo R" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMDQsIDIwMTcgYXQgMDY6Mzg6MDJQTSArMDAwMCwgUGFuZGl5YW4sIERoaW5h a2FyYW4gd3JvdGU6Cj4gCj4gCj4gCj4gT24gVGh1LCAyMDE3LTA4LTAzIGF0IDExOjA3IC0wNzAw LCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gPiBPbiBUdWUsIEp1bCAxOCwgMjAxNyBhdCAyOjM0IFBN LCBKaW0gQnJpZGUgPGppbS5icmlkZUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gPiBBY2Nv cmRpbmcgdG8gdGhlIGVEUCBzcGVjLCB3aGVuIHRoZSBjb3VudCBmaWVsZCBpbiBURVNUX1NJTktf TUlTQwo+ID4gPiBpbmNyZW1lbnRzIHRoZW4gdGhlIHNpeCBieXRlcyBvZiBzaW5rIENSQyBpbmZv cm1hdGlvbiBpbiB0aGUgRFBDRAo+ID4gPiBzaG91bGQgYmUgdmFsaWQuICBVbmZvcnR1bmF0ZWx5 LCB0aGlzIGRvZXNuJ3Qgc2VlbSB0byBiZSB0aGUgY2FzZQo+ID4gPiBvbiBzb21lIHBhbmVscywg YW5kIGFzIGEgcmVzdWx0IHdlIGdldCBzb21lIGluY29ycmVjdCBhbmQgaW5jb25zaXN0ZW50Cj4g PiA+IHZhbHVlcyBmcm9tIHRoZSBzaW5rIENSQyBEUENEIGxvY2F0aW9ucyBhdCB0aW1lcy4gIFRo aXMgcHJvYmxlbSBleGhpYml0cwo+ID4gPiBpdHNlbGYgbW9yZSBvbiBmYXN0ZXIgcHJvY2Vzc29y cyAocmVsYXRpdmUgZmFpbHVyZSByYXRlcyBIU1cgPCBTS0wgPCBLQkwuKQo+ID4gPiBJbiBvcmRl ciB0byB0cnkgYW5kIGFjY291bnQgZm9yIHRoaXMsIHdlIHRyeSBhIGxvdCBoYXJkZXIgdG8gcmVh ZCB0aGUgc2luawo+ID4gPiBDUkMgdW50aWwgd2UgZ2V0IGNvbnNpc3RlbnQgdmFsdWVzIHR3aWNl IGluIGEgcm93IGJlZm9yZSByZXR1cm5pbmcgd2hhdCB3ZQo+ID4gPiByZWFkIGFuZCBkZWxheSBm b3IgYSB0aW1lIGJlZm9yZSB0cnlpbmcgdG8gcmVhZC4gIFdlIHN0aWxsIHNlZSBzb21lCj4gPiA+ IG9jY2FzaW9uYWwgZmFpbHVyZXMsIGJ1dCByZWFkaW5nIHRoZSBzaW5rIENSQyBpcyBtdWNoIG1v cmUgcmVsaWFibGUsCj4gPiA+IHBhcnRpY3VsYXJseSBvbiBTS0wgYW5kIEtCTCwgd2l0aCB0aGVz ZSBjaGFuZ2VzIHRoYW4gd2l0aG91dC4KPiAKPiBJJ20gY3VyaW91cyBpZiB3ZSBnZXQgdGhlIGNv cnJlY3QgY3JjIGlmIHdlIHdhaXRlZCBhIGZ1bGwgc2Vjb25kLgoKT24gU0tMLCB0aW1lcyBsZXNz IHRoYW4gYSBzZWNvbmQgd29yayBmaW5lIGdlbmVyYWxseS4gIE9uIEtCTCwgdGhlCnNpbmsgQ1JD IGlzICp3YXkqIGxlc3MgcmVsaWFibGUsIGFuZCBJJ3ZlIHNlZW4gcnVucyB3aGVyZSBJIHNldCB0 aGUKcmV0cnkgY291bnRzIHJpZGljdWxvdXNseSBoaWdoICg+IDMwKSBhbmQgc3RpbGwgbm90IHJl Y2VpdmVkIHZhbGlkCnZhbHVlcy4KCgpKaW0KCgo+ID4gCj4gPiBJcyBESyBub3cgb2sgd2l0aCB0 aGlzIGRlc2NyaXB0aW9uPwo+ID4gSSBiZWxpZXZlIGhlIHJlcXVlc3RlZCBtb3JlIGluZm8gaGVy ZS4KPiA+IAo+ID4gPgo+ID4gPiB2MjogKiBSZWR1Y2UgbnVtYmVyIG9mIHJldHJpZXMgd2hlbiBy ZWFkaW5nIHRoZSBzaW5rIENSQyAoSmFuaSkKPiA+ID4gICAgICogUmVmYWN0b3IgdG8gbWluaW1p emUgY2hhbmdlcyB0byB0aGUgY29kZSAoSmFuaSkKPiA+ID4gICAgICogUmViYXNlCj4gPiA+IHYz OiAqIFJlYmFzZQo+ID4gPiB2NDogKiBTd2l0Y2ggZnJvbSBkby13aGlsZSB0byBmb3IgbG9vcCB3 aGVuIHJlYWRpbmcgQ1JDIHZhbHVlcyAoSmFuaSkKPiA+ID4gICAgICogUmViYXNlCj4gPiA+IENj OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiA+IENjOiBQYXVsbyBa YW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiA+ID4gQ2M6IEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEppbSBCcmlkZSA8amlt LmJyaWRlQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jIHwgMzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4g PiA+ICAxIGZpbGUgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+ ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IGluZGV4IDJkNDJkMDkuLmM5MGNh MWMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBAQCAtMzkwNiw2 ICszOTA2LDExIEBAIGludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwLCB1OCAqY3JjKQo+ID4gPiAgICAgICAgIHU4IGJ1ZjsKPiA+ID4gICAgICAgICBpbnQgY291 bnQsIHJldDsKPiA+ID4gICAgICAgICBpbnQgYXR0ZW1wdHMgPSA2Owo+ID4gPiArICAgICAgIHU4 IG9sZF9jcmNbNl07Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBpZiAoY3JjID09IE5VTEwpIHsKPiA+ ID4gKyAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+ID4gPiArICAgICAgIH0KPiA+IAo+ ID4gd291bGRuJ3Qgd2UgZHJvcCB0aGlzIGNoZWNrIHBlciBESyBhbmQgSmFuaSByZXF1ZXN0Pwo+ ID4gSSBiZWxpZXZlIHdlIGRvbid0IG5lZWQgaXQsIGJ1dCBldmVuIGlmIHRoZXJlIGFyZSBjYXNl cyB0aGF0IHdlIG5lZWQKPiA+IHdlIGNvdWxkIHJlbW92ZSB0aGUgYnJhY2VzLi4KPiA+IAo+IAo+ IFllYWgsIGNyYyBpcyBhbGxvY2F0ZWQgb24gdGhlIHN0YWNrLiBJZiB0aGF0IGlzIG51bGwsIHdl J2xsIGhhdmUgYmlnZ2VyCj4gcHJvYmxlbXMgdG8gZGVhbCB3aXRoLiBBbmQgSSB0aGluayBpdCdz IHJlYXNvbmFibGUgdG8gYXNzdW1lIHRoZSBjYWxsZXIKPiBpcyBzZW5kaW5nIGEgdmFsaWQgYXJy YXkgdG8gZmlsbCBkYXRhLgo+IAo+ID4gPgo+ID4gPiAgICAgICAgIHJldCA9IGludGVsX2RwX3Np bmtfY3JjX3N0YXJ0KGludGVsX2RwKTsKPiA+ID4gICAgICAgICBpZiAocmV0KQo+ID4gPiBAQCAt MzkyOSwxMSArMzkzNCwzMyBAQCBpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwgdTggKmNyYykKPiA+ID4gICAgICAgICAgICAgICAgIGdvdG8gc3RvcDsKPiA+ ID4gICAgICAgICB9Cj4gPiA+Cj4gPiA+IC0gICAgICAgaWYgKGRybV9kcF9kcGNkX3JlYWQoJmlu dGVsX2RwLT5hdXgsIERQX1RFU1RfQ1JDX1JfQ1IsIGNyYywgNikgPCAwKSB7Cj4gPiA+IC0gICAg ICAgICAgICAgICByZXQgPSAtRUlPOwo+ID4gPiAtICAgICAgICAgICAgICAgZ290byBzdG9wOwo+ ID4gPiArICAgICAgIC8qCj4gPiA+ICsgICAgICAgICogU29tZXRpbWVzIGl0IHRha2VzIGEgd2hp bGUgZm9yIHRoZSAicmVhbCIgQ1JDIHZhbHVlcyB0byBsYW5kIGluCj4gPiA+ICsgICAgICAgICog dGhlIERQQ0QsIHNvIHRyeSBzZXZlcmFsIHRpbWVzIHVudGlsIHdlIGdldCB0d28gcmVhZHMgaW4g YSByb3cKPiA+ID4gKyAgICAgICAgKiB0aGF0IGFyZSB0aGUgc2FtZS4gIElmIHdlJ3JlIGFuIGVE UCBwYW5lbCwgZGVsYXkgYmV0d2VlbiByZWFkcwo+ID4gPiArICAgICAgICAqIGZvciBhIHdoaWxl IHNpbmNlIHRoZSB2YWx1ZXMgdGFrZSBhIGJpdCBsb25nZXIgdG8gcHJvcGFnYXRlLgo+ID4gPiAr ICAgICAgICAqLwo+ID4gPiArICAgICAgIGZvciAoYXR0ZW1wdHMgPSAwOyBhdHRlbXB0cyA8IDY7 IGF0dGVtcHRzKyspIHsKPiA+ID4gKyAgICAgICAgICAgICAgIGludGVsX3dhaXRfZm9yX3ZibGFu ayhkZXZfcHJpdiwgaW50ZWxfY3J0Yy0+cGlwZSk7Cj4gPiAKPiA+IERLLCB3ZSBuZWVkIHZibGFu ayB3YWl0IGJlY2F1c2UgdGhlIGNyYyBjYWxjdWxhdGlvbiBhbHNvIG1heSB0YWtlIG9uZSB2Ymxh bmsuCj4gPiB1c3VhbGx5IDIgYWN0dWFsbHkuLi4gb25lIHRvIG1ha2Ugc3VyZSB5b3UgaGF2ZSB0 aGUgZnVsbCBzY3JlZW4KPiA+IHVwZGF0ZWQgYW5kIG9uZSBmb3IgdGhlIGNhbGN1bGF0aW9uLgo+ ID4gSW4gdGhlIHBhc3Qgd2hlbiB3ZSBkaWRuJ3QgdXNlZCB0aGUgY291bnQgd2Ugd2VyZSB3YWl0 aW5nIDIgdmJsYW5rcy4uLgo+ID4gCj4gCj4gCj4gVGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlv bi4gTXkgcmVhc29uaW5nIHdhcywgYWZ0ZXIgdGhlIGZpcnN0IHR3bwo+IHZibGFua193YWl0cyBm b3IgdGhlIHNpbmsgdG8gY2FsY3VsYXRlIGNyYywgdGhlIG9uZXMgaW4gdGhlIHJldHJ5IHBhdGgK PiB3ZXJlIHVubmVjZXNzYXJ5LiBXZSBqdXN0IG5lZWQgc29tZSBkZWxheSBiZWZvcmUgcmVhZGlu ZyB0aGUgZHBjZCBhZ2Fpbgo+IHdpdGhvdXQgaGF2aW5nIHRvIGVuYWJsZSB2YmxhbmsgaW50ZXJy dXB0cy4gQW55d2F5LCB0aGUgbnVtYmVyIG9mCj4gcmV0cmllcyBpcyBsb3cgZW5vdWdoIHRoYXQg aXQgc2hvdWxkbid0IG1hdHRlci4KPiAKPiBPbiB0aGUgb3RoZXIgaGFuZCwgc2luY2UgdGhlIG9u bHkgY29uc3VtZXJzIG9mIGRwIHNpbmsgY3JjIGFyZSB0ZXN0cywKPiB3aHkgY2FuJ3QgdGhlIGtl cm5lbCBqdXN0IGR1bXAgd2hhdCBpdCByZWFkcyB0byBkZWJ1Z2ZzIGFuZCBsZXQgdGhlIHRlc3QK PiBkZWFsIHdpdGggZXJyb25lb3VzIHJlc3VsdHM/Cj4gCj4gPiA+ICsKPiA+ID4gKyAgICAgICAg ICAgICAgIGlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX0NSQ19S X0NSLAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3JjLCA2KSA8 IDApIHsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0gLUVJTzsKPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gPiA+ICsgICAgICAgICAgICAgICB9Cj4gPiA+ ICsKPiA+ID4gKyAgICAgICAgICAgICAgIGlmIChhdHRlbXB0cyAmJiBtZW1jbXAob2xkX2NyYywg Y3JjLCA2KSA9PSAwKQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiA+ID4g KyAgICAgICAgICAgICAgIG1lbWNweShvbGRfY3JjLCBjcmMsIDYpOwo+ID4gCj4gPiBsaXR0bGUg YmlrZXNoZWQ6IHRvbyBtYW55IGhhcmRjb2RlZCAiNiIgYXJvdW5kLi4uIGEgc2l6ZW9mIHdvdWxk IGJlIGJldHRlci4uLgo+ID4gYnV0IHdoYXRldmVyLi4uCj4gPiAKPiA+ID4gKwo+ID4gPiArICAg ICAgICAgICAgICAgaWYgKGlzX2VkcChpbnRlbF9kcCkpCj4gPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgIHVzbGVlcF9yYW5nZSgyMDAwMCwgMjUwMDApOwo+ID4gPiAgICAgICAgIH0KPiA+ID4K PiA+ID4gKyAgICAgICBpZiAoYXR0ZW1wdHMgPT0gNikgewo+ID4gPiArICAgICAgICAgICAgICAg RFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGdldCBDUkMgYWZ0ZXIgNiBhdHRlbXB0cy5cbiIpOwo+ ID4gPiArICAgICAgICAgICAgICAgcmV0ID0gLUVUSU1FRE9VVDsKPiA+ID4gKyAgICAgICB9Cj4g PiA+ICBzdG9wOgo+ID4gPiAgICAgICAgIGludGVsX2RwX3NpbmtfY3JjX3N0b3AoaW50ZWxfZHAp Owo+ID4gPiAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+IC0tCj4gPiA+IDIuNy40Cj4gPiA+Cj4g PiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo+ID4gCj4gPiAKPiA+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK