From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Bride Subject: Re: [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1() Date: Mon, 7 Aug 2017 10:17:10 -0700 Message-ID: <20170807171710.GA9610@shiv> References: <1499811596-14634-1-git-send-email-jim.bride@linux.intel.com> <1499811596-14634-2-git-send-email-jim.bride@linux.intel.com> <14705705.6BrEU4IqqS@dk> <149985393987.28319.1190106748589865284@mail.alporthouse.com> <87bmonl5uj.fsf@nikula.org> <20170803214825.GA30928@shiv> <8760e3hjtu.fsf@nikula.org> <20170807155500.GA7597@shiv> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id F23A66E563 for ; Mon, 7 Aug 2017 17:19:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170807155500.GA7597@shiv> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi , Paulo Zanoni , Wayne Boyer List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBdWcgMDcsIDIwMTcgYXQgMDg6NTU6MDBBTSAtMDcwMCwgSmltIEJyaWRlIHdyb3Rl Ogo+IE9uIEZyaSwgQXVnIDA0LCAyMDE3IGF0IDEwOjI5OjMzQU0gKzAzMDAsIEphbmkgTmlrdWxh IHdyb3RlOgo+ID4gT24gVGh1LCAwMyBBdWcgMjAxNywgSmltIEJyaWRlIDxqaW0uYnJpZGVAbGlu dXguaW50ZWwuY29tPiB3cm90ZToKPiA+ID4gT24gRnJpLCBKdWwgMTQsIDIwMTcgYXQgMTI6MzQ6 MjhQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiA+PiBPbiBXZWQsIDEyIEp1bCAyMDE3 LCBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JvdGU6Cj4gPiA+PiA+ IFF1b3RpbmcgRGhpbmFrYXJhbiBQYW5kaXlhbiAoMjAxNy0wNy0xMiAwOTo0NzoyNSkKPiA+ID4+ ID4+IE9uIFR1ZXNkYXksIEp1bHkgMTEsIDIwMTcgMzoxOTo1MyBQTSBQRFQgSmltIEJyaWRlIHdy b3RlOgo+ID4gPj4gPj4gPiBPbiBTS0wrIHRoZXJlIGlzIGEgYml0IGluIFNSRF9DVEwgdGhhdCBz b2Z0d2FyZSBpcyBub3Qgc3VwcG9zZWQgdG8KPiA+ID4+ID4+ID4gbW9kaWZ5LCBidXQgd2UgY3Vy cmVudGx5IGNsb2JiZXIgdGhhdCBiaXQgd2hlbiB3ZSBlbmFibGUgUFNSLiAgSW4KPiA+ID4+ID4+ ID4gb3JkZXIgdG8gcHJlc2VydmUgdGhlIHZhbHVlIG9mIHRoYXQgYml0LCBnbyBhaGVhZCBhbmQg cmVhZCBTUkRfQ1RMIAo+ID4gPj4gPj4gCj4gPiA+PiA+PiBBbmQgd2hpY2ggYml0IGlzIHRoYXQ/ Cj4gPiA+Cj4gPiA+IEJpdCAyOSAoQ29udGV4dCByZXN0b3JlIHRvIFBTUiBBY3RpdmUpIGluIFNS RF9DVEwuICBJJ2xsIGFkZCBpdCB0byB0aGUKPiA+ID4gY29tbWl0IG1lc3NhZ2UuICBJdCdzIHdv cnRoIG5vdGluZyB0aGF0IHRoZSBiaXQgaXMgbm90IHRlY2huaWNhbGx5Cj4gPiA+IHJlc2VydmVk LCBidXQgcmF0aGVyIHRoYXQgU1cgaXMgbm90IGFsbG93ZWQgdG8gY2hhbmdlIGl0Lgo+ID4gPgo+ ID4gPj4gPgo+ID4gPj4gPiBJIHRoaW5rIHdlIHdvdWxkIGFsbCBiZSBoYXBwaWVyIHdpdGgga2Vl cGluZyB0aGUgZXhwbGljaXQgY29uc3RydWN0aW9uCj4gPiA+PiA+IChhbmQgYSBzbWFsbGVyIHBh dGNoKSBpZiB3ZSB1c2VkCj4gPiA+PiA+Cj4gPiA+PiA+IAl2YWwgfD0gSTkxNV9SRUFEKEVEUF9Q U1JfQ1RMKSAmIEVEUF9QU1JfQ1RMX1JTVkRfTUFTSzsKPiA+ID4+IAo+ID4gPj4gQWdyZWVkLiBB dm9pZCByZWFkLW1vZGlmeS13cml0ZSBhcyBtdWNoIGFzIHBvc3NpYmxlLgo+ID4gPgo+ID4gPiBJ IGNhbiBkbyB0aGlzIGlmIGV2ZXJ5b25lIHRoaW5rcyBpdCdzIHRoZSB0aGluZyB0byBkbywgYnV0 IGl0Cj4gPiA+IGRvZXMgb3BlbiB1cyB1cCB0byBhIHNpbWlsYXIgY2xhc3Mgb2YgYnVnIChCLVNw ZWMgcmVzdHJpY3RpbmcgbW9kcwo+ID4gPiB0byBhIGJpdCAvIGJpdCByYW5nZSBhZnRlciBpbml0 aWFsIHN1cHBvcnQgZm9yIGEgcGxhdGZvcm0gd2FzIGFkZGVkKQo+ID4gPiBpbiB0aGUgZnV0dXJl LiAgSU1ITyB0aGUgY29kZSBhcyB3cml0dGVuIGlzIHNhZmVyLgo+ID4gCj4gPiBDaHJpcycgc3Vn Z2VzdGlvbiBwcmVzZXJ2ZXMgdGhlIHJlc3RyaWN0ZWQgYml0cyB0aGF0IG11c3QgcmVtYWluIHRo ZQo+ID4gc2FtZSwgd2hpbGUgaW5pdGlhbGl6aW5nIGV2ZXJ5dGhpbmcgZWxzZS4gSW5zdGVhZCBv ZiBvbmx5IGNoYW5naW5nIHRoZQo+ID4gYml0cyB3ZSBtdXN0IGNoYW5nZSwgb25seSBwcmVzZXJ2 ZSB0aGUgYml0cyB3ZSBtdXN0IG5vdCBjaGFuZ2UuIFNvcnJ5IGlmCj4gPiBJIHdhc24ndCBjbGVh ciB3aXRoIHRoZSAiYXMgbXVjaCBhcyBwb3NzaWJsZSIgcGFydCB0aGVyZS4KPiAKPiBJIHRoaW5r IEkgZm9sbG93ZWQgeW91LiAgV2hhdCBJIHdhcyB0cnlpbmcgdG8gaGlnaGxpZ2h0IGlzIHRoYXQg dGhlCj4gcGF0Y2ggYXMgd3JpdHRlbiBkb2Vzbid0IHRvdWNoIGFueXRoaW5nIG90aGVyIHRoYW4g d2hhdCB3ZSBleHBsaWNpdGx5Cj4gbmVlZCB0byBpbml0aWFsaXplLiAgV2hpbGUgQ2hyaXMnIHN1 Z2dlc3Rpb24gaXMgbXVjaCBtb3JlIHRlcnNlLCBpdAo+IGxlYXZlcyB1cyBvcGVuIHRvIGFub3Ro ZXIgYml0IGJlaW5nIGZsYWdnZWQgb3V0IGFzICdzb2Z0d2FyZQo+IHNob3VsZG4ndCBjaGFuZ2Un IGFuZCB3ZSdkIGhhdmUgYSBzaW1pbGFyIGJ1ZyBhZ2Fpbi4gIFRoZSBwYXRjaCBhcwo+IHdyaXR0 ZW4gZG9lc24ndCBleHBvc2UgdXMgdG8gdGhhdCBzaXR1YXRpb24uICBJJ20gaGFwcHkgdG8gZ28g d2l0aAo+IENocmlzJyBzdWdnZXN0aW9uIGlmIGV2ZXJ5b25lIHN0aWxsIHRoaW5rcyBpdCdzIHRo ZSByaWdodCB0aGluZywgYnV0Cj4gSSB3YW50ZWQgdG8gaGlnaGxpZ2h0IHRoYXQgaXQncyBub3Qg ZW50aXJlbHkgZXF1aXZhbGVudCB0byB3aGF0IHdhcwo+IGluIHRoZSBvcmlnaW5hbCBwYXRjaCBh bmQgaW4gbXkgb3BpbmlvbiBpdCdzIGxlc3Mgc2FmZSB0aGFuIHRoZQo+IG9yaWdpbmFsIHBhdGNo LgoKCk9rLCBmb2xrcyB0aGluayBicmV2aXR5IHdpbnMgb3V0IGhlcmUsIHNvIEknbSBnb2luZyB0 byBnbyBhaGVhZCBhbmQKc3BpbiBhIGRpZmZlcmVudCwgc3RhbmQtYWxvbmUgIHBhdGNoIGZvbGxv d2luZyBDaHJpcycgc3VnZ2VzdGlvbi4KUGxlYXNlIGRpc3JlZ2FyZCB0aGlzIG9uZS4KCkppbQoK Cj4gPiBQcmVzZXJ2aW5nIHRoZSByZXN0cmljdGVkIGJpdHMgaXMgYSBmdW5jdGlvbmFsIGNoYW5n ZSwgYW5kIHRoZSBzdWJqZWN0Cj4gPiBvZiB0aGlzIHBhdGNoIGRvZXMgbm90IHJlZmxlY3QgdGhh dC4gV2hlbiBJIGxvb2sgYXQgdGhlIGxvZ3MsIEkgcHJldHR5Cj4gPiBtdWNoIGV4cGVjdCBjbGVh biB1cCBjb21taXRzIHRvIGJlIG5vbi1mdW5jdGlvbmFsLiBUaGVyZSBhcmUgc29tZSBhcmVhcwo+ ID4gd2hlcmUgSSdkIGxvb2sgdGhlIG90aGVyIHdheSwgYnV0IFBTUiBpcyBzb21ldGhpbmcgd2hl cmUgd2UgbXVzdAo+ID4gY2FyZWZ1bGx5IHNwbGl0IHVwIHRoZSBwYXRjaGVzIGFuZCB3cml0ZSB0 aGUgY29tbWl0IG1lc3NhZ2VzIGRpbGlnZW50bHksCj4gPiBiZWNhdXNlIEkga25vdyB3ZSB3aWxs IGJlIHNwZW5kaW5nIHRpbWUgZGVidWdnaW5nIHRoaXMgY29kZSBhbmQgcmVhZGluZwo+ID4gdGhl IGxvZ3MuCj4gCj4gSSB3aWxsIHJlbW92ZSB0aGUgd29yZCAnY2xlYW4tdXAnIGFuZCByZXdvcmQg dGhlIHN1YmplY3QsIGluZGVwZW5kZW50Cj4gb2Ygd2hhdCB3ZSBkZWNpZGUgcmVsYXRpdmUgdG8g dGhlIHR3byBhcHByb2FjaGVzIGRlc2NyaWJlZCBhYm92ZS4KPiBUaGUgYm9keSBvZiB0aGUgY29t bWl0IG1lc3NhZ2UgKElNSE8pIGRvZXMgYSBnb29kIGpvYiAoYW5kIEknbGwgYWRkCj4gdGhlIHNw ZWNpZmljIGJpdCBpbiBTUkRfQ1RMIHRvIHRoZSBib2R5IGFsc28pIG9mIGRlc2NyaWJpbmcgdGhl Cj4gZnVuY3Rpb25hbCBjaGFuZ2VzIHRoYXQgdGhlIHBhdGNoIG1ha2VzLgo+IAo+IEppbQo+IAo+ ID4gQlIsCj4gPiBKYW5pLgo+ID4gCj4gPiAKPiA+IAo+ID4gPgo+ID4gPiBKaW0KPiA+ID4KPiA+ ID4KPiA+ID4+IAo+ID4gPj4gQlIsCj4gPiA+PiBKYW5pLgo+ID4gPj4gCj4gPiA+PiAKPiA+ID4+ IC0tIAo+ID4gPj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2Vu dGVyCj4gPiA+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+ID4gPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPj4gSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+ID4gPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKPiA+IAo+ID4gLS0gCj4gPiBKYW5pIE5pa3VsYSwgSW50ZWwg T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==