Re: [PATCH v13 2/7] drm: Introduce RGB 64-bit 16:16:16:16 float format

Daniel Vetter
2017-08-15T14:49:55Z

On Tue, Jul 25, 2017 at 05:28:15PM +0800, Tina Zhang wrote:
> The RGB 64-bit 16:16:16:16 float pixel format is needed by windows
> guest VM. This patch is to introduce the format to drm.
>
> v1:
> Suggested by Ville to submit this patch to dri-devel.
>
> Signed-off-by: Xiaoguang Chen <xiaoguang.chen@intel.com>
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> ---
> include/uapi/drm/drm_fourcc.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 7586c46..3e002e3 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -113,6 +113,10 @@ extern "C" {
>
> #define DRM_FORMAT_AYUV fourcc_code('A', 'Y', 'U', 'V') /* [31:0] A:Y:Cb:Cr 8:8:8:8 little endian */
>
> +/* 64 bpp RGB */
> +#define DRM_FORMAT_XRGB161616 fourcc_code('X', 'R', '4', '8') /* [63:0] x:R:G:B 16:16:16:16 little endian */
> +#define DRM_FORMAT_XBGR161616 fourcc_code('X', 'B', '4', '8') /* [63:0] x:B:G:R 16:16:16:16 little endian */

I think the comment should go a bit more into detail what the float
format is supposed to look like. And I think we should have a F or _FLOAT suffix to
the defined name, since the same layout could also work for integers (and
some hw somewhere probably has that. Maybe also put that F into the last
slot of the fourcc.
-Daniel
> +
> /*
> * 2 plane RGB + A
> * index 0 = RGB plane, same format as the corresponding non _A8 format has
> --
> 2.7.4
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org