* [PATCH] drm/i915/guc: Rename GuC irq trigger function
@ 2017-08-09 17:28 Michal Wajdeczko
2017-08-09 17:46 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Michal Wajdeczko @ 2017-08-09 17:28 UTC (permalink / raw)
To: intel-gfx
We should emphasize that irq trigger function depends on Gen.
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/intel_uc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 27e072c..d78ecae 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -94,7 +94,7 @@ void intel_uc_sanitize_options(struct drm_i915_private *dev_priv)
i915.enable_guc_submission = HAS_GUC_SCHED(dev_priv);
}
-static void guc_write_irq_trigger(struct intel_guc *guc)
+static void gen8_guc_trigger_irq(struct intel_guc *guc)
{
struct drm_i915_private *dev_priv = guc_to_i915(guc);
@@ -109,7 +109,7 @@ void intel_uc_init_early(struct drm_i915_private *dev_priv)
mutex_init(&guc->send_mutex);
guc->send = intel_guc_send_nop;
- guc->notify = guc_write_irq_trigger;
+ guc->notify = gen8_guc_trigger_irq;
}
static void fetch_uc_fw(struct drm_i915_private *dev_priv,
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function
2017-08-09 17:28 [PATCH] drm/i915/guc: Rename GuC irq trigger function Michal Wajdeczko
@ 2017-08-09 17:46 ` Patchwork
2017-08-12 18:00 ` Chris Wilson
2017-08-09 20:55 ` [PATCH] " Chris Wilson
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2017-08-09 17:46 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Rename GuC irq trigger function
URL : https://patchwork.freedesktop.org/series/28570/
State : success
== Summary ==
Series 28570v1 drm/i915/guc: Rename GuC irq trigger function
https://patchwork.freedesktop.org/api/1.0/series/28570/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:440s
fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:417s
fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:361s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:494s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:492s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:525s
fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:513s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:581s
fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:433s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:416s
fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:421s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:506s
fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:477s
fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:458s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:568s
fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:573s
fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:518s
fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:448s
fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:647s
fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:470s
fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:433s
fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:485s
fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:551s
fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:405s
db85100f75f1c20b2058bdc03939a5d377a263e6 drm-tip: 2017y-08m-09d-16h-41m-17s UTC integration manifest
f417295f785d drm/i915/guc: Rename GuC irq trigger function
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5353/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915/guc: Rename GuC irq trigger function
2017-08-09 17:28 [PATCH] drm/i915/guc: Rename GuC irq trigger function Michal Wajdeczko
2017-08-09 17:46 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-08-09 20:55 ` Chris Wilson
2017-08-09 21:12 ` Michal Wajdeczko
2017-08-09 21:26 ` [PATCH v2] " Michal Wajdeczko
2017-08-09 21:57 ` ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function (rev2) Patchwork
3 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2017-08-09 20:55 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx
Quoting Michal Wajdeczko (2017-08-09 18:28:07)
> We should emphasize that irq trigger function depends on Gen.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_uc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index 27e072c..d78ecae 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -94,7 +94,7 @@ void intel_uc_sanitize_options(struct drm_i915_private *dev_priv)
> i915.enable_guc_submission = HAS_GUC_SCHED(dev_priv);
> }
>
> -static void guc_write_irq_trigger(struct intel_guc *guc)
> +static void gen8_guc_trigger_irq(struct intel_guc *guc)
> {
> struct drm_i915_private *dev_priv = guc_to_i915(guc);
>
> @@ -109,7 +109,7 @@ void intel_uc_init_early(struct drm_i915_private *dev_priv)
>
> mutex_init(&guc->send_mutex);
> guc->send = intel_guc_send_nop;
> - guc->notify = guc_write_irq_trigger;
> + guc->notify = gen8_guc_trigger_irq;
My vocab, so I may have this completely backwards,
irq = pin/wire for asserting the interrupt (hw)
interrupt = the act of interrupting the CPU
(so we have irq_handlers and interrupt context)
So gen8_guc_trigger_irq is
- from gen8 onwards
- interfacing with the guc
- trigger an irq
It is the last part that causes a bit of confusion for me, I would have
actually gone with guc->notify = gen8_guc_raise_irq or
gen8_guc_send_interrupt.
But definitely trigger_irq is already more meaningful (or at least less
misleading) than write_irq_trigger.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915/guc: Rename GuC irq trigger function
2017-08-09 20:55 ` [PATCH] " Chris Wilson
@ 2017-08-09 21:12 ` Michal Wajdeczko
0 siblings, 0 replies; 7+ messages in thread
From: Michal Wajdeczko @ 2017-08-09 21:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Wed, Aug 09, 2017 at 09:55:03PM +0100, Chris Wilson wrote:
> Quoting Michal Wajdeczko (2017-08-09 18:28:07)
> > We should emphasize that irq trigger function depends on Gen.
> >
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_uc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> > index 27e072c..d78ecae 100644
> > --- a/drivers/gpu/drm/i915/intel_uc.c
> > +++ b/drivers/gpu/drm/i915/intel_uc.c
> > @@ -94,7 +94,7 @@ void intel_uc_sanitize_options(struct drm_i915_private *dev_priv)
> > i915.enable_guc_submission = HAS_GUC_SCHED(dev_priv);
> > }
> >
> > -static void guc_write_irq_trigger(struct intel_guc *guc)
> > +static void gen8_guc_trigger_irq(struct intel_guc *guc)
> > {
> > struct drm_i915_private *dev_priv = guc_to_i915(guc);
> >
> > @@ -109,7 +109,7 @@ void intel_uc_init_early(struct drm_i915_private *dev_priv)
> >
> > mutex_init(&guc->send_mutex);
> > guc->send = intel_guc_send_nop;
> > - guc->notify = guc_write_irq_trigger;
> > + guc->notify = gen8_guc_trigger_irq;
>
> My vocab, so I may have this completely backwards,
>
> irq = pin/wire for asserting the interrupt (hw)
>
> interrupt = the act of interrupting the CPU
>
> (so we have irq_handlers and interrupt context)
>
> So gen8_guc_trigger_irq is
> - from gen8 onwards
> - interfacing with the guc
> - trigger an irq
> It is the last part that causes a bit of confusion for me, I would have
> actually gone with guc->notify = gen8_guc_raise_irq or
> gen8_guc_send_interrupt.
From above proposals I prefer gen8_guc_raise_irq, as
gen8_guc_send_"the act of interrupting the CPU" is also confusing
Thanks,
Michal
>
> But definitely trigger_irq is already more meaningful (or at least less
> misleading) than write_irq_trigger.
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drm/i915/guc: Rename GuC irq trigger function
2017-08-09 17:28 [PATCH] drm/i915/guc: Rename GuC irq trigger function Michal Wajdeczko
2017-08-09 17:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-09 20:55 ` [PATCH] " Chris Wilson
@ 2017-08-09 21:26 ` Michal Wajdeczko
2017-08-09 21:57 ` ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function (rev2) Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Michal Wajdeczko @ 2017-08-09 21:26 UTC (permalink / raw)
To: intel-gfx
We should emphasize that irq raising function depends on Gen.
v2: use yet another better name (Chris)
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_uc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 27e072c..0178ba4 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -94,7 +94,7 @@ void intel_uc_sanitize_options(struct drm_i915_private *dev_priv)
i915.enable_guc_submission = HAS_GUC_SCHED(dev_priv);
}
-static void guc_write_irq_trigger(struct intel_guc *guc)
+static void gen8_guc_raise_irq(struct intel_guc *guc)
{
struct drm_i915_private *dev_priv = guc_to_i915(guc);
@@ -109,7 +109,7 @@ void intel_uc_init_early(struct drm_i915_private *dev_priv)
mutex_init(&guc->send_mutex);
guc->send = intel_guc_send_nop;
- guc->notify = guc_write_irq_trigger;
+ guc->notify = gen8_guc_raise_irq;
}
static void fetch_uc_fw(struct drm_i915_private *dev_priv,
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function (rev2)
2017-08-09 17:28 [PATCH] drm/i915/guc: Rename GuC irq trigger function Michal Wajdeczko
` (2 preceding siblings ...)
2017-08-09 21:26 ` [PATCH v2] " Michal Wajdeczko
@ 2017-08-09 21:57 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-08-09 21:57 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Rename GuC irq trigger function (rev2)
URL : https://patchwork.freedesktop.org/series/28570/
State : success
== Summary ==
Series 28570v2 drm/i915/guc: Rename GuC irq trigger function
https://patchwork.freedesktop.org/api/1.0/series/28570/revisions/2/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:441s
fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:418s
fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:358s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:489s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:496s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:524s
fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:517s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:587s
fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:438s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:410s
fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:419s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:506s
fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:474s
fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:457s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:565s
fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:579s
fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:525s
fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:445s
fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:646s
fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:461s
fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:425s
fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:488s
fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s
fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:413s
2d0288b5b28c0d67460f0258a41bb4f78b812f29 drm-tip: 2017y-08m-09d-18h-09m-54s UTC integration manifest
7ced1aeacfcc drm/i915/guc: Rename GuC irq trigger function
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5361/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-12 18:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 17:28 [PATCH] drm/i915/guc: Rename GuC irq trigger function Michal Wajdeczko
2017-08-09 17:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-12 18:00 ` Chris Wilson
2017-08-09 20:55 ` [PATCH] " Chris Wilson
2017-08-09 21:12 ` Michal Wajdeczko
2017-08-09 21:26 ` [PATCH v2] " Michal Wajdeczko
2017-08-09 21:57 ` ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox