public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 12/22] drm/i915: support 2M pages for the 48b PPGTT
Date: Tue, 15 Aug 2017 19:12:05 +0100	[thread overview]
Message-ID: <20170815181215.18310-13-matthew.auld@intel.com> (raw)
In-Reply-To: <20170815181215.18310-1-matthew.auld@intel.com>

Support inserting 2M pages into the 48b PPGTT.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 10 ++++++++++
 drivers/gpu/drm/i915/i915_gem_gtt.h |  2 ++
 2 files changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index c750770e75a1..aeef20a9ea0a 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -978,6 +978,16 @@ static void gen8_ppgtt_insert_huge_entries(struct i915_vma *vma,
 			encode |= GEN8_PDPE_PS_1G;
 
 			vaddr = kmap_atomic_px(pdp);
+		} else if (vma->page_sizes.sg & I915_GTT_PAGE_SIZE_2M &&
+			   IS_ALIGNED(iter->dma, I915_GTT_PAGE_SIZE_2M) &&
+			   rem >= I915_GTT_PAGE_SIZE_2M && !idx.pte) {
+			index = idx.pde;
+			max = I915_PDES;
+			page_size = I915_GTT_PAGE_SIZE_2M;
+
+			encode |= GEN8_PDE_PS_2M;
+
+			vaddr = kmap_atomic_px(pd);
 		} else {
 			struct i915_page_table *pt = pd->page_table[idx.pde];
 
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
index e46f05f0cfd9..aa4488637fc9 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.h
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
@@ -149,6 +149,8 @@ typedef u64 gen8_ppgtt_pml4e_t;
 #define GEN8_PPAT_ELLC_OVERRIDE		(0<<2)
 #define GEN8_PPAT(i, x)			((u64)(x) << ((i) * 8))
 
+#define GEN8_PDE_PS_2M   BIT(7)
+
 #define GEN8_PDPE_PS_1G  BIT(7)
 
 struct sg_table;
-- 
2.13.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-08-15 18:17 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 18:11 [PATCH 00/22] huge gtt pages Matthew Auld
2017-08-15 18:11 ` [PATCH 01/22] mm/shmem: introduce shmem_file_setup_with_mnt Matthew Auld
2017-08-15 18:11 ` [PATCH 02/22] drm/i915: introduce simple gemfs Matthew Auld
2017-08-15 18:11 ` [PATCH 03/22] drm/i915/gemfs: enable THP Matthew Auld
2017-08-15 18:11 ` [PATCH 04/22] drm/i915: introduce page_size_mask to dev_info Matthew Auld
2017-08-15 18:11 ` [PATCH 05/22] drm/i915: introduce page_size members Matthew Auld
2017-08-15 18:31   ` Chris Wilson
2017-08-15 18:37   ` Chris Wilson
2017-08-15 18:11 ` [PATCH 06/22] drm/i915: introduce vm set_pages/clear_pages Matthew Auld
2017-08-15 18:46   ` Chris Wilson
2017-08-15 18:12 ` [PATCH 07/22] drm/i915: align the vma start to the largest gtt page size Matthew Auld
2017-08-15 18:12 ` [PATCH 08/22] drm/i915: align 64K objects to 2M Matthew Auld
2017-08-15 18:12 ` [PATCH 09/22] drm/i915: enable IPS bit for 64K pages Matthew Auld
2017-08-15 18:48   ` Chris Wilson
2017-08-15 18:12 ` [PATCH 10/22] drm/i915: disable GTT cache for 2M/1G pages Matthew Auld
2017-08-15 18:12 ` [PATCH 11/22] drm/i915: support 1G pages for the 48b PPGTT Matthew Auld
2017-08-18 20:29   ` kbuild test robot
2017-08-20  8:24   ` kbuild test robot
2017-08-15 18:12 ` Matthew Auld [this message]
2017-08-15 18:12 ` [PATCH 13/22] drm/i915: add support for 64K scratch page Matthew Auld
2017-08-15 18:58   ` Chris Wilson
2017-08-15 18:12 ` [PATCH 14/22] drm/i915: support 64K pages for the 48b PPGTT Matthew Auld
2017-08-15 18:12 ` [PATCH 15/22] drm/i915: accurate page size tracking for the ppgtt Matthew Auld
2017-08-15 18:12 ` [PATCH 16/22] drm/i915/debugfs: include some gtt page size metrics Matthew Auld
2017-08-15 18:12 ` [PATCH 17/22] drm/i915/selftests: huge page tests Matthew Auld
2017-08-15 18:12 ` [PATCH 18/22] drm/i915/selftests: mix huge pages Matthew Auld
2017-08-15 18:12 ` [PATCH 19/22] drm/i915: disable platform support for vGPU huge gtt pages Matthew Auld
2017-08-15 18:12 ` [PATCH 20/22] drm/i915: enable platform support for 64K pages Matthew Auld
2017-08-15 18:12 ` [PATCH 21/22] drm/i915: enable platform support for 2M pages Matthew Auld
2017-08-15 18:12 ` [PATCH 22/22] drm/i915: enable platform support for 1G pages Matthew Auld
2017-08-15 18:37 ` ✗ Fi.CI.BAT: warning for huge gtt pages (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815181215.18310-13-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox