Re: [PATCH 05/22] drm/i915: introduce page_size members

Chris Wilson
2017-08-15T18:31:43Z

Quoting Matthew Auld (2017-08-15 19:11:58)
> static int ____i915_gem_object_get_pages(struct drm_i915_gem_object *obj)
> {
> struct sg_table *pages;
> + unsigned int sg_mask = 0;
>
> GEM_BUG_ON(i915_gem_object_has_pinned_pages(obj));
>
> @@ -2485,11 +2514,11 @@ static int ____i915_gem_object_get_pages(struct drm_i915_gem_object *obj)
> return -EFAULT;
> }
>
> - pages = obj->ops->get_pages(obj);
> + pages = obj->ops->get_pages(obj, &sg_mask);
> if (unlikely(IS_ERR(pages)))
> return PTR_ERR(pages);
>
> - __i915_gem_object_set_pages(obj, pages);
> + __i915_gem_object_set_pages(obj, pages, sg_mask);

Just makes me keep wishing I did more than hint that we should move
__i915_gem_object_set_pages() down to the backend so that we don't need
this clumsy interface anymore. /whinge
-Chris