From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Bride Subject: Re: [PATCH v5] drm/i915/psr: Account for sink CRC raciness on some panels Date: Wed, 16 Aug 2017 10:32:55 -0700 Message-ID: <20170816173255.GA15124@shiv> References: <1502311200-28033-1-git-send-email-jim.bride@linux.intel.com> <20170815165830.GA2394@shiv> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA9DB6E50F for ; Wed, 16 Aug 2017 17:35:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: Jani Nikula , intel-gfx , Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMTUsIDIwMTcgYXQgMDQ6NDE6NTJQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFR1ZSwgQXVnIDE1LCAyMDE3IGF0IDk6NTggQU0sIEppbSBCcmlkZSA8amltLmJy aWRlQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBXZWQsIEF1ZyAwOSwgMjAxNyBhdCAw MTo0MDowMFBNIC0wNzAwLCBKaW0gQnJpZGUgd3JvdGU6Cj4gPj4gQWNjb3JkaW5nIHRvIHRoZSBl RFAgc3BlYywgd2hlbiB0aGUgY291bnQgZmllbGQgaW4gVEVTVF9TSU5LX01JU0MKPiA+PiBpbmNy ZW1lbnRzIHRoZW4gdGhlIHNpeCBieXRlcyBvZiBzaW5rIENSQyBpbmZvcm1hdGlvbiBpbiB0aGUg RFBDRAo+ID4+IHNob3VsZCBiZSB2YWxpZC4gIFVuZm9ydHVuYXRlbHksIHRoaXMgZG9lc24ndCBz ZWVtIHRvIGJlIHRoZSBjYXNlCj4gPj4gb24gc29tZSBwYW5lbHMsIGFuZCBhcyBhIHJlc3VsdCB3 ZSBnZXQgc29tZSBpbmNvcnJlY3QgYW5kIGluY29uc2lzdGVudAo+ID4+IHZhbHVlcyBmcm9tIHRo ZSBzaW5rIENSQyBEUENEIGxvY2F0aW9ucyBhdCB0aW1lcy4gIFRoaXMgcHJvYmxlbSBleGhpYml0 cwo+ID4+IGl0c2VsZiBtb3JlIG9uIGZhc3RlciBwcm9jZXNzb3JzIChyZWxhdGl2ZSBmYWlsdXJl IHJhdGVzIEhTVyA8IFNLTCA8IEtCTC4pCj4gPj4gSW4gb3JkZXIgdG8gdHJ5IGFuZCBhY2NvdW50 IGZvciB0aGlzLCB3ZSB0cnkgYSBsb3QgaGFyZGVyIHRvIHJlYWQgdGhlIHNpbmsKPiA+PiBDUkMg dW50aWwgd2UgZ2V0IGNvbnNpc3RlbnQgdmFsdWVzIHR3aWNlIGluIGEgcm93IGJlZm9yZSByZXR1 cm5pbmcgd2hhdCB3ZQo+ID4+IHJlYWQgYW5kIGRlbGF5IGZvciBhIHRpbWUgYmVmb3JlIHRyeWlu ZyB0byByZWFkLiAgV2Ugc3RpbGwgc2VlIHNvbWUKPiA+PiBvY2Nhc2lvbmFsIGZhaWx1cmVzLCBi dXQgcmVhZGluZyB0aGUgc2luayBDUkMgaXMgbXVjaCBtb3JlIHJlbGlhYmxlLAo+ID4+IHBhcnRp Y3VsYXJseSBvbiBTS0wsIHdpdGggdGhlc2UgY2hhbmdlcyB0aGFuIHdpdGhvdXQuCj4gPj4KPiA+ PiB2MjogKiBSZWR1Y2UgbnVtYmVyIG9mIHJldHJpZXMgd2hlbiByZWFkaW5nIHRoZSBzaW5rIENS QyAoSmFuaSkKPiA+PiAgICAgKiBSZWZhY3RvciB0byBtaW5pbWl6ZSBjaGFuZ2VzIHRvIHRoZSBj b2RlIChKYW5pKQo+ID4+ICAgICAqIFJlYmFzZQo+ID4+IHYzOiAqIFJlYmFzZQo+ID4+IHY0OiAq IFN3aXRjaCBmcm9tIGRvLXdoaWxlIHRvIGZvciBsb29wIHdoZW4gcmVhZGluZyBDUkMgdmFsdWVz IChKYW5pKQo+ID4+ICAgICAqIFJlYmFzZQo+ID4+IHY1OiAqIENoZWNrcGF0Y2ggY2xlYW51cCBh bmQgY29tbWl0IG1lc3NhZ2UgdHdlYWtzCj4gPj4gICAgICogUmViYXNlCj4gPj4gQ2M6IFJvZHJp Z28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+PiBDYzogUGF1bG8gWmFub25pIDxw YXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBpbnRlbC5jb20+Cj4gPgo+ID4gSSB0aGluayBJIGFkZHJlc3NlZCBhbGwgcHJldmlvdXMgcmV2 aWV3IGNvbW1lbnRzIGZvciB0aGlzIHBhdGNoLiAgQW55Cj4gPiB0aG91Z2h0cz8KPiAKPiBJIHN1 ZmZlcmVkIGEgbG90IHdpdGggdGhpcyB1bnJlbGlhYmxlIHNpbmsgY3JjcyBpbiB0aGUgcGFzdC4g QXMgeW91IEkgdHJpZWQgbWFueQo+IGRpZmZlcmVudCB0aGluZ3MgbGlrZSB0aGlzLCBidXQgdGhl eSBhcmUgc3RpbGwgdW5yZWxpYWJsZS4KPiAKPiBTbyBJIGJlbGlldmUgSSdtIGluIGZhdm9yIG9m IG9uZSBvZiBESydzIHN1Z2dlc3Rpb246Cj4gIiBPbiB0aGUgb3RoZXIgaGFuZCwgc2luY2UgdGhl IG9ubHkgY29uc3VtZXJzIG9mIGRwIHNpbmsgY3JjIGFyZSB0ZXN0cywKPiB3aHkgY2FuJ3QgdGhl IGtlcm5lbCBqdXN0IGR1bXAgd2hhdCBpdCByZWFkcyB0byBkZWJ1Z2ZzIGFuZCBsZXQgdGhlIHRl c3QKPiBkZWFsIHdpdGggZXJyb25lb3VzIHJlc3VsdHM/Cj4gIgo+IFNvIGxldCdzIGtlZXAgdGhl IGtlcm5lbCBkb2luZyB0aGUgcmlnaHQgdGhpbmcgYnkgdGhlIHNwZWMgYW5kIHRyeSB0bwo+IGNo YW5nZSB0ZXN0IGNhc2VzIHRvIGRlYWwgd2l0aCB0aGlzIGJhZCB2YWx1ZXMuCgpPay4gIEkgbW92 ZWQgdGhlIGxvZ2ljIGludG8gdGhlIElHVCBsaWJyYXJ5J3MgY2FsbCBmb3IgcmVhZGluZyBzaW5r CmNyY3MuCgo+IE9yIGxldCdzIGZpbmQgc29tZSBvdGhlciB3YXkgdG8gdGVzdCB0aGlzIHdpdGhv dXQgc2luayBjcmMuLi4gYW5kCj4gYW55d2F5cyBJIGJlbGlldmUgdGhhdCB3ZSBzaG91bGQganVz dCBkcm9wIHRoaXMgcGF0Y2guCgpUaGlzIGlzIHRoZSBsb25nZXItdGVybSBwbGFuLiAgIFdlIG5l ZWQgc2ltaWxhciB0ZXN0cyBmb3IgUFNSIDIsCndoaWNoIGRvZXNuJ3Qgc3VwcG9ydCBzaW5rIGNy Y3MsIGFueWhvdy4KCkppbQoKCj4gPgo+ID4gSmltCj4gPgo+ID4+IFNpZ25lZC1vZmYtYnk6IEpp bSBCcmlkZSA8amltLmJyaWRlQGxpbnV4LmludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPj4gaW5kZXggNzZjOGEwYi4u YjY0NzU3YyAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j Cj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4+IEBAIC0zOTA2 LDYgKzM5MDYsMTAgQEAgaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHAsIHU4ICpjcmMpCj4gPj4gICAgICAgdTggYnVmOwo+ID4+ICAgICAgIGludCBjb3VudCwg cmV0Owo+ID4+ICAgICAgIGludCBhdHRlbXB0cyA9IDY7Cj4gPj4gKyAgICAgdTggb2xkX2NyY1s2 XTsKPiA+PiArCj4gPj4gKyAgICAgaWYgKGNyYyA9PSBOVUxMKQo+ID4+ICsgICAgICAgICAgICAg cmV0dXJuIC1FTk9NRU07Cj4gPj4KPiA+PiAgICAgICByZXQgPSBpbnRlbF9kcF9zaW5rX2NyY19z dGFydChpbnRlbF9kcCk7Cj4gPj4gICAgICAgaWYgKHJldCkKPiA+PiBAQCAtMzkyOSwxMSArMzkz MywzMyBAQCBpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwg dTggKmNyYykKPiA+PiAgICAgICAgICAgICAgIGdvdG8gc3RvcDsKPiA+PiAgICAgICB9Cj4gPj4K PiA+PiAtICAgICBpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9D UkNfUl9DUiwgY3JjLCA2KSA8IDApIHsKPiA+PiAtICAgICAgICAgICAgIHJldCA9IC1FSU87Cj4g Pj4gLSAgICAgICAgICAgICBnb3RvIHN0b3A7Cj4gPj4gKyAgICAgLyoKPiA+PiArICAgICAgKiBT b21ldGltZXMgaXQgdGFrZXMgYSB3aGlsZSBmb3IgdGhlICJyZWFsIiBDUkMgdmFsdWVzIHRvIGxh bmQgaW4KPiA+PiArICAgICAgKiB0aGUgRFBDRCwgc28gdHJ5IHNldmVyYWwgdGltZXMgdW50aWwg d2UgZ2V0IHR3byByZWFkcyBpbiBhIHJvdwo+ID4+ICsgICAgICAqIHRoYXQgYXJlIHRoZSBzYW1l LiAgSWYgd2UncmUgYW4gZURQIHBhbmVsLCBkZWxheSBiZXR3ZWVuIHJlYWRzCj4gPj4gKyAgICAg ICogZm9yIGEgd2hpbGUgc2luY2UgdGhlIHZhbHVlcyB0YWtlIGEgYml0IGxvbmdlciB0byBwcm9w YWdhdGUuCj4gPj4gKyAgICAgICovCj4gPj4gKyAgICAgZm9yIChhdHRlbXB0cyA9IDA7IGF0dGVt cHRzIDwgNjsgYXR0ZW1wdHMrKykgewo+ID4+ICsgICAgICAgICAgICAgaW50ZWxfd2FpdF9mb3Jf dmJsYW5rKGRldl9wcml2LCBpbnRlbF9jcnRjLT5waXBlKTsKPiA+PiArCj4gPj4gKyAgICAgICAg ICAgICBpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9DUkNfUl9D UiwKPiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNyYywgNikgPCAwKSB7 Cj4gPj4gKyAgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FSU87Cj4gPj4gKyAgICAgICAgICAg ICAgICAgICAgIGJyZWFrOwo+ID4+ICsgICAgICAgICAgICAgfQo+ID4+ICsKPiA+PiArICAgICAg ICAgICAgIGlmIChhdHRlbXB0cyAmJiBtZW1jbXAob2xkX2NyYywgY3JjLCA2KSA9PSAwKQo+ID4+ ICsgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiA+PiArICAgICAgICAgICAgIG1lbWNweShv bGRfY3JjLCBjcmMsIDYpOwo+ID4+ICsKPiA+PiArICAgICAgICAgICAgIGlmIChpc19lZHAoaW50 ZWxfZHApKQo+ID4+ICsgICAgICAgICAgICAgICAgICAgICB1c2xlZXBfcmFuZ2UoMjAwMDAsIDI1 MDAwKTsKPiA+PiAgICAgICB9Cj4gPj4KPiA+PiArICAgICBpZiAoYXR0ZW1wdHMgPT0gNikgewo+ ID4+ICsgICAgICAgICAgICAgRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIGdldCBDUkMgYWZ0ZXIg NiBhdHRlbXB0cy5cbiIpOwo+ID4+ICsgICAgICAgICAgICAgcmV0ID0gLUVUSU1FRE9VVDsKPiA+ PiArICAgICB9Cj4gPj4gIHN0b3A6Cj4gPj4gICAgICAgaW50ZWxfZHBfc2lua19jcmNfc3RvcChp bnRlbF9kcCk7Cj4gPj4gICAgICAgcmV0dXJuIHJldDsKPiA+PiAtLQo+ID4+IDIuNy40Cj4gPj4K PiA+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo+IAo+IAo+IAo+IC0tIAo+IFJvZHJpZ28gVml2aQo+IEJsb2c6IGh0dHA6 Ly9ibG9nLnZpdmkuZW5nLmJyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=