Re: [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result

From: Manasi Navare <manasi.d.navare@intel.com>
To: Puthikorn Voravootivat <puthik@chromium.org>
Cc: intel-gfx@lists.freedesktop.org, Jim Bride <jim.bride@intel.com>,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result
Date: Wed, 23 Aug 2017 18:09:09 -0700	[thread overview]
Message-ID: <20170824010908.GA31833@intel.com> (raw)
In-Reply-To: <20170823224028.18943-1-puthik@chromium.org>

On Wed, Aug 23, 2017 at 03:40:28PM -0700, Puthikorn Voravootivat wrote:
> If the full detect is already done, we shouldn't need to do it
> again.
> 
> This fixes the screen blinking issue that happen when calling
> DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking
> is caused by full dp detect in intel_dp_long_pulse().
>

Thanks for the patch. Yes I completely agree with this, the
main purpose of this flag was to avoid calling long pulse
handler multiple times when it was being called from multiple places.
Now we do not need this flag since it does a full detect every time
get connector IOCTL is called since it calls intel_dp_detect().

This patch needs to remove the detect_done from all the other places
where its being set and from intel_dp struct as well.
I had already submitted a patch for this a while ago:
https://patchwork.freedesktop.org/patch/137592/
Please take a look. However if you read the M-L archive, you will
find the comments and it never got accepted. Some of the arguments
were that since EDID might have changed, we need to always do
a full detect each time GET_CONNECTOR IOCTL is called.

Regards
Manasi

> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index d3e5fdf0d2fa..152e7016d5f2 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4834,8 +4834,6 @@ intel_dp_detect(struct drm_connector *connector,
>  	if (!intel_dp->detect_done)
>  		status = intel_dp_long_pulse(intel_dp->attached_connector);
>  
> -	intel_dp->detect_done = false;
> -
>  	return status;
>  }
>  
> -- 
> 2.14.1.342.g6490525c54-goog
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx