From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 06/12] drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites
Date: Fri, 25 Aug 2017 14:34:42 +0300 [thread overview]
Message-ID: <20170825113442.GM4914@intel.com> (raw)
In-Reply-To: <CAPj87rMCpABgsJ50ArcrG5mLw_0i8cBudk-Tmcs8-wGJEODatw@mail.gmail.com>
On Fri, Aug 25, 2017 at 10:40:28AM +0100, Daniel Stone wrote:
> On 24 August 2017 at 20:10, <ville.syrjala@linux.intel.com> wrote:
> > Y/Yf somehow dropped out from the SKL+ sprite modifier list. Add them
> > in.
>
> There's no 'somehow':
> https://lists.freedesktop.org/archives/intel-gfx/2017-August/134932.html
>
> I would prefer to not see this pushed whilst it doesn't actually work.
Works fine here. Well, I should say it works just as well as it does for
the primary plane. There are no plane specific checks in the wm/ddb code
IIRC so if something is broken for sprites then it's most likely equally
broken for the primary plane.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-25 11:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 19:10 [PATCH 00/12] drm/i915: Fix up the CCS code ville.syrjala
2017-08-24 19:10 ` [PATCH 01/12] drm/i915: Treat fb->offsets[] as a raw byte offset instead of a linear offset ville.syrjala
2017-08-24 19:10 ` [PATCH 02/12] drm/i915: Skip fence alignemnt check for the CCS plane ville.syrjala
2017-08-25 4:56 ` Ben Widawsky
2017-08-24 19:10 ` [PATCH 03/12] drm/i915: Switch over to the LLC/eLLC hotspot avoidance hash mode for CCS ville.syrjala
2017-08-25 4:55 ` Ben Widawsky
2017-08-25 11:40 ` Ville Syrjälä
2017-09-13 23:29 ` Ben Widawsky
2017-09-14 12:09 ` Ville Syrjälä
2017-08-24 19:10 ` [PATCH 04/12] drm/i915: Add a comment exlaining CCS hsub/vsub ville.syrjala
2017-08-24 19:10 ` [PATCH 05/12] drm/i915: Nuke a pointless unreachable() ville.syrjala
2017-08-25 4:40 ` Ben Widawsky
2017-08-25 15:36 ` Emil Velikov
2017-08-24 19:10 ` [PATCH 06/12] drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites ville.syrjala
2017-08-25 9:40 ` Daniel Stone
2017-08-25 11:34 ` Ville Syrjälä [this message]
2017-08-25 13:58 ` Daniel Stone
2017-08-24 19:10 ` [PATCH 07/12] drm/i915: Clean up the sprite modifier checks ville.syrjala
2017-08-24 19:10 ` [PATCH 08/12] drm/i915: Add CCS capability for sprites ville.syrjala
2017-12-11 11:11 ` Mika Kahola
2017-12-11 12:00 ` Daniel Stone
2017-12-11 12:08 ` Mika Kahola
2017-12-11 12:33 ` Daniel Stone
2017-12-11 13:35 ` Ville Syrjälä
2017-08-24 19:10 ` [PATCH 09/12] drm/i915: Allow up to 32KB stride on SKL+ "sprites" ville.syrjala
2017-08-24 19:10 ` [PATCH 10/12] drm: Fix modifiers_property kernel doc ville.syrjala
2017-08-25 13:44 ` Daniel Vetter
2017-08-24 19:10 ` [PATCH 11/12] drm: Check that the plane supports the request format+modifier combo ville.syrjala
2017-08-25 13:47 ` [Intel-gfx] " Daniel Vetter
2017-08-24 19:11 ` [PATCH 12/12] drm/i915: Remove the pipe/plane ID checks from skl_check_ccs_aux_surface() ville.syrjala
2017-08-24 19:41 ` ✓ Fi.CI.BAT: success for drm/i915: Fix up the CCS code Patchwork
2017-08-24 21:05 ` ✓ Fi.CI.IGT: " Patchwork
2017-08-25 17:17 ` [PATCH 00/12] " Daniel Vetter
2017-08-28 13:35 ` Daniel Stone
2017-08-28 14:47 ` Ville Syrjälä
2017-08-30 8:31 ` Jani Nikula
2017-08-30 17:09 ` Ville Syrjälä
2017-09-01 0:05 ` Rodrigo Vivi
2017-09-01 13:46 ` Ville Syrjälä
2017-10-16 22:21 ` Kristian Høgsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825113442.GM4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=daniel@fooishbar.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).