From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 5/8] drm/i915/cnl: Move voltage check into ddi buf trans functions. Date: Wed, 30 Aug 2017 17:11:53 +0300 Message-ID: <20170830141153.GA4914@intel.com> References: <20170829232230.23051-1-rodrigo.vivi@intel.com> <20170829232230.23051-5-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32A836E0A7 for ; Wed, 30 Aug 2017 14:12:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170829232230.23051-5-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMjksIDIwMTcgYXQgMDQ6MjI6MjdQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IExldCdzIHN0YXJ0IGNvbnZlcmdpbmcgQ05MIGJ1ZiB0cmFuc2xhdGlvbnMgdG8gc2Ft ZSBzdHlsZQo+IHVzZWQgb24gcHJldmlvdXMgcGxhdGZvcm1zLiBTbyBmaXJzdCB0aGluZyBpcyB0 byB1c2UgdGhlCj4gc3RhbmRhcmQgc2lnbmF0dXJlIHNvIHdlIGRvbid0IG5lZWQgdG8gcHJvcGFn YXRlIHRoZSB2b2x0YWdlCj4gY2hlY2sgaW50byBvdGhlciBwYXJ0cyBvZiB0aGUgY29kZSwgYnV0 IG9ubHkgb24gdGhlIHBhcnRzCj4gdGhhdCBpdCBpcyByZWFsbHkgdXNlZnVsLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCA0OCArKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCsp LCAyNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IDUw Njc4MmMxYTYyYS4uN2I1NDdhN2Y2YzJiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RkaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMK PiBAQCAtMTgzMCw5ICsxODMwLDEwIEBAIHU4IGludGVsX2RkaV9kcF92b2x0YWdlX21heChzdHJ1 Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgfQo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVj dCBjbmxfZGRpX2J1Zl90cmFucyAqCj4gLWNubF9nZXRfYnVmX3RyYW5zX2hkbWkoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IC0JCSAgICAgICB1MzIgdm9sdGFnZSwgaW50ICpu X2VudHJpZXMpCj4gK2NubF9nZXRfYnVmX3RyYW5zX2hkbWkoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LCBpbnQgKm5fZW50cmllcykKPiAgewo+ICsJdTMyIHZvbHRhZ2UgPSBJOTE1 X1JFQUQoQ05MX1BPUlRfQ09NUF9EVzMpICYgVk9MVEFHRV9JTkZPX01BU0s7CgpJIHdvbmRlciBp ZiB3ZSBzaG91bGQganVzdCBjYWNoZSB0aGF0IHNvbWV3aGVyZS4gTXkgbWFpbiB3b3JyeSBpcwp3 aGV0aGVyIHRoZSBkZXZpY2UgaXMgYWx3YXlzIGF3YWtlIHdoZW4gd2UgY2FsbCB0aGlzIGNvZGUu Cgo+ICsKPiAgCWlmICh2b2x0YWdlID09IFZPTFRBR0VfSU5GT18wXzg1Vikgewo+ICAJCSpuX2Vu dHJpZXMgPSBBUlJBWV9TSVpFKGNubF9kZGlfdHJhbnNsYXRpb25zX2hkbWlfMF84NVYpOwo+ICAJ CXJldHVybiBjbmxfZGRpX3RyYW5zbGF0aW9uc19oZG1pXzBfODVWOwo+IEBAIC0xODQyLDE0ICsx ODQzLDE2IEBAIGNubF9nZXRfYnVmX3RyYW5zX2hkbWkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ICAJfSBlbHNlIGlmICh2b2x0YWdlID09IFZPTFRBR0VfSU5GT18xXzA1Vikg ewo+ICAJCSpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKGNubF9kZGlfdHJhbnNsYXRpb25zX2hkbWlf MV8wNVYpOwo+ICAJCXJldHVybiBjbmxfZGRpX3RyYW5zbGF0aW9uc19oZG1pXzFfMDVWOwo+IC0J fQo+ICsJfSBlbHNlCj4gKwkJTUlTU0lOR19DQVNFKHZvbHRhZ2UpOwoKbml0OiBMb29rcyBsaWtl IHRoZXNlIGlmIGxhZGRlcnMgY291bGQgYmUgdHVybmVkIGludG8gc3dpdGNoIHN0YXRlbWVudHMu CgoKQW55d2F5cywgcGF0Y2ggbGd0bQpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gIAlyZXR1cm4gTlVMTDsKPiAgfQo+ICAKPiAg c3RhdGljIGNvbnN0IHN0cnVjdCBjbmxfZGRpX2J1Zl90cmFucyAqCj4gLWNubF9nZXRfYnVmX3Ry YW5zX2RwKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkgICAgIHUzMiB2 b2x0YWdlLCBpbnQgKm5fZW50cmllcykKPiArY25sX2dldF9idWZfdHJhbnNfZHAoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgKm5fZW50cmllcykKPiAgewo+ICsJdTMyIHZv bHRhZ2UgPSBJOTE1X1JFQUQoQ05MX1BPUlRfQ09NUF9EVzMpICYgVk9MVEFHRV9JTkZPX01BU0s7 Cj4gKwo+ICAJaWYgKHZvbHRhZ2UgPT0gVk9MVEFHRV9JTkZPXzBfODVWKSB7Cj4gIAkJKm5fZW50 cmllcyA9IEFSUkFZX1NJWkUoY25sX2RkaV90cmFuc2xhdGlvbnNfZHBfMF84NVYpOwo+ICAJCXJl dHVybiBjbmxfZGRpX3RyYW5zbGF0aW9uc19kcF8wXzg1VjsKPiBAQCAtMTg1OSwxNCArMTg2Miwx NiBAQCBjbmxfZ2V0X2J1Zl90cmFuc19kcChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gIAl9IGVsc2UgaWYgKHZvbHRhZ2UgPT0gVk9MVEFHRV9JTkZPXzFfMDVWKSB7Cj4gIAkJ Km5fZW50cmllcyA9IEFSUkFZX1NJWkUoY25sX2RkaV90cmFuc2xhdGlvbnNfZHBfMV8wNVYpOwo+ ICAJCXJldHVybiBjbmxfZGRpX3RyYW5zbGF0aW9uc19kcF8xXzA1VjsKPiAtCX0KPiArCX0gZWxz ZQo+ICsJCU1JU1NJTkdfQ0FTRSh2b2x0YWdlKTsKPiAgCXJldHVybiBOVUxMOwo+ICB9Cj4gIAo+ ICBzdGF0aWMgY29uc3Qgc3RydWN0IGNubF9kZGlfYnVmX3RyYW5zICoKPiAtY25sX2dldF9idWZf dHJhbnNfZWRwKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkgICAgICB1 MzIgdm9sdGFnZSwgaW50ICpuX2VudHJpZXMpCj4gK2NubF9nZXRfYnVmX3RyYW5zX2VkcChzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCAqbl9lbnRyaWVzKQo+ICB7Cj4gKwl1 MzIgdm9sdGFnZSA9IEk5MTVfUkVBRChDTkxfUE9SVF9DT01QX0RXMykgJiBWT0xUQUdFX0lORk9f TUFTSzsKPiArCj4gIAlpZiAoZGV2X3ByaXYtPnZidC5lZHAubG93X3Zzd2luZykgewo+ICAJCWlm ICh2b2x0YWdlID09IFZPTFRBR0VfSU5GT18wXzg1Vikgewo+ICAJCQkqbl9lbnRyaWVzID0gQVJS QVlfU0laRShjbmxfZGRpX3RyYW5zbGF0aW9uc19lZHBfMF84NVYpOwo+IEBAIC0xODc3LDEwICsx ODgyLDExIEBAIGNubF9nZXRfYnVmX3RyYW5zX2VkcChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gIAkJfSBlbHNlIGlmICh2b2x0YWdlID09IFZPTFRBR0VfSU5GT18xXzA1Vikg ewo+ICAJCQkqbl9lbnRyaWVzID0gQVJSQVlfU0laRShjbmxfZGRpX3RyYW5zbGF0aW9uc19lZHBf MV8wNVYpOwo+ICAJCQlyZXR1cm4gY25sX2RkaV90cmFuc2xhdGlvbnNfZWRwXzFfMDVWOwo+IC0J CX0KPiArCQl9IGVsc2UKPiArCQkJTUlTU0lOR19DQVNFKHZvbHRhZ2UpOwo+ICAJCXJldHVybiBO VUxMOwo+ICAJfSBlbHNlIHsKPiAtCQlyZXR1cm4gY25sX2dldF9idWZfdHJhbnNfZHAoZGV2X3By aXYsIHZvbHRhZ2UsIG5fZW50cmllcyk7Cj4gKwkJcmV0dXJuIGNubF9nZXRfYnVmX3RyYW5zX2Rw KGRldl9wcml2LCBuX2VudHJpZXMpOwo+ICAJfQo+ICB9Cj4gIAo+IEBAIC0xODg4LDMxICsxODk0 LDE5IEBAIHN0YXRpYyB2b2lkIGNubF9kZGlfdnN3aW5nX3Byb2dyYW0oc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkJICAgIHUzMiBsZXZlbCwgZW51bSBwb3J0IHBvcnQs IGludCB0eXBlKQo+ICB7Cj4gIAljb25zdCBzdHJ1Y3QgY25sX2RkaV9idWZfdHJhbnMgKmRkaV90 cmFuc2xhdGlvbnMgPSBOVUxMOwo+IC0JdTMyIG5fZW50cmllcywgdmFsLCB2b2x0YWdlOwo+ICsJ dTMyIG5fZW50cmllcywgdmFsOwo+ICAJaW50IGxuOwo+ICAKPiAtCS8qCj4gLQkgKiBWYWx1ZXMg Zm9yIGVhY2ggcG9ydCB0eXBlIGFyZSBsaXN0ZWQgaW4KPiAtCSAqIHZvbHRhZ2Ugc3dpbmcgcHJv Z3JhbW1pbmcgdGFibGVzLgo+IC0JICogVmNjaW8gdm9sdGFnZSBmb3VuZCBpbiBQT1JUX0NPTVBf RFczLgo+IC0JICovCj4gLQl2b2x0YWdlID0gSTkxNV9SRUFEKENOTF9QT1JUX0NPTVBfRFczKSAm IFZPTFRBR0VfSU5GT19NQVNLOwo+IC0KPiAgCWlmICh0eXBlID09IElOVEVMX09VVFBVVF9IRE1J KSB7Cj4gLQkJZGRpX3RyYW5zbGF0aW9ucyA9IGNubF9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3By aXYsCj4gLQkJCQkJCQkgIHZvbHRhZ2UsICZuX2VudHJpZXMpOwo+ICsJCWRkaV90cmFuc2xhdGlv bnMgPSBjbmxfZ2V0X2J1Zl90cmFuc19oZG1pKGRldl9wcml2LCAmbl9lbnRyaWVzKTsKPiAgCX0g ZWxzZSBpZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRfRFApIHsKPiAtCQlkZGlfdHJhbnNsYXRpb25z ID0gY25sX2dldF9idWZfdHJhbnNfZHAoZGV2X3ByaXYsCj4gLQkJCQkJCQl2b2x0YWdlLCAmbl9l bnRyaWVzKTsKPiArCQlkZGlfdHJhbnNsYXRpb25zID0gY25sX2dldF9idWZfdHJhbnNfZHAoZGV2 X3ByaXYsICZuX2VudHJpZXMpOwo+ICAJfSBlbHNlIGlmICh0eXBlID09IElOVEVMX09VVFBVVF9F RFApIHsKPiAtCQlkZGlfdHJhbnNsYXRpb25zID0gY25sX2dldF9idWZfdHJhbnNfZWRwKGRldl9w cml2LAo+IC0JCQkJCQkJIHZvbHRhZ2UsICZuX2VudHJpZXMpOwo+ICsJCWRkaV90cmFuc2xhdGlv bnMgPSBjbmxfZ2V0X2J1Zl90cmFuc19lZHAoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+ICAJfQo+ ICAKPiAtCWlmIChkZGlfdHJhbnNsYXRpb25zID09IE5VTEwpIHsKPiAtCQlNSVNTSU5HX0NBU0Uo dm9sdGFnZSk7Cj4gKwlpZiAoV0FSTl9PTihkZGlfdHJhbnNsYXRpb25zID09IE5VTEwpKQo+ICAJ CXJldHVybjsKPiAtCX0KPiAgCj4gIAlpZiAobGV2ZWwgPj0gbl9lbnRyaWVzKSB7Cj4gIAkJRFJN X0RFQlVHX0tNUygiRERJIHRyYW5zbGF0aW9uIG5vdCBmb3VuZCBmb3IgbGV2ZWwgJWQuIFVzaW5n ICVkIGluc3RlYWQuIiwgbGV2ZWwsIG5fZW50cmllcyAtIDEpOwo+IC0tIAo+IDIuMTMuMgo+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==